Closed
Bug 223292
Opened 21 years ago
Closed 19 years ago
Default mailViews.dat contains hardcoded English descriptions
Categories
(MailNews Core :: Localization, defect)
MailNews Core
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pkwarren, Assigned: mscott)
References
Details
(Whiteboard: [affects l10n] patch by pkw, needs review (mscott))
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Bienvenu
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
The default mailViews.dat file contains the following hardcoded text:
3 name="People I Know"
7 name="Recent Mail"
11 name="Last 5 Days"
15 name="Not Junk"
19 name="Has Attachments"
If possible, these strings should be placed in a .dtd or .properties file to
enable easier translation. The format of this file is not one that most
translators are familiar with, and there are several other lines in the file
that should not be translated (enabled=..., condition=...)
Comment 1•21 years ago
|
||
This should definately be done, I would consider this a critical bug in the
internationalization of Mozilla. As I understand it theese are the only strings
that have not been put together with the rest of the localization-information?
Updated•21 years ago
|
Flags: blocking1.7a?
Comment 2•21 years ago
|
||
can someone put together a patch? lets shoot to have this done by 1.7b if
someone can get the work done.
Flags: blocking1.7a? → blocking1.7a-
Reporter | ||
Updated•21 years ago
|
Assignee: rchen → nobody
QA Contact: marina
Reporter | ||
Updated•21 years ago
|
Assignee: nobody → pkwarren
Reporter | ||
Comment 3•21 years ago
|
||
- Moves the default names in the mailViews.dat file to a properties file.
- If there is not a preexisting mailViews.dat file, that means that we will try
and copy the default one from the system defaults directory. When reading it,
we substitute all names with the ones found in the properties file. After
substituting everything, we write over the mailViews.dat file in the user's
profile so that all of the names are properly translated.
Reporter | ||
Updated•21 years ago
|
Attachment #154569 -
Flags: superreview?(mscott)
Attachment #154569 -
Flags: review?(mscott)
Updated•20 years ago
|
Product: MailNews → Core
Updated•20 years ago
|
Flags: blocking1.8a6?
Comment 4•20 years ago
|
||
Could you name the file mailViewDefaultNames.properties instead of
mailviews-default.properties? I just think it looks more consistant with the
other files.
Comment 5•20 years ago
|
||
Scott, can you review this patch? This would be nice to get in for alpha6 so we
don't have to worry about the l10n freeze deadline at beta.
Comment 6•20 years ago
|
||
not going to hold the release for this but we'd consider taking a fully reviewed
patch if it's available in time.
Flags: blocking1.8a6? → blocking1.8a6-
Updated•20 years ago
|
Blocks: branching1.8
Flags: blocking1.8b4+
Whiteboard: [affects l10n] patch by pkw, needs review (mscott)
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 154569 [details] [diff] [review]
Patch v1
this patch is a good start, but it doesn't work very well for folks who switcch
locals back and forth.
I have a different way of fixing this that will work for existing and new
profiles and will change with locale switches as well.
Attachment #154569 -
Attachment is obsolete: true
Attachment #154569 -
Flags: superreview?(mscott)
Attachment #154569 -
Flags: superreview-
Attachment #154569 -
Flags: review?(mscott)
Attachment #154569 -
Flags: review-
Assignee | ||
Updated•19 years ago
|
Assignee: pkwarren → mscott
Assignee | ||
Comment 8•19 years ago
|
||
add a prettyName attribute to a mail view just like we currently do for mail
folders. Similar to the way we handle mail folders, if the raw name of the mail
view matches one of our default views, then we look up the translated pretty
name and return it as the pretty name.
Now, as locale changes, the names of the default views will change too.
Once you change the name of a default view (just like we currently do with a
folder today) to something else, then all bets are off.
Note: nsMailViewList.cpp was using 4 spaces per tab so I kept doing that.
mailViewSetup.js has two minor changes in my tree from the search criteria
re-write last month.
Attachment #192029 -
Flags: superreview?(bienvenu)
Updated•19 years ago
|
Attachment #192029 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Updated•19 years ago
|
Attachment #192029 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #192029 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•