Closed
Bug 229915
Opened 21 years ago
Closed 17 years ago
[SELECTORS-DYNAMIC] we don't restyle for + combinator and content tree changes
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: css3, testcase)
Attachments
(2 files, 2 obsolete files)
Our handling of content tree changes (removeChild, insertChild, appendChild, replaceChild) doesn't cause the necessary restyling to handle the + combinator in CSS selectors. This is spun off of bug 15608 and is related to bug 73586 and bug 98997. I'll attach a testcase sometime...
Assignee | ||
Comment 1•21 years ago
|
||
Bug 73586, bug 98997, and bug 229915 would be fixed by what I described in step 3 of bug 15608 comment 28: When adding/removing content, just reresolve style on the parent (to handle empty, +, and all the new CSS3 variants). (Perhaps there are good ways to optimize this, but it might just not be that bad.)
Comment 2•21 years ago
|
||
Assignee | ||
Comment 3•21 years ago
|
||
Attachment #139246 -
Attachment is obsolete: true
Assignee | ||
Comment 4•21 years ago
|
||
Attachment #139252 -
Attachment is obsolete: true
Assignee | ||
Comment 5•21 years ago
|
||
It's worth testing ~ as well -- some issues are similar, but some are a bit different.
Updated•21 years ago
|
Assignee | ||
Updated•21 years ago
|
Summary: we don't restyle for + combinator and content tree changes → [SELECTORS-DYNAMIC] we don't restyle for + combinator and content tree changes
Assignee | ||
Comment 6•18 years ago
|
||
*** Bug 343652 has been marked as a duplicate of this bug. ***
No longer blocks: 343652
Comment 7•18 years ago
|
||
*** Bug 344990 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•17 years ago
|
QA Contact: ian → style-system
I just ran into this bug. I have: h1 + p { text-indent: 0 } p { text-indent: 2em } The bug is triggered if I remove a paragraph directly following a header, as the following paragraph that gets moved up is stuck with the old indentation. Is there a simple workaround for this bug?
Comment 9•17 years ago
|
||
Hit upon this in bug 393718 / attachment 295517 [details] [diff] [review].
Comment 10•17 years ago
|
||
Additional testcase
Assignee | ||
Comment 11•17 years ago
|
||
Fix by checkin of bug 401291 to trunk, 2008-02-18 22:17 -0800. I included tests for this bug (based on attachment 139253 [details]) in that landing. However, I think more tests are needed, as none of the tests currently in the tree test any cases where :empty and :-moz-only-whitespace differ, and those cases need to be exercised a good bit.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•