Closed
Bug 371061
Opened 18 years ago
Closed 17 years ago
unit test regressions -- :default pseudoclass
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: sayrer, Assigned: dbaron)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
I was moving the tests for bug 302186 into the new test layout, and four of them have regressed since december or so.
In the attached test case, the last two have always failed and were marked todo(). the four other failures are recent regressions.
Reporter | ||
Updated•18 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 1•18 years ago
|
||
I get a regression range between 2007-02-08 and 2007-02-09:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-08+04&maxdate=2007-02-09+09&cvsroot=%2Fcvsroot
My guess is a regression from bug 348809.
OS: All → Linux
Hardware: All → PC
bz mentioned a while ago that several tests would regress when he landed the patch for bug 348809. I think it's this change:
- document->ContentStatesChanged(oldElement, newElement,
+ document->ContentStatesChanged(newElement, nsnull,
NS_EVENT_STATE_DEFAULT);
We were notifying on an element when we shouldn't have, but because we did we passed those tests. bz will of course know way better than I do!
Comment 3•18 years ago
|
||
Yeah, that's exactly it. See bug 302186 comment 43.
We could put the notification back for now, I suppose, but I'd rather leave the tests as todo() and fix bug 229915 (which will automagically fix these tests, as well as all sorts of other things).
Assignee | ||
Updated•18 years ago
|
Assignee: dbaron → nobody
QA Contact: ian → style-system
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → dbaron
Assignee | ||
Comment 4•17 years ago
|
||
Fixed by checkin of bug 401291, which fixed bug 229915, at 2008-02-18 22:17 -0800.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in
before you can comment on or make changes to this bug.
Description
•