Closed
Bug 234638
Opened 21 years ago
Closed 17 years ago
Graphical emoticon should show a tooltip with the textual emoticon
Categories
(SeaMonkey :: MailNews: Message Display, enhancement)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a1
People
(Reporter: burnus, Assigned: bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
If 'Display emoticons as graphics' is shown, then :-) etc. are converted into
graphics. But sometimes one does want to see the original typeset thing (e.g. if
something is shown as emoticon which is not ment as one).
ChatZilla offers a tooltip showing the original typed text, unfortunally
Mail&News doesn't.
Updated•21 years ago
|
Severity: normal → enhancement
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•20 years ago
|
Assignee: sspitzer → mail
Comment 1•19 years ago
|
||
I'm not quite sure if linking a navigator file inside mailnews is a good idea - otoh I don't know why browser.js is in navigator in the first place:
I'd expected it somewhere along browser.xml in global...
Anyway, when smilies have gotten a title attribute by bug 335344, this will show it as a tooltip.
Comment 2•19 years ago
|
||
Comment on attachment 219774 [details] [diff] [review]
show html tooltips in messagepane, v1
From IRC: FillInHTMLTooltip (and possibly aHTMLTooltip) needs to move (probably to utilityOverlay.js) and the other two message windows also need to be patched.
Attachment #219774 -
Flags: review?(neil) → review+
Summary: Graphical emoticon should show a tooltip with the textial emoticon → Graphical emoticon should show a tooltip with the textual emoticon
Comment 3•18 years ago
|
||
*** Bug 318702 has been marked as a duplicate of this bug. ***
Comment 4•17 years ago
|
||
(In reply to comment #2)
> (From update of attachment 219774 [details] [diff] [review])
> From IRC: FillInHTMLTooltip (and possibly aHTMLTooltip) needs to move (probably
> to utilityOverlay.js) and the other two message windows also need to be
> patched.
Does FillInHTMLTooltip still need to move to utilityOverlay.js?
Comment 5•17 years ago
|
||
The fundamental problem (linking a navigator file inside mailnews) is still there, so this means most probably "yes". But I didn't look into this since then.
(Oh my, I really let that dangle for more than a year? :-( )
Assignee | ||
Comment 6•17 years ago
|
||
This enables the tooltips for emoticons in both messenger.xul and MessageWindow.xul.
FillInHTMLTooltip() is moved from browser.js to a more generic location in contentAreaUtils.js - from where it still can be used by all necessary files.
Assignee: mnyromyr → bugzilla
Attachment #219774 -
Attachment is obsolete: true
Attachment #283928 -
Flags: superreview?(neil)
Attachment #283928 -
Flags: review?(neil)
Comment 7•17 years ago
|
||
Comment on attachment 283928 [details] [diff] [review]
Show emoticon tooltip in message window and messenger.
The idea looks good but when I tried it it broke tooltips entirely in Editor (and note that Editor uses different tooltips anyway).
Attachment #283928 -
Flags: superreview?(neil)
Attachment #283928 -
Flags: review?(neil)
Attachment #283928 -
Flags: review-
Assignee | ||
Comment 8•17 years ago
|
||
Fixed editor issue by renaming the offending function from FillInHTMLTooltip() to FillInHTMLTooltipEditor()
Attachment #283928 -
Attachment is obsolete: true
Attachment #284354 -
Flags: superreview?(neil)
Attachment #284354 -
Flags: review?(neil)
Comment 9•17 years ago
|
||
Comment on attachment 284354 [details] [diff] [review]
same as above + fixed editor.xul issue
>+ <tooltip id="aHTMLTooltip" onpopupshowing="return FillInHTMLTooltipEditor(this);"/>
For bonus points work out how to use "normal" tooltips for Composer's sidebar :-)
Attachment #284354 -
Flags: superreview?(neil)
Attachment #284354 -
Flags: superreview+
Attachment #284354 -
Flags: review?(neil)
Attachment #284354 -
Flags: review+
Comment 10•17 years ago
|
||
Landed on trunk.
Many thanks, Chewey, for cutting this loose end here!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•