User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040323 Firefox/0.8.0+ If you have a lot of bookmarks in a bookmarksmenu-popup, it doesn't fit in the window and you get the autorepeatbutton widgets to scroll up or down in the bookmarksmenu-popup. Drag and drop of bookmarks in the bookmarksmenu-popup is working fine, but I can't use the scroll function of the autorepeatbutton when I'm scrolling. In Internet Explorer I still can. Reproducible: Always Steps to Reproduce: 1.Open a large bookmarksmenu-popup which has the autorepeatbuttons 2.Drag a link over the autorepeatbutton Actual Results: No scrolling up or down of the bookmarksmenu-popup Expected Results: Scrolling up or down of the bookmarksmenu-popup

I think this could be easily fixed, by adding something like this: <xul:autorepeatbutton class="autorepeatbutton-up" collapsed="true" oncommand="this.parentNode.scrollByIndex(-1); event.preventBubble();" ondragover="this.parentNode.scrollByIndex(-1); event.preventBubble();"/> inside: chrome\toolkit\content\global\bindings\scrollbox.xml , line 24 Perhaps this is also a Mozilla bug by the way.

This makes scrolling work when dragging over the autorepeatbutton. I see also a scrollbox.xml in: /cvsroot/mozilla/xpfe/global/resources/content/bindings Should that one also be fixed, I guess?

Probably the xpfe location is for Mozilla, and the toolkit location is for firefox, right?

blake or ben, can you review this patch. This would be a nice cleanup fix to get for 1.0

This is more or less the same bug as bug 194319. I don't really experience the problems mentioned there.

*** Bug 294288 has been marked as a duplicate of this bug. ***

*** Bug 279369 has been marked as a duplicate of this bug. ***

Ok, this makes it work. This patch keeps track of how much time has passed and scrolls only when 20ms have passed. The cursor is flickering between nodrag/pointer cursor while dragging over the autorepeatbutton, which is a bit annoying.

Hmm, probably I should mimick these numbers, not? http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsRepeatService.cpp#52

No, actually, current patch mimicks default behavior better.

No, this patch matches the autorepeatbutton scrolling better.

Will this above patch still work? This bug is two and a half years old, and the bad behavior still exists. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022714 Minefield/3.0b4pre ID:2008022714

ACtually, this is sort of work automatically now that bug 389931 was fixed, I bet. It works for folder popups in the bookmarks toolbar and for subfolders in the bookmarks menu, but not for the bookmarks menu itself. Not really sure why it's not working for the main bookmarks menu.

This will not block the final release of Firefox 3.

The menu doesn't collapse for me. However, it is a somewhat annoying regression from Firefox 2 that scrolling in the bookmarks menu is disabled while dragging something.

(In reply to comment #15) > The menu doesn't collapse for me. However, it is a somewhat annoying regression > from Firefox 2 that scrolling in the bookmarks menu is disabled while dragging > something. actually that should work in latest trunk though

This is wfm in current trunk build. Probably got fixed by bug 389931.