Closed Bug 242672 Opened 21 years ago Closed 17 years ago

Help menu should conform to Apple Human Interface Guidelines

Categories

(Thunderbird :: Mail Window Front End, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird0.7

People

(Reporter: brion, Assigned: mscott)

Details

(Whiteboard: fixed-aviary1.0)

Attachments

(2 files, 2 obsolete files)

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040505 Build Identifier: version 0.6 (20040502) To conform with platform interface standards on Mac OS X, the help menu should be slightly rearranged: The main item, "Mozilla Thunderbird Help" should come first (before "Release Notes") and have Cmd+? as the shortcut key. "About Mozilla Thunderbird" should be removed, as it's already in the standard location in the application menu. Reproducible: Always Steps to Reproduce: 1. Hit Cmd+? 2. Look at help menu Actual Results: Nothing at all happens on Cmd+?; help menu is misordered. Expected Results: Should launch help page on Cmd+?; help menu should be orderly with standard shortcuts and appearance. Apple Human Interface Guidelines: http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGMenus/chapter_15_section_4.html#//apple_ref/doc/uid/TP30000356/TPXREF108
cc'ing some OS X volunteers
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Thunderbird0.8
Target Milestone: Thunderbird0.8 → Thunderbird0.7
Attached patch fix for the main mail window (obsolete) (deleted) — Splinter Review
Jon sent me this patch which fixes this for the main mail window.
this patch has been checked into the branch and the trunk. Leaving open for address book and mail compose window.
Whiteboard: fixed-aviary1.0
Here's a better way to fix this that doesn't involve pre-processing messenger.dtd. Also I had to put back the reference to about thunderbird in the help item otherwise we don't get the help menu item in the application menu anymore.
Attachment #150504 - Attachment is obsolete: true
This patch was created against aviary.
Attached patch modified patch (deleted) — Splinter Review
I tweaked Jon's patch a little bit. Also I didn't check in the OS X core changes as I don't know enough about that portion of the Mac code to know if it's the right thing to do.
Attachment #150579 - Attachment is obsolete: true
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
The Help menu still has the redundant "About Mozilla Thunderbird" as of version 0.7 (20040616).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See bug 215893. I have a new pacth forthcoming that fixes this the right way. I just need to do a debug session to make sure I don't leak anything.
QA Contact: front-end
The issue from comment 8 was fixed in bug 301241. Marking fixed again.
Status: REOPENED → RESOLVED
Closed: 20 years ago17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: