Don pointed this out to me. On OSX we move the preferences menu item and the help / about menu item to a special mac menu. We then hide the preferences menu from the original menu item. But we don't remove the original help / about menu item. Comments from Don: This is a bug for all Mozilla apps, Mozilla, Firebird, and Thunderbird. The global fix ( I believe) is to modify nsMenuBarX::AquifyMenuBar() to add the Help -> About item ( and its separator) to complete the 'aquification' of the menubar for all Mozilla apps. For some reason, this was not done when this method was originally written.

triaging.

Hardware should be set to Macintosh (I don't have permission)

The patch hides the duplicate About item in the Help menu to complete the 'aquification' of the Mac OS X menubar. This will work for all XP apps in the tree.

Would this also fix bug 135258?

Stefan, Yes, the patch in this bug will fix this for all cross platform apps, including Mozilla. Bug 135258 is related but really a duplicate.

Comment on attachment 130703 [details] [diff] [review] Hides the Help -> About menuitem @@ -148,6 +148,7 @@ nsCOMPtr<nsIContent> mQuitItemContent; // as above, but for quit + nsCOMPtr<nsIContent> mAboutItemContent; // and for the about item Indentation is off here

Comment on attachment 130703 [details] [diff] [review] Hides the Help -> About menuitem I don't see where mAboutItemContent ever gets invoked.

timeless, many appologies for the indentation error. New patch cleans it up. Mr. Fraser: All items in the AquifyMenuBar() are unconditionally invoked by the call on line 470-471 if ( !err && (result & gestaltMenuMgrAquaLayoutMask) ) AquifyMenuBar(); The AquifyMenuBar() method can be thought of as a list of items to hide. This patch simply adds the Help/About menuitem and its separator to the list.

Mr. Fraser, Many apologies. I misunderstood your comment. The correct variable to save a reference to is aboutContent. This patch addresses the mistake as well as edits a comment on line 466 to reflect this change.

This id already exists in Thunerbird. Needs to be added to Firebird to avoid another bug being filed for this issue.

I also see "About Plugins" in Mozilla under osx. Does this need to move as well? If not, doesn't it still need the about seperator?

Mr. Francis, Quite right! Initial research shows two items. 1. Apples' AHIG states; "The application menu, new in Mac OS X, contains items that apply to the application as a whole, rather than to a specific document or other window." It seem that 'About Plugins' fits this rather general description. 2. Checking with a copy of Netscape Communicator, with Mac OS 9, reveals that 'About Plugins' was, indeed, placed in the apple menu directly after 'About Netscape'. Given this, I'd say: Let's move 'About Plugins' to the application menu, after the 'About Mozilla' menu item. Then hide 'About Plugins' from the Help menu. This offers some consistancy with older Mac OS software as well as the Apples' guidelines.

*** Bug 135258 has been marked as a duplicate of this bug. ***

Comment on attachment 132462 [details] [diff] [review] Hide the Help -> About menuitem for Mac OS X See my comments in the bug. We need to deal with About Plugins as well.

This patch keeps the seperator and About Plugins (for Mozilla) in the Help menu. I'll look into the About Plugins issue as time permits.

please don't add ifdefs to the widget code, just make sure it tolerates not finding the item you're trying to process.

timeless Thank you. Given this, it seems more appropriate to simply remove the id for the separator in Mozilla. If so, is it OK to add a comment stating replacement of the id when/if About Plugins is moved?

Per timeless comment, we leave SeaMonkeys' separator in place. Give the XUL apps a custom, but logical separator id name for this purpose.

There were ereors in the previous patch

Can the About menus be made into small windows instead of sheets? This is the bahviour for all other OS X apps.

*** Bug 238184 has been marked as a duplicate of this bug. ***

*** Bug 238184 has been marked as a duplicate of this bug. ***

This patch addresses comment 11 for adding the About Plugins to Mac OS X application menu. asking review.

Re comment 20 That should be another bug, for in researching other issues for this bug, I learned that the XUP apps, in general, tends to overuse sheets. Will create bug with links to appropriate info.

Bug 222364 will be my target for the sheets issue in general.

*** Bug 252998 has been marked as a duplicate of this bug. ***

This should be a blocker for 1.0 releases on Mac OS X.

(In reply to comment #23) > asking review. Can you do ask for review? :-)

Comment on attachment 153567 [details] [diff] [review] Hides About and About Plugins (for SeaMonkey) from help and places About Plugins in the App menu moving from now one to javier.

Comment on attachment 153567 [details] [diff] [review] Hides About and About Plugins (for SeaMonkey) from help and places About Plugins in the App menu - CFStringRef labelRef = ::CFStringCreateWithCharacters(kCFAllocatorDefault, (UniChar*)label.get(), label.Length()); - if ( labelRef ) { - ::InsertMenuItemTextWithCFString(sAppleMenu, labelRef, 1, 0, 0); - ::CFRelease(labelRef); + if (aboutMenuItem){ + aboutMenuItem->GetAttribute(NS_LITERAL_STRING("label"), aboutLabel); + CFStringRef labelRef = ::CFStringCreateWithCharacters(kCFAllocatorDefault, (UniChar*)aboutLabel.get(), aboutLabel.Length()); + if ( labelRef ) { + ::InsertMenuItemTextWithCFString(sAppleMenu, labelRef, 1, 0, 0); + ::CFRelease(labelRef); + } + ::SetMenuItemCommandID(sAppleMenu, 1, kHICommandAbout); } Fix the tabbing issues. otherwise, looks good. r=jhpedemonte.

Comment on attachment 153567 [details] [diff] [review] Hides About and About Plugins (for SeaMonkey) from help and places About Plugins in the App menu sfraser?

Comment on attachment 153567 [details] [diff] [review] Hides About and About Plugins (for SeaMonkey) from help and places About Plugins in the App menu moving to neil.

note to self: this is not an issue for Camino.

*** Bug 278594 has been marked as a duplicate of this bug. ***

*** Bug 282092 has been marked as a duplicate of this bug. ***

what's the status of this bug now? First review+ is from october last year.

I have no About Firefox in the help menu, build 20050330

(In reply to comment #37) > I have no About Firefox in the help menu, build 20050330 There's still "About Thunderbird" in the help menu 2005032x

FYI: The patch still applies, except for the /browser part. Seems to work fine on my seamonkey build.

I believe that this is fixed for Firefox.

Yup, all fixed :)

> Yup, all fixed :) No it isn't. Well, it's fixed in Firefox, but the core issue remains. So the issue is still there in SeaMonkey.

Apologies. I could have sworn I checked Seamonkey.

bug 301241 fixed it for T-bird.

Help -> About SeaMonkey looks fixed now. However, Help -> About Plug-ins still exists. Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/2007061506 SeaMonkey/2.0a1pre I'm not sure this is a Widget:Mac bug anymore, however.

I think "About Plug-ins" should be in the Help menu, no? There is a similar menuitem in the Help menu in my old version of Safari. You might want to check with your new version ;-) Otherwise this is fixed "for real" by josh (no xul hack) some time ago.

Yep. I see an "Installed Plug-ins" menu item in my newer (but not quite newest) version of Safari. Josh fixed this. :)

(In reply to comment #47) > Yep. I see an "Installed Plug-ins" menu item in my newer (but not quite newest) > version of Safari. Josh fixed this. :) > jftr: this was fixed in bug 369767.