Closed
Bug 245984
Opened 21 years ago
Closed 20 years ago
Bookmarks context menu (Personal Bar & Bookmarks Manager) lacks mnemonics (access-keys/underlined keyboard shortcuts)
Categories
(Firefox :: Menus, defect, P3)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bugzillamozilla, Assigned: asaf)
References
Details
(Keywords: access, fixed-aviary1.0, polish, Whiteboard: [have patch])
Attachments
(2 files, 4 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
asaf
:
review+
bugs
:
approval-aviary+
|
Details | Diff | Splinter Review |
This is the Firefox equivalent of Bug 214881 (for Seamonkey). Fixing this bug would not only make Firefox more accessible, but it would also minimize the effect of bugs like Bug 172675 (by making it almost as quick to open a folder in new tabs). Prog.
Reporter | ||
Comment 1•21 years ago
|
||
If parity with IE is still sought after, I suggest to follow the same mnemonics (where possible): &Open Cu&t &Copy &Delete P&roperties <- not sure about this one, perhaps &Properties would be better. The rest are not available in IE and should probably follow other Firefox menus. Prog.
Comment 2•21 years ago
|
||
P&roperties is what Windows Explorer uses, but IE uses &Properties. We use &Properties elsewhere, like in a link context menu so we should probably stay with that.
Flags: blocking1.0?
Updated•21 years ago
|
Flags: blocking1.0? → blocking1.0-
Comment 3•20 years ago
|
||
Prog, what about doing up a patch that uses &Properties? We'll at least be consistent throughout the app. Maybe with an actual patch, we can work with Mike to drive it in for 1.0.
Comment 4•20 years ago
|
||
access fixes are always a good thing, I'll buy that for a dollar and &Properties would be my preference.
Keywords: access
Reporter | ||
Comment 5•20 years ago
|
||
Ok, so we're settled on &Properties. There's a slight problem though - it's already defined as "i" and used by the the new Bookmarks Manager: http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd#47 http://lxr.mozilla.org/aviarybranch/source/browser/components/bookmarks/content/bookmarksManager.xul Prog.
Keywords: polish
Comment 6•20 years ago
|
||
Probably done only because Edit > Paste uses 'P' already. Can we have Edit > Properties still use 'i' as an access key and the context menu and toolbar use 'P'? Or would that be too confusing?
Assignee | ||
Comment 8•20 years ago
|
||
As we are not dealing with a xul+dtd file (bookmarks.properties), we need a way to define and get access keys. After landing this patch, we can add lines like the following to bookmarks.propeties: accesskey_bm_properties = i (that's for cmd_bm_properties)
Assignee | ||
Updated•20 years ago
|
Attachment #154491 -
Flags: review?(mconnor)
Assignee | ||
Comment 9•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Assignee: firefox → bugs.mano
Attachment #154491 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #154550 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Attachment #154491 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Flags: blocking-aviary1.0PR?
Assignee | ||
Updated•20 years ago
|
Summary: Bookmarks context menu lacks mnemonics (access-keys/underlined keyboard shortcuts) → Bookmarks context menu (Personal Bar & Bookmarks Manager) lacks mnemonics (access-keys/underlined keyboard shortcuts)
Assignee | ||
Comment 11•20 years ago
|
||
Prog, about what bug have you talked in comment 0? bug 214881 is not the one...
Reporter | ||
Comment 12•20 years ago
|
||
It was supposed to be Bug 176359, not 214881. My clipboard was probably holding that value for the this-bug-blocks field... ;-) It seems that 'P' and 'R' are already taken (for Paste and Rename), but 'i' for Properties is just too narrow. How about 'm' for Rename, 'r' for Properties, and 'g' for Manage Folder? At least all three are inline with Windows Explorer mnemonics (if anyone was wondering, 'g' is used in My Computer context menu for Manage). Prog.
Assignee | ||
Comment 13•20 years ago
|
||
Prog, we use "M" as the mnemonic for "Manage" in the Bookamrks menu (main window).
Comment 14•20 years ago
|
||
cmd_bm_openfolder = Open in Tabs -cmd_bm_openfolder_accesskey = O +cmd_bm_openfolder_accesskey = p How about 'T' for this one? Better to use the first letter of a major word for mnemonics. Or maybe even continue to use "O" here. Not many people use the regular open in a context menu (they just do regular click), so give that the crummy 'p'. In fact, there's a bug filed to have 'Open' removed altogether.
Reporter | ||
Comment 15•20 years ago
|
||
Perhaps I wasn't clear enough. The idea is to use 'g' for Manage, so that 'm' becomes free for Rename, so that 'r' becomes free for Properties. Get it? Prog.
Assignee | ||
Comment 16•20 years ago
|
||
(In reply to comment #14) I agree for "T". ...(As we use this for "Open in new Tab" (obviously, they are not available at the same time...)) (In reply to comment #15) I just said we already use "m" for "Manage" in other places.
Assignee | ||
Comment 17•20 years ago
|
||
:-) We can safely use "r" without cahnging anything... The rename command doesn't appear on the relevant menus.
Assignee | ||
Comment 18•20 years ago
|
||
We can'tm use "T" for "Open in Tabs" and not for "Open in New Tab", that's cu&t...sorry, my mistkae
Assignee | ||
Comment 19•20 years ago
|
||
"P&roperties": but not in Bookmarks Manager ("&Redo"). I restored "&Open in tabs" ("&Open" and "&Open in tabs" items don't appear in the same time).
Assignee | ||
Updated•20 years ago
|
Attachment #154550 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #154550 -
Flags: review?(mconnor)
Assignee | ||
Comment 20•20 years ago
|
||
Comment on attachment 154593 [details] [diff] [review] Some changes ..and I forgot to mention "Open in Ne&w Tab", this is not so good...but morst of us ctrl+click the bookmark. (that's because of cu&t).
Attachment #154593 -
Flags: review?(mconnor)
Comment 21•20 years ago
|
||
l10n impact -> +, please get mconnor's review and land within 7 days otherwise this will be -.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Assignee | ||
Updated•20 years ago
|
Attachment #154593 -
Flags: review?(mconnor) → review?(vladimir)
Assignee | ||
Updated•20 years ago
|
Attachment #154593 -
Attachment is obsolete: true
Attachment #154593 -
Flags: review?(vladimir)
Assignee | ||
Updated•20 years ago
|
Attachment #155335 -
Flags: review?(vladimir)
Comment 23•20 years ago
|
||
mconnor, can you please take a look at this fairly simple patch? Ben says it has to be in by Sunday/Monday or it will be -'d due to l10n freeze.
Comment 24•20 years ago
|
||
Comment on attachment 155335 [details] [diff] [review] Up-to-date patch looks good to me, had to update the patch to current CVS (vlad bitrotted you). Will attach a current patch in a moment
Attachment #155335 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 26•20 years ago
|
||
Comment on attachment 155467 [details] [diff] [review] CVS tip version of patch for aviary, just needs approval-aviary. moving review from mconnor, asking approval
Attachment #155467 -
Flags: review+
Attachment #155467 -
Flags: approval-aviary?
Updated•20 years ago
|
Whiteboard: [have patch]
Comment 28•20 years ago
|
||
Sairuh, or Aaron, can you take a quick look at this change? If there are no obvious problems/conflicts, I'd like to see it land soon.
QA Contact: bugzilla → bugzilla
Comment 29•20 years ago
|
||
the mnemonics in the patch look fine to me, but AaronL would be the best person for a thorough r=.
Comment 30•20 years ago
|
||
Comment on attachment 155467 [details] [diff] [review] CVS tip version of patch for aviary, just needs approval-aviary. a=ben@mozilla.org
Attachment #155467 -
Flags: approval-aviary? → approval-aviary+
Updated•20 years ago
|
Priority: -- → P3
Comment 33•20 years ago
|
||
Done.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 34•20 years ago
|
||
setting fixed-aviary1.0 for bugfixes checked into branch, for searching purposes. sorry for bugspam.
Keywords: fixed-aviary1.0
Comment 35•20 years ago
|
||
in bookmarks toolbar and bookmarks manager context menus, these two accesskeys conflict (redundant S): New _Separator _Sort by Name tested with 2004100609-0.9+ (linux fc2). has another bug been filed on that yet?
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → menus
You need to log in
before you can comment on or make changes to this bug.
Description
•