Closed Bug 249665 Opened 20 years ago Closed 20 years ago

<textarea> does not recognize newlines

Categories

(Core :: DOM: Editor, defect)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: tenthumbs, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(2 files)

My Linux gtk1 trunk build from this morning. Enter text in <textarea> (e.g. bugzilla pages) and "Enter" key is not recognized. Other non-alphabet keys also appear flaky. Taking a wild guess at the component.
I see this too with my self-made Linux Gtk2 debug build compiled with gcc 3.3.4. I saw this first circa three days ago. A clobber build didn't help. This doesn't happen with the official Linux builds from ftp.mozilla.org (I tested build 2004070205). My buildconfig: --enable-calendar --disable-freetype2 --enable-xft --enable-crypto --enable-extensions=wallet,irc,help,inspector,typeaheadfind,xml-rpc,xmlextras,venkman,cookie,content-packs,transformiix,universalchardet,webservices,spellcheck,gnomevfs,negotiateauth,sroaming --enable-svg --enable-svg-renderer-libart --disable-installer --enable-debug --disable-optimize --enable-default-toolkit=gtk2 --enable-chrome-format=symlink Does this a debug-build only bug? -> Editor/Core and upping severity.
Severity: normal → blocker
Component: Editor: Composer → Editor: Core
Works fine for me with Linux and moz cvs 2004070221
I see it with two builds, their configs are slightly different but they both have --disable-tests --enable-xterm-updates --enable-crypto --enable-debug
My config args from about:buildconfig Configure arguments --with-gtk --disable-nls --disable-static --disable-tests --disable-logging --enable-optimize=-O2 --enable-ldap-experimental --enable-crypto --enable-mathml --with-extensions --with-pthreads --enable-reorder --with-libIDL-prefix=/usr/local --with-system-zlib=/usr/local --with-system-png=/usr/local --with-system-jpeg=/usr/local --with-system-mng=/usr/local --enable-extensions --enable-xft --enable-xprint --enable-calendar --enable-default-toolkit=gtk2 --disable-debug --enable-strip --enable-strip-libs So maybe debug and/or xterm-updates to blame ?
Definitely debug only. Rebuilding with --disable-debug works. Reducing severity. I wish people wouldn't screw with this stuff. Ok, typing the above in my fresh non-debug build did work but backspacing sometimes didn't. There's something goofy here.
Severity: blocker → major
(In reply to comment #6) > Definitely debug only. Rebuilding with --disable-debug works. Reducing severity. > I wish people wouldn't screw with this stuff. The definition for severity blocker is "Blocks development and/or testing work". As many (most?) developers work with debug builds and Editor (<textarea>s, MailNews Compose, Composer) is nearly unusable with this bug, I think the previous severity was correct. At least it blocks some of the development and testing work I want to do (I noticed this bug first when I wanted to reproduce a bug in the Compose window which wasn't possible). But whatever... this discussion doesn't help to fix this bug.
*** Bug 249743 has been marked as a duplicate of this bug. ***
*** Bug 249287 has been marked as a duplicate of this bug. ***
Danm saw this bug in a debug-build from 20040628 already on Windows XP. See dupe: bug 249287. Changing OS to All.
OS: Linux → All
OK, so I've narrowed it down. make -s -f client.mk MOZ_CO_DATE=2004-06-25 build works. make -s -f client.mk MOZ_CO_DATE=2004-06-26 does not. Also I should have said that I see it in my mingw debug build too.
OS: All → Linux
Attached patch Fix (deleted) — Splinter Review
This #ifdef DEBUG code was not calling the correct superclass method.
Assignee: composer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #152289 - Flags: superreview?(peterv)
Attachment #152289 - Flags: review?(peterv)
Keywords: regression
Summary: <textarea> does not recogize newlines → <textarea> does not recognize newlines
Comment on attachment 152289 [details] [diff] [review] Fix Thanks for catching this.
Attachment #152289 - Flags: superreview?(peterv)
Attachment #152289 - Flags: superreview+
Attachment #152289 - Flags: review?(peterv)
Attachment #152289 - Flags: review+
*** Bug 249416 has been marked as a duplicate of this bug. ***
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: