User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040702 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040702 When composing an email, you can not insert the smiley face at the end of a sentence using the drop down faces. However; if you type the familar colon, hyphen and closed parenthesis the smiley face will appear in the received email. Reproducible: Always Steps to Reproduce: 1.Compose new email 2.Insert a smiley face from the drop down list at the end of the sentence. 3.

Who is the receiver of the mail in this case? Yourself? (Asking because themes now have to support emoticons in order to see them. The two default themes supports this.)

(In reply to comment #1) > Who is the receiver of the mail in this case? Yourself? > (Asking because themes now have to support emoticons in order to see them. > The two default themes supports this.) Yes, I was the recipient of the test email. When I used the drop down list, nothing happened...It did not appear in the compose, and it did not appear in the received. When I used the colon, hyphen and closed parenthesis, it appeared in the received email. I was using the classic theme at the time. I have not tried this with the modern theme.

Uhh.. I can't insert emoticons here either! Linux, 20040630

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsICommandParams.getCStringValue]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://editor/content/ComposerCommands.js :: anonymous :: line 3050" data: no] Source File: chrome://editor/content/ComposerCommands.js Line: 3050

This was caused by a checking for bug 206716 on 2004-06-14 09:35 Backing out this make smilies insert again: cvs update -j1.197 -j1.196 mozilla/editor/ui/composer/content/ComposerCommands.js Adding Michael Kaply to CC

checking checkin one two three...

Very strange. I'll talk to glazou

*** Bug 249795 has been marked as a duplicate of this bug. ***

Why is this in Product=Browser Component=Editor:Composer instead of Product=MailNews Component=Compose ?

Olivier Vit: because bug 206716 was filed as browser/composer, and the fix caused this bug

*** Bug 250526 has been marked as a duplicate of this bug. ***

*** Bug 255785 has been marked as a duplicate of this bug. ***

mkaply--the following patch should fix this (sorry I can't attach it or test it; my tree isn't clean or updated): Index: ComposerCommands.js =================================================================== RCS file: /cvsroot/mozilla/editor/ui/composer/content/ComposerCommands.js,v retrieving revision 1.197 diff -U8 -r1.197 ComposerCommands.js --- ComposerCommands.js 14 Jun 2004 16:35:58 -0000 1.197 +++ ComposerCommands.js 16 Aug 2004 20:03:34 -0000 @@ -3042,17 +3049,17 @@ isCommandEnabled: function(aCommand, dummy) { return (IsDocumentEditable() && IsEditingRenderedHTML()); }, getCommandStateParams: function(aCommand, aParams, aRefCon) {}, doCommandParams: function(aCommand, aParams, aRefCon) { - var smileyCode = aParams.getCStringValue("state_attribute"); + var smileyCode = aParams.getStringValue("state_attribute"); var strSml; switch(smileyCode) { case ":-)": strSml="s1"; break; case ":-(": strSml="s2"; break;

brade is correct - r=mkaply, a=mkaply - I'm going to check this in.

Fix checked in. The original "fix" never went anywhere but the trunk

Verified FIXED using build 2004-08-23-08 on Windows XP Seamonkey trunk.