Closed
Bug 249903
Opened 20 years ago
Closed 20 years ago
nsGNOMERegistry::HandlerExists uses gconf client after g_object_unref()ing it
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chpe, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier:
nsGNOMERegistry::HandlerExists uses the default GConf client after unreffing it.
Reproducible: Always
Steps to Reproduce:
|
Reporter | |
Comment 1•20 years ago
|
||
Defer unreffing the GConf client until after we're done with it.
|
|
Reporter | |
Updated•20 years ago
|
Attachment #152359 -
Flags: superreview?(bzbarsky)
Attachment #152359 -
Flags: review?(bryner)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 152359 [details] [diff] [review]
proposed fix
I'd prefer if you just move isEnabled outside of the |if (app)|, initializing
it to false, then have a single unref and return at the end of the function.
r=bryner with that change.
Attachment #152359 -
Flags: review?(bryner) → review+
|
|
Reporter | |
Comment 4•20 years ago
|
||
Attachment #152359 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•20 years ago
|
Attachment #152359 -
Flags: superreview?(bzbarsky)
|
|
Reporter | |
Comment 5•20 years ago
|
||
Comment on attachment 152362 [details] [diff] [review]
updated patch as requested by the reviewer
Carrying forward bryner's r+, and asking for sr
Attachment #152362 -
Flags: superreview?(bzbarsky)
Attachment #152362 -
Flags: review+
|
||
Comment 6•20 years ago
|
||
Comment on attachment 152362 [details] [diff] [review]
updated patch as requested by the reviewer
>Index: nsGNOMERegistry.cpp
>+ return isEnabled ? PR_TRUE : PR_FALSE;
return isEnabled != FALSE;
sr=darin with that change.
Attachment #152362 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Reporter | |
Comment 7•20 years ago
|
||
Attachment #152362 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 8•20 years ago
|
||
This is fixed in trunk by the checkin from bug 258802.
|
||
Comment 9•20 years ago
|
||
marking so
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•