Closed Bug 258802 Opened 20 years ago Closed 20 years ago

nsExternalProtocolService: need default app for scheme

Categories

(Core :: Networking, enhancement)

Product:
Core
Component:
Networking
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha5

People

(Reporter: dveditz, Assigned: Biesinger)

References

Details

Attachments

(3 files, 3 obsolete files)

patch v0.1
(deleted), patch
emaijala+moz
: review+
neil
: superreview+
Details | Diff | Splinter Review
unix patch, v3
(deleted), patch
bzbarsky
: review+
bryner
: superreview+
Details | Diff | Splinter Review
final patch
(deleted), patch
Details | Diff | Splinter Review
We support external protocols by handing them off to the OS, but there is no current way to know what application will be handling them. Would be nice if we could let the user know (as we do with helper apps) when prompting whether it's OK to load an externally handled link. Would need a new method on nsIExternalProtocolService, not just isExposedProtocol, but the actual app. All platform implementations of nsOSHelperAppService would need to be updated.
biesi: you interested in taking this?
Summary: nsIExternalProtocolService: need default app scheme → nsExternalProtocolService: need default app for scheme
sure, why not :)
Assignee: darin → cbiesinger
Target Milestone: --- → mozilla1.8beta
Attached patch patch v0 (obsolete) (deleted) — — Splinter Review
something along this lines probably. This patch shows the complete shell\command\@ string, i.e. path to the application + arguments, which is probably not optimal.
Attached patch patch v0.1 (deleted) — — Splinter Review
show <Unknown> as application desc if we can't find a real one
Attachment #158866 - Attachment is obsolete: true
bug 252189 adds a way to get a nice human-readable description from the shell\command filename
Depends on: 252189
biesi: the patch looks pretty good to me. is there anything we can do on OSX or GNOME?
Comment on attachment 158867 [details] [diff] [review] patch v0.1 I have no idea about OSX stuff. For Gnome, and /etc/mailcap (also on OS/2), we could probably use the filename, like this patch does for windows. ok, let's get this patch in while waiting for bug 252189 to get fixed. the path+filename is good enough for now.
Attachment #158867 - Flags: review?(emaijala)
Attached patch unix patch (obsolete) (deleted) — — Splinter Review
to be applied in addition to the above patch
Attachment #158883 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Target Milestone: mozilla1.8beta → mozilla1.8alpha4
Comment on attachment 158883 [details] [diff] [review] unix patch oops, this breaks gtk1 builds
Attachment #158883 - Attachment is obsolete: true
Attachment #158883 - Flags: review?(bzbarsky) → review-
Attached patch unix patch v2 (obsolete) (deleted) — — Splinter Review
Attachment #158892 - Flags: review?(bzbarsky)
Comment on attachment 158892 [details] [diff] [review] unix patch v2 So... can't we factor out the code you're copying from HandlerExists?
Comment on attachment 158892 [details] [diff] [review] unix patch v2 yeah, I shouldn't be so lazy ;)
Attachment #158892 - Attachment is obsolete: true
Attachment #158892 - Flags: review?(bzbarsky) → review-
Attached patch unix patch, v3 (deleted) — — Splinter Review
factored out. also makes this code use a non-released GConfClient to check the enabled-state of the app.
Attachment #159089 - Flags: review?(bzbarsky)
Comment on attachment 159089 [details] [diff] [review] unix patch, v3 r=bzbarsky. Nice catch on the client thing!
Attachment #159089 - Flags: superreview?(bryner)
Attachment #159089 - Flags: review?(bzbarsky)
Attachment #159089 - Flags: review+
Attachment #159089 - Flags: superreview?(bryner) → superreview+
Comment on attachment 158867 [details] [diff] [review] patch v0.1 The patch looks ok to me.
Attachment #158867 - Flags: review?(emaijala) → review+
Attachment #158867 - Flags: superreview?(bzbarsky)
Comment on attachment 158867 [details] [diff] [review] patch v0.1 sr=bzbarsky, but have a UI owner check out the localized string changes?
Attachment #158867 - Flags: superreview?(bzbarsky) → superreview+
Attachment #158867 - Flags: superreview+ → superreview?(neil.parkwaycc.co.uk)
Target Milestone: mozilla1.8alpha4 → mozilla1.8alpha5
Comment on attachment 158867 [details] [diff] [review] patch v0.1 Nit: as discussed on IRC it seems to me you can simplify the description code by declaring desc as an nsXPIDLString.
Attachment #158867 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
checked in. bug 264647, bug 264648, and bug 264649 filed for implementations for other platforms. marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: