The Close button on the Find Toolbar is too far to the right of the Firefox window. While consistency with the Tab Bar is desirable, its placement on the Find Toolbar can be inconvenient for mouse-savvy users maximizing the Firefox window on a high-resolution screen, as they have to reach all the way to the right of the screen to click it. Obviously, placing the Close button on the far right of the Tab Bar has a specific objective: to allow maximum room for all the other tabs that may be opened and displayed. This is not the case with the Find Toolbar, where there is only a short label, a text field, and three buttons. Ideally, there should be a close button (and it actually reads "Close", it's not just an "X") to the right of the last "Highlight" button, possibly after a toolbar separator. This is very much like that found in the toolbar in the Print Preview screen.

-> Find Toolbar component.

Notice that the Close button is a <button> and not a <toolbarbutton>. This makes it stand out from the other toolbar buttons (Find Prev, Find Next, Highlight), and its appearance is consistent with (and reminscient of) the Close button in the Print Preview toolbar.

After further testing of the above patch on my Firefox build, I've noticed that when invoking the Close button using the accesskey (ALT+C), *all* keyboard shortcuts no longer work; e.g. ALT or F10 to activate menu bar, CTRL+F or / to redisplay Find Bar, F11 to toggle full screen... even the arrow keys for scrolling are disabled. Keyboard shortcut functionality is restored after clicking anywhere in the Firefox window. This patch is the same as the first - except that the <button> doesn't have an accesskey attribute. The ESC key can still be used to close the Find Bar, but I'd much prefer that this strange problem be fixed... I've read a complaint from someone that the ESC key is too far away on the keyboard for him!

(In reply to comment #3) > After further testing of the above patch on my Firefox build, I've noticed that ^^^^^^^^^^^ Clarification: "above patch" refers to the original patch I attached to comment #2, and not to the new patch I attached to comment #3.

This close "x" button is also too small. There is a bug for this problem with the "close tab" button as well. If you are going to fix this, they should be done together.

The above patch (the attachment to comment #3) hasn't been applied yet, as it is pending review. So the little "X" button on the far right of the Find Toolbar will still be present in the meantime. As for the Tab Bar's Close button, I think it's a problem with the default Firefox theme than with the button itself (try it with the Qute theme).

Minor changes to accomodate new user feedback UI

For UI changes, it's good form to attach a screenshot of the area you're adjusting because in addition to a code review, there will also be a UI review to see if the new look is actually desirable.

> Screenshot of Find Toolbar with new Close button 1. It's not the same style as all other buttons on the toolbar. 2. It doesn't have an icon. 3. It's not vertically aligned with the other buttons on the toolbar. 4. I don't think this will be nearly as large an issue as the actual bugs in the Find Toolbar get fixed, such as recently-fixed bug 250942. 5. I like the current button. It's consistent with the close button on the tab bar, as well as the only other toolbar I can think of that has a close button, the Find toolbar in Microsoft Outlook. I think we should instead spend time properly theming the close buttons so they match with whatever the window manager uses as a close button.

(In reply to comment #10) > > 1. It's not the same style as all other buttons on the toolbar. The rationale being that it's supposed to stand out from the other buttons. After all, we don't want the user to accidentally click the Close button when he really wanted to click Highlight. > 2. It doesn't have an icon. Whether it really needs an icon is debatable. Waiting for further feedback from others on this. Also see response to point #5. > 3. It's not vertically aligned with the other buttons on the toolbar. I've noticed this after the new user feedback UI was added. I'll look into this. > 4. I don't think this will be nearly as large an issue as the actual bugs in > the Find Toolbar get fixed, such as recently-fixed bug 250942. Agreed, but from a usability standpoint, I see it as an improvement. As stated earlier, mouse-savvy users browsing in a maximized Firefox window on a high-resolution monitor may find that reaching all the way to the right to hit the Close button is inconvenient. > 5. I like the current button. It's consistent with the close button on the > tab bar, as well as the only other toolbar I can think of that has a close The simple design of the Close button was inspired by that found in the comments and footnotes panes in Microsoft Word. It's the last item in the toolbar (and there aren't that many items in the toolbars for those two panes), so it's adjacent to the other primary toolbar buttons, yet is easy to reach.

I like the fact that the button is larger. It is also very clear what the purpose of the button is. I think it should be all the way to the right, though. Good job!

(In reply to comment #11) > (In reply to comment #10) ... > > 5. I like the current button. It's consistent with the close button on the > > tab bar, as well as the only other toolbar I can think of that has a close > > The simple design of the Close button was inspired by that found in the comments > and footnotes panes in Microsoft Word. It's the last item in the toolbar (and > there aren't that many items in the toolbars for those two panes), so it's > adjacent to the other primary toolbar buttons, yet is easy to reach. I think both buttons (they are the same button) need work. They are both too small to click on. Maybe this should go into a new bug for the theme or something.

I agree with Dean Tessmen, adding the button like the screenshot is not an improvement, more of the opposite.

Fixed Close button's vertical alignment with respect to the other Find Toolbar's buttons.

Nic. Now just slide it all the way to the right.

-> me

Fixed. Moved to left side.

It now looks inconsistent compared to the tab bar, the missing plug-in notification, and the blocked popup notification.

(In reply to comment #20) > It now looks inconsistent compared to the tab bar, the missing plug-in > notification, and the blocked popup notification. I agree. It looks horrible in its new location.

I wondered why it had been moved, thought it might be a mistake. I guess it does make the close button closer but IMHO it does look inconsistent, and takes some getting used to. I'm not sure if moving it next to Match Case improves matters though (see attachment). I think it should probably be put back to the right-hand side - users worried about mouse miles can always hit escape.

(In reply to comment #22) > I think it should probably be put back to the right-hand side - users worried > about mouse miles can always hit escape. I now travel more "mouse miles" to get from the Close Tab button to the Close Find button than I did before. That's a lot of spins on my trackball.

I have created bug 265854 about this. I think it should be put to the right of Match Case as the original reporter of this bug intended. Also, in Windows, AFAIK all close buttons are on the right of the window/screen so this is very inconsistent, at least on that platform.

This is still a problem in the latest trunk.