Subsequent to the checkin for bug 78274 we can now specify dialog labels using attributes rather than having to set them in load handlers. I have generally listed listed the .js file with the script, but obviously there will be modifications to .xul .dtd and .properties files to consider. The patches should be split into modules so that each owner can review or approve them separately. editor/ui/dialogs/content/EdInsSrc editor/ui/dialogs/content/EdInsertChars editor/ui/dialogs/content/EdLinkChecker editor/ui/dialogs/content/EdTableProps editor/ui/dialogs/content/EditorPublish editor/ui/dialogs/content/EditorPublishProgress extensions/cookie/resources/content/p3pDialog extensions/sroaming/resources/content/transfer/progressDialog extensions/wallet/cookieviewer/resources/content/CookieViewer extensions/wallet/signonviewer/resources/content/SignonViewer security/manager/pki/resources/content/crlImportDialog xpinstall/res/content/institems xpfe/communicator/resources/content/openLocation xpfe/components/bookmarks/resources/findBookmark xpfe/components/find/resources/finddialog xpfe/components/history/resources/findHistory xpfe/global/resources/content/printdialog mailnews/compose/resources/content/askSendFormat mailnews/news/resources/content/downloadheaders

Taking. Not sure when, but I can do this.

This patch also adds the missing id to the printDialog and removes the access key from the Find-Button of findDialog, because according to http://www.mozilla.org/access/keyboard/accesskey "OK buttons" shouldn't have an accesskey.

There is nothing to do in editor/ui/dialogs/content/EditorPublishProgress, because all what happens in the JS file of the dialog is that the "Cancel" button is changed to "Close" after the publishing was finished. This can't be handled with buttonlabelcancel. I left the accesskey for the "Insert" button of editor/ui/dialogs/content/EdInsSrc intact, because this dialog accept button is not the default button in this case.

Comment on attachment 167221 [details] [diff] [review] Patch for editor/ (In reply to comment #3) >This can't be handled with buttonlabelcancel. Actually it can, see profileSelection.js for the example.

Thanks for the hint, Neil. :-) Here is a new patch that also changes the EditorPublishProgress dialog.

Comment on attachment 167288 [details] [diff] [review] Patch V1.1 for editor/ The other files are unchanged compared to the last patch. There is one exception: The string "Close" is now also removed from editor.properties, because there is no user of it left now.

Comment on attachment 167288 [details] [diff] [review] Patch V1.1 for editor/ What about EdTableProps.js?

Adds the change in the EdTableProps dialog I overlooked in Patch V1.1. Thanks again, Neil!

Comment on attachment 167311 [details] [diff] [review] Patch V1.2 for editor/ (checked in) YUM YUM!!!! Thanks Stefan, check it in ASAP!

Why was this landed on the Aviary branch without approval? Was this OK'd by the Tbird devs or the aviary team in general?

Oops, sorry, bad bonsai query. ignore my comment.

The MsgAttachPage dialog can also be converted to the new attributes. While changing the askSendFormat dialog I also removed the last traces of the Receipients... and Help buttons because of the decision made in bug 38738.

Comment on attachment 167373 [details] [diff] [review] Patch for mailnews/ r=me except for the removal of help-related code; we do nominally have help for this dialog, search help for Question.

Updated according to Neil's review comments (restored the help stuff, I also filed bug 277679 for adding a Help button to this dialog).

Comment on attachment 167592 [details] [diff] [review] Patch V1.1 for mailnews/ Transferring Neil's r+ and asking Scott for sr again.

I noticed some dialogs which rather than setting the button labels in load handlers actually duplicate the button layout using an extra hbox: /extensions/wallet/walletpreview/resources/content/WalletPreview.xul /xpfe/communicator/resources/content/aboutPopups.xul /xpfe/components/sidebar/resources/customize.xul /xpfe/global/resources/content/fontpackage.xul Oh, and I hope you haven't forgotton about /extensions/cookie/resources/content/p3pDialog.xul

Note that this change will break some of the dialogs mentioned in my previous comment but they all needed fixing anyway.

As per comment 16 and a few extra tidy ups

Comment on attachment 170040 [details] [diff] [review] Fixes for naughty dialogs v0.1 >+ buttons="extra2,accept,cancel,help" Please use the same order that the p3pDialog uses. >+ ondialogextra2="formShow();" An accesskey for this button would be nice. > <separator/> You've got a couple of these that can go too. >+ var sizeString = fontPackageBundle.getString("size_" + gLangCode); >+ document.getElementById("sizeSpecification").value = sizeString; > } > > // argument is a lang code of the form xx or xx-yy > gLangCode = window.arguments[0]; Unfortunately you already tried to use it earlier :-( If you have win2k/xp you can fake the 9x language dialog by overriding the user agent.

Addressing reviewer's comments.

Comment on attachment 170057 [details] [diff] [review] Fixes for naughty dialogs and tidy up v0.1a Nit: put extra2 at the end in customize.xul too please.

Fixed nit, carried forward r+ and requesting sr

Comment on attachment 170155 [details] [diff] [review] Tidy up and fixes for dialogs in xpfe/extensions v0.1b (Checked in) sr=dveditz

Comment on attachment 170155 [details] [diff] [review] Tidy up and fixes for dialogs in xpfe/extensions v0.1b (Checked in) Checking in extensions/wallet/walletpreview/resources/content/WalletPreview.xul; /cvsroot/mozilla/extensions/wallet/walletpreview/resources/content/WalletPrevie w.xul,v <-- WalletPreview.xul new revision: 1.8; previous revision: 1.7 done Checking in extensions/wallet/walletpreview/resources/locale/en-US/WalletPreview.dtd; /cvsroot/mozilla/extensions/wallet/walletpreview/resources/locale/en-US/WalletP review.dtd,v <-- WalletPreview.dtd new revision: 1.3; previous revision: 1.2 done Checking in xpfe/communicator/resources/content/aboutPopups.xul; /cvsroot/mozilla/xpfe/communicator/resources/content/aboutPopups.xul,v <-- aboutPopups.xul new revision: 1.5; previous revision: 1.4 done Checking in xpfe/components/sidebar/resources/customize.xul; /cvsroot/mozilla/xpfe/components/sidebar/resources/customize.xul,v <-- customize.xul new revision: 1.55; previous revision: 1.54 done Checking in xpfe/global/resources/content/fontpackage.xul; /cvsroot/mozilla/xpfe/global/resources/content/fontpackage.xul,v <-- fontpackage.xul new revision: 1.3; previous revision: 1.2 done Checking in xpfe/global/resources/content/fontpackage.js; /cvsroot/mozilla/xpfe/global/resources/content/fontpackage.js,v <-- fontpackage.js new revision: 1.4; previous revision: 1.3 done Checking in extensions/cookie/resources/content/p3pDialog.xul; /cvsroot/mozilla/extensions/cookie/resources/content/p3pDialog.xul,v <-- p3pDialog.xul new revision: 1.7; previous revision: 1.6 done

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050220 Firefox/1.0+ Starting with todays build any upload button on e.g Gmail is flattened. This is also visable when you try to upload a file to bugzilla Did this checkin cause this regression ?

Comment on attachment 175037 [details] screenshot My mistake, found a build pre this checkin and the problem is still there. Sorry for the spam

Comment on attachment 167592 [details] [diff] [review] Patch V1.1 for mailnews/ Stefan, is this old patch still valid and in need of a n sr? reset if so and I'll look again.

Comment on attachment 169930 [details] [diff] [review] Thoughts anyone? fine w/ me