Closed
Bug 260335
Opened 20 years ago
Closed 20 years ago
"Colors" are not lockable in Preferences->Appearance->Colors page (color/colour picker)
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eagle.lu, Assigned: neil)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
janv
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
All color picker items on this page is not lockable.
Comment on attachment 159388 [details] [diff] [review]
patch v0
Can you give r? thanks
Attachment #159388 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Updated•20 years ago
|
Summary: "Colors" are not lockabe in Perferences->Apparance->Colors page → "Colors" are not lockable in Perferences->Appearance->Colors page
|
|
||
Updated•20 years ago
|
Summary: "Colors" are not lockable in Perferences->Appearance->Colors page → "Colors" are not lockable in Preferences->Appearance->Colors page
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 159388 [details] [diff] [review]
patch v0
As an alternative I'm looking into getting rid of these colorpicker hacks.
Attachment #159388 -
Flags: review?(neil.parkwaycc.co.uk) → review-
|
|
Assignee | |
Comment 4•20 years ago
|
||
This improves on the disabled support for colorpicker and teaches the wsm about
the colorpicker so that it saves the state and locks it correctly.
|
|
Assignee | |
Updated•20 years ago
|
Assignee: prefs → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
|
||
Updated•20 years ago
|
Attachment #159592 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #159592 -
Flags: superreview?(jag)
|
||
Comment 5•20 years ago
|
||
Comment on attachment 159592 [details] [diff] [review]
Proposed patch
Index: components/prefwindow/resources/content/nsPrefWindow.js
It seems like the "elt -> prefattribute" and "elt -> preftype" switches should
be factored out into helper functions.
What happened to indentation there?
+ <property name="disabled" onset="if (val)
this.setAttribute('disabled',true);
+ else
this.removeAttribute('disabled');
+ return val;"
+ onget="return
this.hasAttribute('disabled');"/>
+
I'm assuming you'll remove the pref-colors.js file when you check in.
sr=jag if you at least fix those indent nits, karma points for factoring the
duplicate code out into functions.
Attachment #159592 -
Flags: superreview?(jag) → superreview+
|
|
Assignee | |
Comment 6•20 years ago
|
||
Indents fixed and checked in, pref-colors.js removed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Summary: "Colors" are not lockable in Preferences->Appearance->Colors page → "Colors" are not lockable in Preferences->Appearance->Colors page (color/colour picker)
|
|
||
Updated•20 years ago
|
Attachment #159388 -
Attachment is obsolete: true
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
|
|
||
Comment 8•20 years ago
|
||
|
|
||
Updated•20 years ago
|
Attachment #167932 -
Flags: review?(mconnor)
|
||
Comment 9•20 years ago
|
||
Comment on attachment 167932 [details] [diff] [review]
toolkit port: support disabling colorpicker buttons (checked in)
ok, but please file a followup bug to port the rest if you're not doing this
soon.
Attachment #167932 -
Flags: review?(mconnor) → review+
|
|
||
Comment 10•20 years ago
|
||
Comment on attachment 167932 [details] [diff] [review]
toolkit port: support disabling colorpicker buttons (checked in)
ok. this patch is checked in; porting wsm and prefwindow changes is bug 273287
Attachment #167932 -
Attachment description: toolkit port: support disabling colorpicker buttons → toolkit port: support disabling colorpicker buttons (checked in)
|
||
Comment 11•20 years ago
|
||
*** Bug 199789 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•