Color picker in general prefs area is not lockable. All preferences in general preference area, and mail/news account settings must be locked for eClient initiative. eddyk aware of this issue. Color picker was lockable in 4.x client.

QA over to me...adding sarah to Cc.

Adding pref locking newsgroup posting news://news.mozilla.org/3AC8F5D2.6CA02623%40netscape.com

marking nsenterprise-.

patch adds disabled property to colorpicker, changes color panel to use new property and adds some code to the widgetmanager to set the disabled attribute. Also fixes one line in widgetstate manager which was using getAttribute improperly (two params instead of one). the disabled properly for this widget only prevents the popup from occuring (by mouse or keyboard). It doesn't change the color to the disabled color since that may be more confusing than a widget that doesn't respond.

The disabled setter is now similar to the one in general.xml for the basetext widget. The getter is simplified as suggested by Neil. The disabled check in the openpopup method is simplified. The data widget gets its disabled property set by nsPrefWindow/WSM. The colorpicker doesn't directly get the disabled property set, so it's done in the .js for the panel.

Comment on attachment 56020 [details] [diff] [review] new patch based on comments from neil r=cmanske

<eddyk@netscape.com> email is bouncing. Is this person still involved with Mozilla? Do these bugs need to be reassigned?

brian, any idea who should be getting locked prefs bugs these days?

*** Bug 114526 has been marked as a duplicate of this bug. ***

The current patch has, unfortunately, bit rotted or I would check it in. Front-End (i.e. UI) prefs issues go to samir.

Scheduled for mozilla1.0 (i.e., the next milestone after mozilla0.9.9).

*** Bug 79603 has been marked as a duplicate of this bug. ***

how badly, do enterprise customers , really need the color picker to be locked?

nsbeta1- per Nav triage team, ->1.2

removed jhooker from cc: list

now fixed in bug 260335, with an apparently independently created patch... marking as dup. *** This bug has been marked as a duplicate of 260335 ***