We support 'pre-wrap' now. All in-tree users of -moz-pre-wrap should be converted to use pre-wrap instead. Then at some point we should just remove -moz-pre-wrap support completely.

Simply replacing |-moz-pre-wrap| with |pre-wrap|. # excepted MochiKit

Comment on attachment 305682 [details] [diff] [review] Patch roc, could you review this patch? # I wonder whether the patch should be separated into each component.

I won't have time to look at this for a few days. I'm not sure whether we should take it for FF3, but I guess we probably should in case people copy in-tree styles to extensions or something. We want to phase out use of -moz-pre-wrap.

Comment on attachment 305682 [details] [diff] [review] Patch This is good. I think we should take it. The reward is low but the risk is incredibly low and it would be good to get people using pre-wrap instead of the old deprecated name.

Comment on attachment 305682 [details] [diff] [review] Patch a1.9=beltzner

Checkin Bug 414481. delete -moz-pre-wrap in eula.css

Also, bug 414183 got checked in which removed some cases of -moz-pre-wrap.

Updated patch for current trunk Thanks Kuden-san and Andrew :-)

How does this patch differ from the last one? Does it really require going through review and approval again?

Comment on attachment 307937 [details] [diff] [review] Updated patch Please re-request approval once reviews are completed.

Comment on attachment 307937 [details] [diff] [review] Updated patch (In reply to comment #9) > How does this patch differ from the last one? Does it really require going > through review and approval again? > There are no practical changes. Since some css files removed "-moz-pre-wrap", this patch doesn't include such files.

Comment on attachment 307937 [details] [diff] [review] Updated patch rubber-stamp=me

Comment on attachment 307937 [details] [diff] [review] Updated patch I'm just going to carry over approval.

Checking in browser/themes/gnomestripe/browser/pageInfo.css; /cvsroot/mozilla/browser/themes/gnomestripe/browser/pageInfo.css,v <-- pageInfo.css new revision: 1.15; previous revision: 1.14 done Checking in browser/themes/pinstripe/browser/pageInfo.css; /cvsroot/mozilla/browser/themes/pinstripe/browser/pageInfo.css,v <-- pageInfo.css new revision: 1.14; previous revision: 1.13 done Checking in browser/themes/winstripe/browser/pageInfo.css; /cvsroot/mozilla/browser/themes/winstripe/browser/pageInfo.css,v <-- pageInfo.css new revision: 1.12; previous revision: 1.11 done Checking in calendar/lightning/themes/pinstripe/imip.css; /cvsroot/mozilla/calendar/lightning/themes/pinstripe/imip.css,v <-- imip.css new revision: 1.4; previous revision: 1.3 done Checking in calendar/lightning/themes/pinstripe/lightning.css; /cvsroot/mozilla/calendar/lightning/themes/pinstripe/lightning.css,v <-- lightning.css new revision: 1.25; previous revision: 1.24 done Checking in calendar/lightning/themes/winstripe/imip.css; /cvsroot/mozilla/calendar/lightning/themes/winstripe/imip.css,v <-- imip.css new revision: 1.3; previous revision: 1.2 done Checking in calendar/lightning/themes/winstripe/lightning.css; /cvsroot/mozilla/calendar/lightning/themes/winstripe/lightning.css,v <-- lightning.css new revision: 1.23; previous revision: 1.22 done Checking in calendar/sunbird/themes/pinstripe/sunbird/calendar.css; /cvsroot/mozilla/calendar/sunbird/themes/pinstripe/sunbird/calendar.css,v <-- calendar.css new revision: 1.27; previous revision: 1.26 done Checking in calendar/sunbird/themes/winstripe/sunbird/calendar.css; /cvsroot/mozilla/calendar/sunbird/themes/winstripe/sunbird/calendar.css,v <-- calendar.css new revision: 1.46; previous revision: 1.45 done Checking in content/base/src/nsPlainTextSerializer.cpp; /cvsroot/mozilla/content/base/src/nsPlainTextSerializer.cpp,v <-- nsPlainTextSerializer.cpp new revision: 1.136; previous revision: 1.135 done Checking in extensions/irc/xul/content/output-base.css; /cvsroot/mozilla/extensions/irc/xul/content/output-base.css,v <-- output-base.css new revision: 1.17; previous revision: 1.16 done Checking in extensions/venkman/resources/content/venkman-output-base.css; /cvsroot/mozilla/extensions/venkman/resources/content/venkman-output-base.css,v <-- venkman-output-base.css new revision: 1.8; previous revision: 1.7 done Checking in layout/generic/crashtests/387058-1.html; /cvsroot/mozilla/layout/generic/crashtests/387058-1.html,v <-- 387058-1.html new revision: 1.2; previous revision: 1.1 done Checking in layout/generic/crashtests/387058-2.html; /cvsroot/mozilla/layout/generic/crashtests/387058-2.html,v <-- 387058-2.html new revision: 1.2; previous revision: 1.1 done Checking in layout/html/tests/block/interactive/154924.html; /cvsroot/mozilla/layout/html/tests/block/interactive/154924.html,v <-- 154924.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/bugs/403455-1-ref.html; /cvsroot/mozilla/layout/reftests/bugs/403455-1-ref.html,v <-- 403455-1-ref.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/bugs/403455-1.html; /cvsroot/mozilla/layout/reftests/bugs/403455-1.html,v <-- 403455-1.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/bugs/411792-1.html; /cvsroot/mozilla/layout/reftests/bugs/411792-1.html,v <-- 411792-1.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/text/white-space-1a.html; /cvsroot/mozilla/layout/reftests/text/white-space-1a.html,v <-- white-space-1a.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/text/white-space-1b.html; /cvsroot/mozilla/layout/reftests/text/white-space-1b.html,v <-- white-space-1b.html new revision: 1.2; previous revision: 1.1 done Checking in layout/reftests/text/white-space-2.html; /cvsroot/mozilla/layout/reftests/text/white-space-2.html,v <-- white-space-2.html new revision: 1.2; previous revision: 1.1 done Checking in layout/style/quirk.css; /cvsroot/mozilla/layout/style/quirk.css,v <-- quirk.css new revision: 1.58; previous revision: 1.57 done Checking in layout/style/viewsource.css; /cvsroot/mozilla/layout/style/viewsource.css,v <-- viewsource.css new revision: 1.16; previous revision: 1.15 done Checking in mail/components/addrbook/content/addressbook.xul; /cvsroot/mozilla/mail/components/addrbook/content/addressbook.xul,v <-- addressbook.xul new revision: 1.74; previous revision: 1.73 done Checking in mail/themes/pinstripe/mail/messageBody.css; /cvsroot/mozilla/mail/themes/pinstripe/mail/messageBody.css,v <-- messageBody.css new revision: 1.10; previous revision: 1.9 done Checking in mail/themes/qute/mail/messageBody.css; /cvsroot/mozilla/mail/themes/qute/mail/messageBody.css,v <-- messageBody.css new revision: 1.11; previous revision: 1.10 done Checking in mailnews/addrbook/resources/content/abCardViewOverlay.xul; /cvsroot/mozilla/mailnews/addrbook/resources/content/abCardViewOverlay.xul,v <-- abCardViewOverlay.xul new revision: 1.38; previous revision: 1.37 done Checking in parser/htmlparser/tests/outsinks/entityxif.xif; /cvsroot/mozilla/parser/htmlparser/tests/outsinks/entityxif.xif,v <-- entityxif.xif new revision: 1.3; previous revision: 1.2 done Checking in parser/htmlparser/tests/outsinks/plain.html; /cvsroot/mozilla/parser/htmlparser/tests/outsinks/plain.html,v <-- plain.html new revision: 1.5; previous revision: 1.4 done Checking in parser/htmlparser/tests/outsinks/plainwrap.html; /cvsroot/mozilla/parser/htmlparser/tests/outsinks/plainwrap.html,v <-- plainwrap.html new revision: 1.5; previous revision: 1.4 done Checking in security/manager/pki/resources/content/exceptionDialog.xul; /cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v <-- exceptionDialog.xul new revision: 1.8; previous revision: 1.7 done Checking in suite/themes/classic/messenger/messageBody.css; /cvsroot/mozilla/suite/themes/classic/messenger/messageBody.css,v <-- messageBody.css new revision: 1.17; previous revision: 1.16 done Checking in suite/themes/classic/navigator/pageInfo.css; /cvsroot/mozilla/suite/themes/classic/navigator/pageInfo.css,v <-- pageInfo.css new revision: 1.11; previous revision: 1.10 done Checking in suite/themes/modern/messenger/messageBody.css; /cvsroot/mozilla/suite/themes/modern/messenger/messageBody.css,v <-- messageBody.css new revision: 1.15; previous revision: 1.14 done Checking in suite/themes/modern/navigator/pageInfo.css; /cvsroot/mozilla/suite/themes/modern/navigator/pageInfo.css,v <-- pageInfo.css new revision: 1.10; previous revision: 1.9 done Checking in toolkit/components/console/content/console.css; /cvsroot/mozilla/toolkit/components/console/content/console.css,v <-- console.css new revision: 1.7; previous revision: 1.6 done Checking in toolkit/content/commonDialog.css; /cvsroot/mozilla/toolkit/content/commonDialog.css,v <-- commonDialog.css new revision: 1.4; previous revision: 1.3 done Checking in toolkit/content/xul.css; /cvsroot/mozilla/toolkit/content/xul.css,v <-- xul.css new revision: 1.117; previous revision: 1.116 done Checking in toolkit/themes/gnomestripe/global/netError.css; /cvsroot/mozilla/toolkit/themes/gnomestripe/global/netError.css,v <-- netError.css new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/pinstripe/global/netError.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/netError.css,v <-- netError.css new revision: 1.8; previous revision: 1.7 done Checking in toolkit/themes/pinstripe/global/console/console.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/console/console.css,v <-- console.css new revision: 1.12; previous revision: 1.11 done Checking in toolkit/themes/winstripe/global/netError.css; /cvsroot/mozilla/toolkit/themes/winstripe/global/netError.css,v <-- netError.css new revision: 1.8; previous revision: 1.7 done Checking in xpfe/components/console/resources/content/console.css; /cvsroot/mozilla/xpfe/components/console/resources/content/console.css,v <-- console.css new revision: 1.7; previous revision: 1.6 done

Sorry to butt in, but I would like to note that this change screwed up ChatZilla's and Venkman's display of messages on everything but trunk (because only trunk supports pre-wrap rather than -moz-pre-wrap). I don't expect you to care for all the versions we attend to, but some consideration with the last, current, stable Firefox release (which will be supported for another 6 months at least, even by you!) would have been appreciated. If you're not sure about foreign code, it would have been better to at least CC some peers or owners of relevant applications/add-ons/non-core-code, before making such a sweeping change. Thanks.

venkman and chatzilla are very unusual in that their in-trunk code is intended to be compatible with something other than the trunk. The breakage there should be fixed, but as we move towards more of this type of change rather than less, I think venkman is probably going to end up having to be in a different repository if it wants to maintain that compatibility. That said, I think this bug is also only half-fixed; only the first part of comment 0 has been done, not the second.

To be clear, venkman and chatzilla should be fixed by using: white-space: -moz-pre-wrap; white-space: pre-wrap; So that they'll work with builds both before pre-wrap was supported and after -moz-pre-wrap is dropped.

(In reply to comment #17) > To be clear, venkman and chatzilla should be fixed by using: > > white-space: -moz-pre-wrap; white-space: pre-wrap; > > So that they'll work with builds both before pre-wrap was supported and after > -moz-pre-wrap is dropped. > That is exactly what I did right after posting comment #15 here. :-)

(In reply to comment #16) > That said, I think this bug is also only half-fixed; only the first part of > comment 0 has been done, not the second. Can we rename the summary appropriately for this bug and file a new bug on the second part? It sounds like it's going to be a while before the second part can be done, so it doesn't make sense to leave this bug open for months.

We might as well leave this bug open for months as another one, and filing a new bug is more work. I'm not sure what to do about Venkman and Chatzilla. Either they should use a different repository, or maybe there should be a special directory for components that support older branches without being branched themselves.

Sorry, I didn't notice that. But the problem for Venkman and Chatzilla seems fixed. http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2008-03-08+05%3A23%3A00&maxdate=2008-03-08+05%3A27%3A00 Are there any still problems?

Filed bug 433065.