Closed
Bug 271978
Opened 20 years ago
Closed 16 years ago
move several components from Firefox to Toolkit
Categories
(bugzilla.mozilla.org :: Administration, task, P1)
bugzilla.mozilla.org
Administration
Tracking
()
RESOLVED
FIXED
People
(Reporter: steffen.wilberg, Assigned: gerv)
References
(Depends on 1 open bug)
Details
At least these Firefox components need to be moved to Toolkit:
*** mozilla/toolkit/components:
* Help Viewer (see bug 270764)
(source: mozilla/toolkit/components/help/)
* JavaScript Console (source: mozilla/toolkit/components/console/)
* Startup and Profile System (source: mozilla/toolkit/profile/).
That should probably be merged with the XRE Startup component which is already
in Toolkit (source: mozilla/toolkit/xre/).
* View Source (mozilla/components/viewsource/)
*** mozilla/toolkit/mozapps:
* Download Manager (there is already a DM component in Toolkit)
(source: mozilla/toolkit/mozapps/downloads/)
* Extension/Theme Manager
(source: mozilla/toolkit/mozapps/extensions/)
* Plugin Finder Service (source: mozilla/toolkit/mozapps/plugins/)
* Software Update (source: mozilla/toolkit/mozapps/update/)
Firefox's Password Manager lives in Toolkit as well (source:
mozilla/toolkit/components/passwordmgr/), but Thunderbird still uses Wallet, so
we should leave that component in Firefox for now to avoid confusions.
The same would apply to Form Manager (source:
mozilla/toolkit/components/satchel/), but there's already a Satchel component
(badly named IMHO) in Toolkit.
Comment 1•20 years ago
|
||
(In reply to comment #0)
> Firefox's Password Manager lives in Toolkit as well (source:
> mozilla/toolkit/components/passwordmgr/), but Thunderbird still uses Wallet, so
> we should leave that component in Firefox for now to avoid confusions.
Firefox and thunderbird aren't the only products using toolkit. Sunbird uses the
password manager as well, so it really should be in toolkit.
Comment 2•20 years ago
|
||
While I support this in principle, we need to find a good way of letting users
know that bugs in Firefox can be filed under Toolkit as well. Otherwise we'll
just end up with loads of stuff filed under Firefox General that would have
otherwise been filed under Firefox Download Manager, but that wasn't because the
correct component is Toolkit Download Manager but end users didn't know that.
Comment 3•20 years ago
|
||
End users consistently misfile bugs anyway, and I'd rather avoid end users
filing bugs directly on toolkit unless they've saavy enough to know what it is.
If Fx-General becomes like Browser-General (i.e. a place for bugs to get filed
for triagers to get to) then I consider that an acceptable solution.
Comment 5•20 years ago
|
||
installer also needs to from firefox/tbird to toolkit. Most valid tbird bugs
are already filed as firefox bugs, but newbies can't find them. The only
app-specific bugs there are packaging or localizations.
Comment 6•20 years ago
|
||
fine by me.
Updated•20 years ago
|
Assignee: asa → justdave
Comment 7•20 years ago
|
||
I moved help viewer. I'll do the others next.
Comment 8•20 years ago
|
||
Actually, that's a lot of moving. I think I'll ask dave to do a database move on
these.
Dave, can you help here?
Reporter | ||
Comment 9•20 years ago
|
||
Asa moved the bugs from Firefox:Help Viewer to Toolkit:Help Viewer. The bugs
lost their target milestones, and all flags, like review+, review?,
approval-aviary etc. The reason is that there is no Firefox1.1 target in
Toolkit, and no review flag, but first-review and second-review instead.
While the damage in the Help Viewer component is minor, we should find a better
solution for the other components. What's the equivalent target milestone for
Firefox 1.1 anyway?
Comment 10•20 years ago
|
||
> What's the equivalent target milestone for Firefox 1.1 anyway?
1.8
Reporter | ||
Comment 11•20 years ago
|
||
> > What's the equivalent target milestone for Firefox 1.1 anyway?
> 1.8
Thanks, I forgot. Looks like we need a "mozilla1.8final", or rather
"Gecko1.8final" target milestone in Toolkit, and probably Core as well. Asa?
And we should really try to migrate the review flags.
Comment 12•20 years ago
|
||
The problem with migrating review flags is that toolkit uses a different review
flag than Firefox. Toolkit uses "first-review" and Firefox uses "review". There
isn't an obvious way for me to move the specific review requests between the
flags without doing every single one manually.
Comment 13•20 years ago
|
||
moving them manually loses requester data which would be *bad*.
Comment 14•20 years ago
|
||
moving them automatically will also lose request data if the receiving
product:component doesn't have the same flags. In this case, Toolkit's flags are
different from Firefox's flags so we're hosed unless dave can migrate "review"
requests to "first-review" requests - I think.
Comment 15•20 years ago
|
||
he can do that, and our component mover feature for bugzilla will need to be
able to do that and similar mapping things anyway.
Updated•20 years ago
|
Priority: -- → P2
Updated•19 years ago
|
Assignee: justdave → justdave
Updated•19 years ago
|
Priority: P2 → P3
Comment 16•19 years ago
|
||
*** Bug 335853 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
Severity: normal → major
Priority: P3 → P1
Comment 17•18 years ago
|
||
I think a manual move is more feasible now that bug 377907 is fixed (timeless ended up changing all flags manually to fix that bug anyways). One thing I'm not sure of is whether we would lose already-set first-review[+-] flags. We could probably live with losing those and target milestones if that's all we need to worry about.
Comment 18•17 years ago
|
||
cc'ing Gervase Markham as this bug concerns the reorganization mentioned in his blog.
Assignee | ||
Comment 19•17 years ago
|
||
(In reply to comment #0)
> At least these Firefox components need to be moved to Toolkit:
The remaining requests in comment 0 of this bug have been merged into:
http://www.gerv.net/temp/bmo-reorg.html .
Gerv
Updated•17 years ago
|
QA Contact: ian → timeless
Reporter | ||
Comment 20•16 years ago
|
||
This has been fixed by bug 448639.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 21•16 years ago
|
||
Actually marking fixed instead (fixed as part of the BMO reorg in July 2008:
http://www.gerv.net/temp/bmo-reorg.html)
Assignee: justdave → gerv
Resolution: DUPLICATE → FIXED
Updated•13 years ago
|
Component: Bugzilla: Keywords & Components → Administration
Product: mozilla.org → bugzilla.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•