Closed
Bug 275900
Opened 20 years ago
Closed 20 years ago
Download for thunderbird extionsion lists filename as "install.php" instead of "xxx.xpi".
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: duncan.mcnutt, Assigned: ma1)
References
()
Details
(Keywords: regression)
Attachments
(3 files, 3 obsolete files)
(deleted),
patch
|
Bugzilla-alanjstrBugs
:
first-review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Bugzilla-alanjstrBugs
:
first-review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Bugzilla-alanjstrBugs
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Checked this with all thunderbird extensions.
Example page:
https://addons.update.mozilla.org/extensions/moreinfo.php?application=thunderbird&version=1.0&os=Windows&category=Miscellaneous&id=393
Download link on that page:
https://addons.update.mozilla.org/core/install.php?passthrough=yes&uri=http://ftp.mozilla.org/pub/mozilla.org/extensions/messagefaces/messagefaces-1.0-tb.xpi
Right click, "Save link as..." tbe "save as" dialog comes with the filename
install.php in the filename field and saves it under that name.
Actually this is probably a major bug, since FireFox and Thunderbird are aiming
at the normal users not computer savvy people anymore. I left it a normal for
now though.
A) the php script should deliver the proper name, or
B) if possible firefox should be told to download the thunderbird extione
instead of installing the xpi itself.
B) Would be the best solution but A is probably easier for a quickfix.
PS: can't believe this bug hasn't been filed... but I triple-checked!
Reproducible: Always
Steps to Reproduce:
1. Go to any thunderbird extionsion with browser firefox.
2. Right click on Install xpi link, select save as
3. Save file "install.php" (very usefull...;)
Actual Results:
File named "install.php" instead of xxx.xpi on hard disk.
Expected Results:
Saved the proper name of the xpi file.
Did this on a WinXP with Firefox1.0, but it should be independant of that.
Updated•20 years ago
|
Assignee: psychoticwolf → nobody
Comment 1•20 years ago
|
||
According to the Thunderbird Themes download page, the directions indicate to
'right-click the link above and choose "Save link as..."'. When the action is
performed, the 'Save As' box appears. HOWEVER, the 'Save as type' box only
allows you to save the file as a text document...which is not a .jar file
required to install the theme.
What is the worst thing about this bug, is that I could download the themes
using the Internet Explorer browser!! On downloading (left-click) it defaulted
to a zip archive. Then I could install it!!
As we're fond of saying on the mozillazine forums, this sounds like a MIMEtype
issue.
Comment 3•20 years ago
|
||
major bug, the file saved gets the name of the script doing the redirection to
the xpi file and not the xpi file name
It could be a real browser bug in the way we parse the url to get the filename
(works fine in IE and Opera), if this is the case we look really dumb to expose
one of our bugs to the world on our very web site.
Currently, the thunderbird section of mozilla update is just non-fonctionnal,
only a handful of geeks will understand that the install.php file as to be
renamed as an xpi file.
Severity: normal → major
Comment 4•20 years ago
|
||
Hello,
This isn't a MIME type bug its a website construction bug.
If you visit the download site (firefox), e.g.
https://addons.update.mozilla.org/extensions/?os=nt&application=firefox
and select one of the items, then right-click and select save link as, it
correctly saves the file as a xpi
if you visit the same download site but for thunderbird, e.g.
https://addons.update.mozilla.org/extensions/?os=nt&application=thunderbird
when you select an extension it wants to save install.php no matter what
extension you have.
Also, don't you think it's a bit daft this far into the development that you
can't actually install a thunderbird extension in the same way as Firefox given
the interface is meant to be (and looks) exactly the same? This is after all
supposed to be the premier email and web browsing experience.
Neil.
How do you know we're not serving the wrong mimetype with only thunderbird? Did
you look at the code?
Or it could be a problem with the mirror that it happens to point to. If that
mirror has the wrong MIMEtype, for example, it could just be picking that up.
I want to add that this problem happens to me as well. What good is it that I am
trying to download extensions for Thunderbird from the extensions site using
Mozilla Firefox 1.0, and it does not work? Not a good advert for Mozilla. Here I
am recommending it to others, and I am glad that this bug did not happen to me
when someone else was here. I was going to give the URL for the extensions to
someone who was asking me about Thunderbird, and is using Firefox, but now I
won't until the problem is fixed. I think it is probably a bug in Firefox that
needs to be sorted very quickly otherwise critics of Firefox will say that
people should stick with IE.
*** Bug 277906 has been marked as a duplicate of this bug. ***
Comment 8•20 years ago
|
||
This is actually a bug in Firefox. It's also already been fixed, but it was
checked in *after* Firefox 1.0 was released, so Firefox 1.0 still has this
problem. This was bug 263697.
Comment 9•20 years ago
|
||
As long as path info is enabled on the server, this actually can be fixed in
Update.. the Update 0.9 behavior to work-around this bug (as it appears in IE as
well) is to use URLs such as install.php/$filename?id=$id&vid=$vid, should be a
one-line fix in a few places to add the /$filename part. :-)
Comment 10•20 years ago
|
||
This is minor enough and a one-line fix in most cases, the usability improvement
for Thunderbird warrants consideration for 1.0 and not being pushed back to 1.1
in a bulk-move. Update 0.9 didn't have this behavior, so this is a regression.
Keywords: regression
Target Milestone: 1.1 → 1.0
Comment 11•20 years ago
|
||
Version 1.0 is already released. Please don't retarget bugs unless you're an
official peer. Version 1.1 is when we expect to have this fixed by. That
doesn't mean it won't happen before then.
Target Milestone: 1.0 → 1.1
Assignee | ||
Updated•20 years ago
|
Assignee: nobody → g.maone
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 12•20 years ago
|
||
You can test it copying various Thunderbird extensions URLs from UMO to
http://flex.informaction.com/test/275900.php?uri=https%3A%2F%2Faddons.update.mozilla.org%2Fcore%2Finstall.php%3Fpassthrough%3Dyes%26uri%3Dhttp%3A%2F%2Fftp.mozilla.org%2Fpub%2Fmozilla.org%2Fextensions%2Fenigmail%2Fenigmail-0.89.5-tb-windows.xpi
and right-clicking/saving as on the link that appears below the form.
Attachment #172133 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Comment 13•20 years ago
|
||
So...
1) Comment 8 is wrong.
2) Comment 4 is spot-on. For example, for the ConQuery extension, the Firefox
"Install Now" link is to:
http://ftp.mozilla.org/pub/mozilla.org/extensions/conquery/conquery-1.4.5-fx+mz+tb.xpi
And the Thunderbird "Install Now" link is to:
https://addons.update.mozilla.org/core/install.php?passthrough=yes&uri=http://ftp.mozilla.org/pub/mozilla.org/extensions/conquery/conquery-1.4.5-fx+mz+tb.xpi
See the difference?
Assignee | ||
Comment 14•20 years ago
|
||
To tell the truth, this is a bit more robust (it handles the very unlikely case
that $uri doesn't point to a canonical .xpi file, fallbacking to
$name_$version.xpi).
Attachment #172133 -
Attachment is obsolete: true
Attachment #172137 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Assignee | ||
Comment 15•20 years ago
|
||
Let's hope this time doesn't get cut :(
Attachment #172137 -
Attachment is obsolete: true
Attachment #172138 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Assignee | ||
Comment 16•20 years ago
|
||
Modularizes a functionality used 4 times: twice in /extension/moreinfo.php and
twice in /themes/moreinfo.php (see PHPDocs introducing the function and the two
upcoming patches).
Attachment #172144 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Assignee | ||
Comment 17•20 years ago
|
||
Fixes another unreported occurrence of the same bug.
Depends on attachment 172144 [details] [diff] [review].
Attachment #172138 -
Attachment is obsolete: true
Attachment #172145 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Attachment #172133 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Assignee | ||
Comment 18•20 years ago
|
||
Fixes the same bug, occurring with theme jars too.
Depends on attachment 172144 [details] [diff] [review].
Attachment #172146 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Assignee | ||
Updated•20 years ago
|
Attachment #172145 -
Attachment description: New version. → New version of extensions/moreinfo.php (more fixes)
Attachment #172144 -
Flags: first-review?(Bugzilla-alanjstrBugs) → first-review+
Attachment #172137 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Attachment #172138 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Attachment #172145 -
Flags: first-review?(Bugzilla-alanjstrBugs) → first-review+
Attachment #172146 -
Flags: first-review?(Bugzilla-alanjstrBugs) → first-review+
landed on branch & trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: landme
Comment 20•20 years ago
|
||
*** Bug 279566 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 21•20 years ago
|
||
*** Bug 280158 has been marked as a duplicate of this bug. ***
Comment 22•20 years ago
|
||
*** Bug 280402 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 23•20 years ago
|
||
*** Bug 280558 has been marked as a duplicate of this bug. ***
Comment 24•20 years ago
|
||
this bug may be resolved for extenstions, but it does not appear to be
completely fixed for themes. trying to download theme
https://addons.update.mozilla.org/themes/moreinfo.php?application=thunderbird&version=1.0&os=Windows&id=131
in firefox results in the install.php file.
the downloaded install.php will install, however in the thunderbird theme
install dialog, it defaults to a .jar file name extension filter, but the
downloaded theme has .php file name extension. the file type filter has to be
changed to "all files" in order to install the install.php theme file.
we should either re-open this bug or file a seperate bug, yes? additionally, i
just noticed that all the duplicate bug reports are related to themes, not
extensions... perhaps that's important, i don't know. thanks.
Assignee | ||
Comment 25•20 years ago
|
||
(In reply to comment #24)
> this bug may be resolved for extenstions, but it does not appear to be
> completely fixed for themes. trying to download theme
>
https://addons.update.mozilla.org/themes/moreinfo.php?application=thunderbird&version=1.0&os=Windows&id=131
> in firefox results in the install.php file.
Looks like patch #172146 has never landed on the live site, or has been
overwritten by some other one.
On my test site (with patch #172146 but without theme installation instructions)
everything is fine:
https://flex.informaction.com/themes/moreinfo.php?application=thunderbird&version=1.0&os=Windows&id=131
Could someone check it?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 26•20 years ago
|
||
this link accesses your page (not https :)
http://flex.informaction.com/themes/moreinfo.php?application=thunderbird&version=1.0&os=Windows&id=131
and it results in a .jar file download for me.
Comment 27•20 years ago
|
||
Per comment 19, this is fixed in CVS. We can't do anything about the website
itself. Do not reopen this bug until either you've tested it against a dev
environment or the live site has been updated.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Comment 28•20 years ago
|
||
Sorry, maybe I'm a bit thumb but I read the bug is fixed but I can not find out:
Is it a bug of the Website? or
Is it a bug of firefox?
And how can I make my firefox download the *.jar files from:
https://update.mozilla.org/themes/showlist.php?application=thunderbird&version=1.0&os=win&category=All
Now I have to browse to the Authors websites to download the current versions.
What is the sense of marking the bug as fixed without poining out a solution for
the user who wants to report this bug??
Stefan
Assignee | ||
Comment 29•20 years ago
|
||
(In reply to comment #28)
> Is it a bug of the Website?
Yes and no. Yes if it is not a bug of Firefox, no otherwise.
> Is it a bug of firefox?
Yes and no.
There's no "official standard" about handling downloads in the browser, so we
couldn't really say it is a bug. We may say it is an annoyance, specially
compared to default IE behaviour which (correctly?) saves the file under its
ultimate name.
Since firefox doesn't follow redirects *before* initializing a "save as" dialog,
it suggests a name deducted by the link URL as it is originally (install.php).
IE, instead, follows the redirection and suggests a name based on the "final
destination URL" (xxx.jar).
Firefox approach is slightly more efficient, while IE approach is far more
accurate. Well, I'm inclined to call it a Firefox bug in the end ;)
> And how can I make my firefox download the *.jar files from:
>https://update.mozilla.org/themes/showlist.php?application=thunderbird&version=1.0&os=win&category=All
You can use FlashGot (http://www.flashgot.net) with Free Download Manager
(http://www.freedownloadmanager.org) or another external download manager that
follows redirects before it prompts you for saving.
> What is the sense of marking the bug as fixed without poining out a solution for
> the user who wants to report this bug??
The bug, if we consider it a Website bug, is "technically" fixed: I've written
the code working around the problem (demonstrated in
http://flex.informaction.com/themes/moreinfo.php?application=thunderbird&version=1.0&os=Windows&id=131),
and submitted it as patch (attachment 172146 [details] [diff] [review]), which has been properly applied
to the development environment (comment #19).
The only little missing step to let you use the website as you wanted (and you
should) is synchronizing the live website with the development environment:
looking at the calendar, it seems one month is not enough, but it is not in my
power doing anything about it :(
Comment 30•20 years ago
|
||
*** Bug 283865 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 31•20 years ago
|
||
*** Bug 286720 has been marked as a duplicate of this bug. ***
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•