Closed
Bug 27716
Opened 25 years ago
Closed 25 years ago
Text -> HTML converter cuts of URLs after commas
Categories
(MailNews Core :: MIME, defect, P3)
MailNews Core
MIME
Tracking
(Not tracked)
VERIFIED
FIXED
M14
People
(Reporter: rzach, Assigned: BenB)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
An URL like
http://www.spiegel.de/netzwelt/ebusiness/nf/0,1518,61247,00.html
gets cut off after the first comma, i.e., gets turned into
< a
href="...">http://www.spiegel.de/netzwelt/ebusiness/nf/0</a>,1518,61247,00.html
I guess it's more likely that a comma after an URL is sentence punctuation, but
maybe the converter can be a little more sophisticated: not cut off the URL is
no whitespace follows the comma, or check whether there's something that looks
like a file extension before the next whitespace.
Note that Wired articles also have filenames with commas in them. In general, I
suppose it would be better to err on the side of longer URLs, since then you can
just delete the extraneous part in the location bar, as opposed to having to cut
and paste.
Assignee | ||
Comment 1•25 years ago
|
||
zach,
Thanks for submitting the bug report and filing it directly against me.
There're lots of such wierd URLs, and I don't like the thought of special-casing
them all, even if it's possible, like in this case. However, I'm not sure, if
that is the right decision. LATER or WONTFIX, but WONTFIX for now.
Such URLs, like any others BTW, are supposed to be enclosed in angle brackets.
<http://www.spiegel.de/netzwelt/ebusiness/nf/0,1518,61247,00.html> should be
recognised correctly.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 2•25 years ago
|
||
Fair enough. Filed bug 27762, asking for <, > around URLs generated by "Send
Link" and "Send Page". verified wontfix.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 3•25 years ago
|
||
Actually, there already was a special case for such chars, it was a bug, that it
didn't work for ",". REOPENING.
(Very simple) patch follows. Could somebody please review and check it in?
Status: VERIFIED → REOPENED
OS: Linux → All
Hardware: PC → All
Resolution: WONTFIX → ---
Whiteboard: Patch available, waiting for review and checkin
Target Milestone: M14
Assignee | ||
Comment 4•25 years ago
|
||
Assignee | ||
Comment 5•25 years ago
|
||
Patch checked in by rhp. Thanks. FIXED.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Whiteboard: Patch available, waiting for review and checkin
Reporter | ||
Comment 6•25 years ago
|
||
Verified fixed on Linux build 2000.02.16.09.
Status: RESOLVED → VERIFIED
cc:ing asj@ipa.net since this contains a good test case for text to html
conversion
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•