Closed
Bug 27762
Opened 25 years ago
Closed 25 years ago
URL from Send Page and Send Link needs angle brackets
Categories
(MailNews Core :: Composition, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M15
People
(Reporter: rzach, Assigned: bugzilla)
Details
(Whiteboard: fix in hand)
When you call the mail compose window with an URL from the browser Edit | Send
Page or Edit | Send Link menu item, and the default account is set to send as
plain text, the URL should be enclosed in angle brackets <, >.
See bug 27716 for the reason: otherwise, TXTtoHTML may not linkify the URL
correcly on the receiving end.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 1•25 years ago
|
||
A completely agree with zach (although 27716 was a bad example, it is already
fixed).
RFC2396 recommends this format. It makes recognition of wierd URLs possible or a
lot easier.
Assignee | ||
Comment 2•25 years ago
|
||
trivial fix, here is the diff:
Index: MsgComposeCommands.js
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.73
diff -r1.73 MsgComposeCommands.js
240c240
<
msgCompFields.SetBody("\n" + args.body + "\n");
---
>
msgCompFields.SetBody("\n<" + args.body + ">\n");
Whiteboard: fix in hand
Target Milestone: M15
Assignee | ||
Comment 3•25 years ago
|
||
the rfc say that angle brackets are often used as url delimitor but doesn't say
that you must use it!
extract from rfc 2396:
The angle-bracket "<" and ">" and double-quote (") characters are excluded
because they are often used as the delimiters around URI in text documents and
protocol fields. The character "#" is excluded because it is used to delimit a
URI from a fragment identifier in URI references (Section 4). The percent
character "%" is excluded because it is used for the encoding of escaped
characters.
Phil, Jeff, any comment?
Comment 4•25 years ago
|
||
Doesn't matter to me. No standard requires or prohibits this usage. If people
feel like it would improve things, go for it. The thing I don't want to see is
the silly and verbose <URL: http://www.mozilla.org>
Comment 5•25 years ago
|
||
Ducarroz,
Appendix E is the part of interest.
<quote>
In practice, URI are delimited in a variety of ways, but usually within
double-quotes "http://test.com/", angle brackets <http://test.com/>, or just
using whitespace
http://test.com/
[...]
Using <> angle brackets around each URI is especially recommended as a
delimiting style for URI that contain whitespace.
</quote>
I thought, it was explicitly recommended, but at least I do. Our recognizer will
stop e.g. at the first closing bracket, and some stupid websites use them
(although strictly a violation of the standard) in their URLs. Example:
<http://www.deja.com/[LB=http://www.mozilla.org/]/thread/%3c38B63CF2.7A661C3A@netscape.com%3e%231/1>.
Stop guessing.
Assignee | ||
Comment 6•25 years ago
|
||
Thank for pointing me to the right paragraph. I will add the angle-bracket in
plain text mode only as describe in my patch here above.
Assignee | ||
Comment 7•25 years ago
|
||
Fixed and checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 8•23 years ago
|
||
buildid: 2001051708 linux, win98
marking verified,
< > URL within the angle brackets with plain text compose
sending url without < > for html compose
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•