Closed Bug 279018 Opened 20 years ago Closed 17 years ago

messages not automatically moved to Junk folder when manually marked as Junk

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: robzilla, Assigned: Bienvenu)

References

Details

(Keywords: verified1.8.1.8)

Attachments

(2 files)

In the "Junk Mail Controls" dialog, I've checked "When I manually mark messages as Junk:" and set the following option to 'Move them to the "Junk" folder' However, when I mark a message as Junk, it is not moved to the Junk folder. Nothing happens at all.
WFM WinXP/Tb 1.0
if it helps, my mail folders were imported (when I first launched Tb) from Outlook Express. There was no "Junk" folder by default, so I just created one. Tb seems to have noticed it, because it has the junk icon next to it in the folder tree. But, perhaps it only half-noticed it.
Do you use "Global Inbox"? If yes, - Is "Local Folders" the Global Inbox account? - For which account did you set "Junk Control"? The mail account(s)? Or account of "Locla Folders"? - On which account did you execute "Mark as Junk" manually? See http://kb.mozillazine.org/Thunderbird_:_FAQs_:_Global_Inbox See http://kb.mozillazine.org/Thunderbird_:_FAQs for other THunderbird FAQs.
(In reply to comment #3) > Do you use "Global Inbox"? yes > If yes, > - Is "Local Folders" the Global Inbox account? yes (is there even a way to change this?) > - For which account did you set "Junk Control"? > The mail account(s)? Or account of "Locla Folders"? At first, it was only set for Local Folders, but then I turned it on for my 2 mail accounts as well (but it didn't make a different). Also tried restarting Tb just for good measure. > - On which account did you execute "Mark as Junk" manually? i tried messages recieved from both accounts, to no avail.
(In reply to comment #4) (Q1)What is "folder location" of the folder you created as "Junk". - "Copy folder location" form context menu of the "Junk" folder you created. (Probably "Junk" under "Local Folders") - Open text editor(notepad) and paste(CTRL+V) (Q2)What is you Junk folder choice in your Junk Control for "Local Folders"? Go Junk Mail Control of "Local Folders" and write down all of your settings. > (is there even a way to change this?) Yes. "Server Settings"/"Advanced"/"POP tab" of account settings is it.
> (Q1)What is "folder location" of the folder you created as "Junk". mailbox:/C|/Documents and Settings/rsiklos/Application Data/Thunderbird/Profiles/5urowc9r.default/Mail/Local Folders/Junk > (Q2)What is you Junk folder choice in your Junk Control for "Local Folders"? "Do not mark messages as junk mail if the sender is in my address book" - checked (Personal Address Book) "Move incoming messages determined to be junk mail to" - unchecked '"Junk" folder on: Local Folders' - selected (disabled) "Other:" - not selected (disabled) "Automatically delete junk messages older than 14 days" - unchecked "When I manually mark messages as Junk:" - checked "Move them to the "Junk" folder" - selected "Delete them" - not selected "When displaying HTML messages marked as junk, sanitize the HTML" - checked
Same situation is reported by Bug 268101. > Bug 268101 : Junk folder does not show up if only the "manually mark" option in "Junk Mail Controls" is set Checking "Move incoming messages determined to be junk mail to" is required. If checked, Junk folder will also be created automatically. I think this is current design of Junk filtering. As far as I remeber, improvement of the confusing/wrong UI is already requested, I can't recall the bug number and I couldn't find bug by my quick search though. Bug 205883 is one of UI improvement requests, but it doesn't refer to your problem...
I am having this problem as well - new install of Thunderbird 1.0 on W2k. The account I want to manually tag junk messages on is an IMAP account if that matters. When I click on a message to mark as junk, the recycle bin icon appears but the message is not moved to the Junk folder.
Same problem for me - though I have a Junk box because I once turned on the full automatic Junk processing (it's now off again). In response to comment #7, I'd like to suggest that the Junk Controls interface is fine the way it is - the separation of automatic and manual junk processing is desirable. The adaptive junk filter needs training - it initially wanted to eat about half of my inbox whether it was junk or not - so having junk moved only on manual selection while it's learning seems the best solution. Once it's getting the junk assessment 95% right, that's when the automatic option becomes useful. I wanted to comment because I would hate to see this bug fixed by changing the UI to make the manual option dependent on the automatic option being enabled. I think the correct fix is to keep them separate and make the manual option move the junked message.
Apparently this is the way mozilla mail works as well (at least with 1.7.6). I agree with Joel 100%. This seems wrong. You should be able to have it move messages you mark manually into Junk even if the automatic moving of such messages is disabled.
OS: Windows XP → All
Hardware: PC → All
Version: 1.0 → Trunk
(In reply to comment #9) > the separation of automatic and manual junk processing is desirable. (In reply to comment #10) > You should be able to have it move messages you mark manually into Junk > even if the automatic moving of such messages is disabled. I agree with you, If current UI should be kept. But if current design is kept, UI should be changed, I think. X Enable adaptive filter use(=> Invoke creation of Junk folder) X Enable inboud mail junk filtering X Enable manual junking Anyway, I think this kind of discussion to get right solution for this problem is better to be done in Bug 268101, after closing this bug as DUP of it.
Also see bug 205883 The Junk Mail Controls have improved quite a bit and are almost perfect now (although it would be a bit more logical if the controls were located in the accounts settings?). The 'Handling' part needs a bit more love though, the main problem seems to be the selection of the junk mail folder. You can only do this in the 'move incoming messages are determined to be junk mail' part of the dialog but I don't want to use that section (the server deals with 99% of my spam and moves it to my 'spam' folder). The only thing that I want to use is the 'When I manually mark messages as Junk' (incosistent wording BTW 'junk mail' vs 'Junk'), I want this mail to go to my 'SA-SPAM' folder where it gets picked up by the server to train it's filters. The most ideal situation for my would be if you could select a folder in both the 'Move incoming' and 'manually mark' sections. This way you can use the controls both when Thunderbird does all the spam handling and also if your server handles your mail and if you can train the server by moving false negatives to a special (IMAP) folder. At the moment I have 'move incoming messages' enabled just so that I can use the 'manually mark' option. But this way I have to use three folders for spam. One with the messages that my server marked as spam, one where Thunderbird moves messages that it thinks is spam and one where I put messages for training the server. I also have to check two folders now (Junk and SPAM) for false positives from Thunderbird and the server respectively. I could solve that by disabling 'adaptive junk mail detection' but for some weird reason that disables the 'when I manually mark' option. Bottom line: - Don't gray out 'when I manually mark' when 'adaptive detection' is disabled - Enable the user to pick a junk mail folder for 'manually mark'
Bug 292038 deals with the 'require adaptive filtering' part BTW. Sorry, forgot to mention this in my last comment.
*** Bug 292038 has been marked as a duplicate of this bug. ***
When manually marking (by me), it does move the messages. When marking is done by the program, they sometimes but not always move. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 ID:2006050805
Rob Siklos: is this bug still a problem for you? Did comment 12 shed any light on your problem? Specifically, did you already have "Enable adaptive junk detection" (Tools|Junk Mail Controls|Adaptive Filter) turned on? Altho bug 292038 was duped to this, it was about only that point; but you specifically reported that you'd "checked 'When I manually mark message...'" and that checkbox is disabled when adaptive junk detection is turned off.
Summary: messages aren't automatically moved to Junk folder when marked as Junk → messages aren't automatically moved to Junk folder when manually marked as Junk
(In reply to comment #16) > Rob Siklos: is this bug still a problem for you? Did comment 12 shed any light > on your problem? > > Specifically, did you already have "Enable adaptive junk detection" > (Tools|Junk Mail Controls|Adaptive Filter) turned on? Altho bug 292038 was > duped to this, it was about only that point; but you specifically reported that > you'd "checked 'When I manually mark message...'" and that checkbox is disabled > when adaptive junk detection is turned off. > Yes - the problem still happens, and playing with the "adaptive" settings doesn't seem to make any difference.
I too have enabled 'adaptive junk mail detection' and 'When I manually mark messages as Junk:' -> 'Move them to the "Junk" folder' but messages aren't moved when I mark them as Junk. version 1.5.0.2 (20060308) / Mac OS X 10.4.6 / Courier IMAP. Others have noted that you have to enable "Move incoming messages determined to be junk mail to:" in order to be able to select which folder your junk mail folder is. I have found that if (and only if) I leave that option enabled messages are moved to the junk mail folder when manually marked as junk. So the bug seems to be that not only in the UI but also underneath the hood all junk mail moving can't be manually triggered unless it's also automatically triggered.
I am having a similar problem with the junk mail filter. When I set the program to move junk mail to a certain folder then click okay, it doesn't save the folder name. When you reopen the junk mail controls, the changes arn't there. this goes for all my accounts..Version used is 1.5.04 using Windows 2000 Pro.
Is junk mail detection working at all now in recent nightly builds? Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060618 Thunderbird/2.0a1 ID:2006061815
Flags: blocking-thunderbird2?
This bug goes off in so many directions about other issues that I can't even figure out what the real issue/cause is. Is it only IMAP mail, IMAP mail that was imported, Pop mail, not enough options in the UI, adaptive filter not smart enough? the bug goes off in too many directions. Reporter: please describe your set up (OS and such)? what kind of mail (IMAP, Pop)? imported mail or incoming mail? Does it move to junk after a restart? How about a new profile, still same issue? Then the title needs updated to be more specific like "Manually marking imported IMAP mail as junk not moved to junk folder". There are a bunch of "messages not moved to junk folder" bugs and most are probably dupes of others.
See comment #6 I can add that "Enable adaptive junk detection" (Tools|Junk Mail Controls|Adaptive Filter) is turned on. The key is that "Move incoming messages determined to be junk mail to" has to be unchecked to reproduce.
(In reply to comment #22) Thomas: tried thunderbird2 alpha? Things have changed a bit as junk is now an account setting...
(In reply to comment #23) Well, it's even worse with the alpha 1 : I can't make the spam move to the junk folder even when the adaptive junk detection is enabled (I haven't seen something like "Move incoming messages determined to be junk mail to").
The moving is now in the account settings...
Actually, you're right and I didn't remembered it. I've just checked it now and it doesn't work even with this option set, so it's worse than with Thunderbird 1.5 : the bug always reproduces. There's also an additional bug : when I mark a mail as junk, its status always becomes "read" even if the option is set do "don't mark as read".
*** Bug 299826 has been marked as a duplicate of this bug. ***
Summary: messages aren't automatically moved to Junk folder when manually marked as Junk → messages not automatically moved to Junk folder when manually marked as Junk
*** Bug 308411 has been marked as a duplicate of this bug. ***
I'm using Thunderbird version 1.5.0.7 (20060922) under Ubuntu Dapper and I have no longer this bug since I switched my imaps server simple name (blopsrv) to a FQDN (blopsrv.mydomain.com) : BUG : my imaps server name : "blopsrv" NO MORE THIS BUG : my imaps server name : "blopsrv.mydomain.com" Before I had this bug ! Hoping it will be helpful....
Under Thunderbird 1.5.0.9 my mail manually marked as junk was moving out of the folder automatically however in Thunderbird 2b2, it no longer does this. The mail is marked as junk but I have to close the folder and open it again.
Moving off bugs that didn't make the deadline for Thunderbird 2.
Flags: blocking-thunderbird2? → blocking-thunderbird2-
Target Milestone: --- → Thunderbird 3
I think there is a regression here (from 1.5... to 2b2). In 2b2, with multiple email accounts (3 in my case) under IMAP, it's impossible to set all the junk controls to cause junk to be automatically moved to the corresponding IMAP spam folder. You can set the controls for one account and that one works, but the settings for other accounts are altered so that they no longer work (usually the automatic move box for the other accounts is cleared). I can find no way of getting all the settings to be automatic move to the spam folder. This used to work. Please reconsider the deadline as this bug is going to cause a lot of trouble.
Mike Hall, you are reporting Bug 368303 which was fixed after beta 2 and is fixed in the RC. Cheers...
QA Contact: preferences
Do we want to at least disable the UI that would lead someone to believe that they could click "junk" and have it moved to a folder? That might be minor enough to do in a 2.0.0.x update, I'd almost hope a little. (2.0.0.5, XP, IMAP inboxes and target Junk folder)
When I have a message selected, and click on junk, it gets moved to the junk folder, as per the UI settings. This is with both 2.0 and the trunk. So I'm not convinced that this simply never works. Does anything show up on the error console when this fails?
David, do you have "Move junk message to" checked in the Account Settings for that account? Supposedly this works only if you have that checked. See bug 268101 and bug 217528 (which I think this is essentially a dupe of). FWIW, I don't get any error message in the console when I mark a message as junk manually and it's not moved (using version 2.0.0.4 (20070604) on WinXP).
(In reply to comment #35) > So I'm not convinced that this simply never works. Actually, you're right. This works if those 2 conditions are true : - Adaptative junk control for local folders is enabled - Automatically move junk messages is enabled This is, of course, when you have selected to use the local folder for an account, else its specific options are probably used.
Ah, I see. Yes, that makes sense. I do have that set. Instead of removing the UI, I'd probably investigate getting it to work in the scenario where it doesn't.
I'd love that too, but that it didn't make Tb2 made me think that we could at least make 2.0.0.x not offer that trap. :) I don't want anything done automatically with my mail, so I didn't check the latter box.
Attached patch proposed fix (deleted) — Splinter Review
we shouldn't be checking this setting at all...
Assignee: mscott → bienvenu
Status: NEW → ASSIGNED
Attachment #273159 - Flags: superreview?(mscott)
I don't think, though that not having those options selected is the full problem. I have both options selected both for the account and for local folders. This worked for a while and then suddenly stopped with no obvious (to me) trigger. Unsetting the options and then turning them back on worked last time, but it again stopped working after a little while. As with the rest, I see no error messages in the console. It makes me think some exception is being swallowed somewhere. Re: Comment #40 I'm not sure that fully makes sense. Does marking something as junk imply it should be moved to the junk folder? If you have the preference for "automatically move new junk messages to" turned OFF, might that not imply you don't want any messages moved automatically? Perhaps we need an additional setting for dealing with these scenarios separately?
This feature WORKS only if you have "Enable adaptive filter" enabled. Otherwise, the feature doesnt work. My thought is that this should work without the adaptive filter for those of us which have external spam detection utilities as this would cut down on duplicate/triplicate spam detections.
pinging for review request. there may be other issues, but this one is obvious, happens all the time, and isn't random/intermittent/hard to track down.
Comment on attachment 273159 [details] [diff] [review] proposed fix looks good David.
Attachment #273159 - Flags: superreview?(mscott) → superreview+
fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment on attachment 273159 [details] [diff] [review] proposed fix requesting approval for 2.0.0.7
Attachment #273159 - Flags: approval1.8.1.7?
this also didn't work in a cross-folder saved search, because of the way this operation tried to insinuate itself into the command handling process. This fixes that...
Attachment #274818 - Flags: superreview?(mscott)
Attachment #274818 - Flags: superreview?(mscott) → superreview+
both patches landed now.
Attachment #273159 - Flags: approval1.8.1.7? → approval1.8.1.7+
Comment on attachment 274818 [details] [diff] [review] [landed for 1.8.1.8] proposed fix for marking as junk in cross-folder saved search this patch is also useful and safe, I think.
Attachment #274818 - Flags: approval1.8.1.7?
first patch landed on 1.8.1.7 branch
Keywords: fixed1.8.1.7
Comment on attachment 274818 [details] [diff] [review] [landed for 1.8.1.8] proposed fix for marking as junk in cross-folder saved search a=mscott for 1.8.1.8
Attachment #274818 - Flags: approval1.8.1.8? → approval1.8.1.8+
Attachment #274818 - Attachment description: proposed fix for marking as junk in cross-folder saved search → [landed for 1.8.1.8] proposed fix for marking as junk in cross-folder saved search
verified fixed 1.8.1.8 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.8pre) Gecko/20071008 Thunderbird/2.0.0.7pre Mnenhy/0.7.5.666 ID:2007100904 -> adding verified keyword
Where did the "When I manually mark messages as Junk" option go? Did you remove it from the UI? I'm using IMAP, and I had it set to simply leave the messages in my inbox when they were marked as junk... because it is easy to accidentally mark a valid message as junk, and it is hard to tell which message you did that to, or if you actually did that, when it suddenly disappears. I get hundreds of messages a day, and dozens and dozens of stuff that Thunderbird's spam filter doesn't catch (50% effective, but 0.00000% false positives, the way I like it). I then very happy to mark the missed ones as junk, change my view to "Junk", highlight and delete a few dozen of these, and then reset my view. I upgraded 2.0.0.9 and all of a sudden this behavior has changed, without warning, and I have no option to simply leave the messages in my inbox... although messages that Thunderbird chooses to mark as junk are left in my inbox, because I do not have "Move new junk messages" checked. Why should manually marking an email as junk produce a different behavior?!?
> Where did the "When I manually mark messages as Junk" option go? Options > Privacy > Junk. Didn't move.
... so, why did it get reset, then? That isn't the normal practice with upgrades, and I've upgraded religiously every single time. Shouldn't that be marked as a bug? I guess I'll file it, if it hasn't been filed elsewhere. ... and the screen caps I found on the web show that, at least in some previous version (probably the last time I set this), these were on the same page. Do a search on Google images: "mozilla thunderbird mark message as junk" ... the first several images that come up show the controls for these on the same page. This is vastly more logical than putting them in separate locations. How many more people like me are going to be annoyed and go look in the last place they found this setting, only to find it "missing"?
I still see the following behavior with latest thunderbird 2 and with the thunderbird 3 nightly build: If "Enable adaptive junk mail controls for this account" is unchecked, then manually marking mail as junk does not move nor delete the junk mail no matter what "When I mark new messages as junk..." is set to. If adaptive filtering is checked, it works as expected. Those of us with external spam filtering really want this to work properly.
Any chance of any of this bug making it over to branch build? It has been fixed on trunk for quite a while now, and no trunk release seems to be forthcoming this month. Thanks.
verified1.8.1.8 = it's already in tb2.0.0.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: