After bug 17453 is checked-in, there will be no way to manage enums except by editing the database directly. This bug is a feature request to add an administration page to edit these "Field Values."

I've cleaned this up a LOT from the previous version that was on bug 17453. I've tested it pretty well, and it works for me. You can see it in action at http://landfill.bugzilla.org/bz281876/editvalues.cgi Everybody has editcomponents on the installation.

Actually, this one's slightly cleaner. I totally eliminated use of CGI.pl (and thus also globals.pl) in the script, because it's not necessary. :-)

Colin found a few tiny little bugs for me in the templates, so they're fixed here.

Ack! Even with bug deletion enabled, why would you want to delete bugs just because they used a field value you are deleting?

OK, here's a new version. I made some changes in this version: + You can no longer delete bugs using this interface. As joel pointed out, that was just silly. :-) + The "descriptions" of the fields are now localizeable (it uses field-descs.html.tmpl instead of hard-coding them into the perlscript). + I fixed some really silly logic in useful-links.html.tmpl and moved the Field Values link into a more logical place. The silliness that I fixed isn't directly related to this patch, but I would have had to perpetuate it otherwise, and I didn't want to do that.

Oops. I somehow regressed my CGI.pl removal. I've fixed that in this version.

OK. :-) I also realized that there was now dead code in deleted.html.tmpl, and I added a nice link to confirm-delete.html.tmpl for when there are still bugs that have to be dealt with before you can delete the value.

Comment on attachment 174574 [details] [diff] [review] v2.2 (requires bug 17453) (use -p1) fails runtest due to unfiltered directives and a bugwords check. Both should be simple fixes. Also, when renaming a value, claims that "Nothing Changed" even though it does do the change properly.

OK, here's the new version. I fixed your comments above; they were just small fixes, you were right. :-)

http://landfill.bugzilla.org/bz281876/editvalues.cgi has the latest version now, to make testing easier.

Comment on attachment 175220 [details] [diff] [review] v3 (requires bug 17453) (use -p1) r=joel land with bug 17453

RCS file: /cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v done Checking in editvalues.cgi; /cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v <-- editvalues.cgi initial revision: 1.1 done Checking in template/en/default/admin/table.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/table.html.tmpl,v <-- table.html.tmpl new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/confirm-delete.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/confirm-delete.html.tmpl,v <-- confirm-delete.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/create.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl,v <-- create.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/created.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/created.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/created.html.tmpl,v <-- created.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/deleted.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/deleted.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/deleted.html.tmpl,v <-- deleted.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl,v <-- edit.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/footer.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/footer.html.tmpl,v <-- footer.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/list.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/list.html.tmpl,v <-- list.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/select-field.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/select-field.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/select-field.html.tmpl,v <-- select-field.html.tmpl initial revision: 1.1 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/updated.html.tmpl,v done Checking in template/en/default/admin/fieldvalues/updated.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/updated.html.tmpl,v <-- updated.html.tmpl initial revision: 1.1 done Checking in template/en/default/global/useful-links.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v <-- useful-links.html.tmpl new revision: 1.34; previous revision: 1.33 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.96; previous revision: 1.95 done

Two comments: - I will remove the comment about resolutions in 2.23.3 on branches. - I will replace "editcomponents" by "admin" on tip. In other words, I plan to do these changes on checkin so that I don't have to commit one doc patch per branch.

Comment on attachment 246092 [details] [diff] [review] documentation patch, v1 + <section id="edit-values-list"> + Editing legal values requires ... -> require wrong indent: + <para> + You can add as ... + You can also ... + are respected: + </listitem> + + <listitem> + <para> + If any of these ... + The only way to ... + and to set another ... + </para>

tip: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 1.65; previous revision: 1.64 done 2.22.1: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 1.55.2.6; previous revision: 1.55.2.5 done 2.20.3: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 1.50.2.9; previous revision: 1.50.2.8 done