Instead of being a global variable, %classifications should come out of a subroutine in Bugzilla::Classification (which is a new module).

OK, instead, let's just get rid of them and use methods from the new Bugzilla::Classification instead.

OK, let's just do one variable at a time, it's easiest that way. It's really, really easy to eliminate classdesc at this point, so I'm going to do that.

Apparently only enter_bug.cgi was using classdesc, so this patch is nice and small. I've tested it with useclassification on and off, and it works both ways.

Comment on attachment 198641 [details] [diff] [review] v1 >Index: enter_bug.cgi >=================================================================== >@@ -76,7 +77,9 @@ > > if ( ! Param('useclassification') ) { > # just pick the default one >- $cgi->param(-name => 'classification', -value => (keys %::classdesc)[0]); >+ my $default_classification = new Bugzilla::Classification( >+ Bugzilla::Product::DEFAULT_CLASSIFICATION_ID); >+ $cgi->param(-name => 'classification', -value => $default_classification->name); Nit: Is there any reason why this shouldn't just set classification param to __all? That way there's no unnecessary DB access. Code already shows all products regardles of classification if useclassification is not defined. Otherwise this seems to work, r=wicked. I also tested with a line $cgi->param(-name => 'classification', -value => '__all'); so that should work too. You can carry forward my r+ if you just change that line (and comment) to fix my nit.

I think I'd like to leave it as it is for now, and then when we get around to removing the "useclassification" param, we can get rid of that line, also.

Comment on attachment 198641 [details] [diff] [review] v1 bitrotten!

OK, because I hit bitrot in the area wicked commented on, I used his fix as the simplest solution. This also allowed me to remove the "use Bugzilla::Product" and "use Bugzilla::Classification" from enter_bug.cgi.

Checking in enter_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi new revision: 1.121; previous revision: 1.120 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.341; previous revision: 1.340 done