There are actually quite a few CGI scripts that use globals.pl or CGI.pl and don't need them, anymore. There might even be some modules where that's the case, too. These scripts should have these require statements removed.

Taking! globals.pl now only contains some remaining 'use Bugzilla::Foo;'. All I have to do is to move the useful ones in the appropriate scripts. And create a :localconfig tag in Config.pm to remove "do $localconfig;" too.

globals.pl no longer exists. I had to create a new :localconfig tag in Config.pm which includes among others $webservergroup, required by testserver.pl, as well as $cvsdiff & friends for attachment.cgi. I didn't remove the :locations tag from Config.pm yet as some Bugzilla/*.pm still use it. This will be removed in a separate bug (which is already open). contrib/bugzilla_email_append.pl contained several tabs which have been automatically converted to spaces by my text editor. That's the reason these lines appear in this patch. Let's remove these tabs here. I tested my patch a bit by visiting most (all?) pages, and I found no problem. Bye bye globals.pl!

Comment on attachment 226352 [details] [diff] [review] patch, v1 Looks good to me! :-)

Checking in attachment.cgi; /cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v <-- attachment.cgi new revision: 1.113; previous revision: 1.112 done Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.335; previous revision: 1.334 done Checking in chart.cgi; /cvsroot/mozilla/webtools/bugzilla/chart.cgi,v <-- chart.cgi new revision: 1.18; previous revision: 1.17 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.496; previous revision: 1.495 done Checking in colchange.cgi; /cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v <-- colchange.cgi new revision: 1.54; previous revision: 1.53 done Checking in collectstats.pl; /cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v <-- collectstats.pl new revision: 1.52; previous revision: 1.51 done Checking in config.cgi; /cvsroot/mozilla/webtools/bugzilla/config.cgi,v <-- config.cgi new revision: 1.21; previous revision: 1.20 done Checking in createaccount.cgi; /cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v <-- createaccount.cgi new revision: 1.49; previous revision: 1.48 done Checking in customfield.pl; /cvsroot/mozilla/webtools/bugzilla/customfield.pl,v <-- customfield.pl new revision: 1.5; previous revision: 1.4 done Checking in describecomponents.cgi; /cvsroot/mozilla/webtools/bugzilla/describecomponents.cgi,v <-- describecomponents.cgi new revision: 1.36; previous revision: 1.35 done Checking in describekeywords.cgi; /cvsroot/mozilla/webtools/bugzilla/describekeywords.cgi,v <-- describekeywords.cgi new revision: 1.18; previous revision: 1.17 done Checking in duplicates.cgi; /cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v <-- duplicates.cgi new revision: 1.56; previous revision: 1.55 done Checking in editclassifications.cgi; /cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v <-- editclassifications.cgi new revision: 1.20; previous revision: 1.19 done Checking in editcomponents.cgi; /cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v <-- editcomponents.cgi new revision: 1.73; previous revision: 1.72 done Checking in editflagtypes.cgi; /cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v <-- editflagtypes.cgi new revision: 1.39; previous revision: 1.38 done Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.73; previous revision: 1.72 done Checking in editkeywords.cgi; /cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v <-- editkeywords.cgi new revision: 1.38; previous revision: 1.37 done Checking in editmilestones.cgi; /cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v <-- editmilestones.cgi new revision: 1.54; previous revision: 1.53 done Checking in editparams.cgi; /cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v <-- editparams.cgi new revision: 1.36; previous revision: 1.35 done Checking in editproducts.cgi; /cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v <-- editproducts.cgi new revision: 1.125; previous revision: 1.124 done Checking in editsettings.cgi; /cvsroot/mozilla/webtools/bugzilla/editsettings.cgi,v <-- editsettings.cgi new revision: 1.7; previous revision: 1.6 done Checking in editusers.cgi; /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v <-- editusers.cgi new revision: 1.122; previous revision: 1.121 done Checking in editvalues.cgi; /cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v <-- editvalues.cgi new revision: 1.11; previous revision: 1.10 done Checking in editversions.cgi; /cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v <-- editversions.cgi new revision: 1.50; previous revision: 1.49 done Checking in editwhines.cgi; /cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v <-- editwhines.cgi new revision: 1.15; previous revision: 1.14 done Checking in enter_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi new revision: 1.137; previous revision: 1.136 done Removing globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: delete; previous revision: 1.374 done Checking in importxml.pl; /cvsroot/mozilla/webtools/bugzilla/importxml.pl,v <-- importxml.pl new revision: 1.58; previous revision: 1.57 done Checking in index.cgi; /cvsroot/mozilla/webtools/bugzilla/index.cgi,v <-- index.cgi new revision: 1.20; previous revision: 1.19 done Checking in page.cgi; /cvsroot/mozilla/webtools/bugzilla/page.cgi,v <-- page.cgi new revision: 1.19; previous revision: 1.18 done Checking in post_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi new revision: 1.150; previous revision: 1.149 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.329; previous revision: 1.328 done Checking in query.cgi; /cvsroot/mozilla/webtools/bugzilla/query.cgi,v <-- query.cgi new revision: 1.165; previous revision: 1.164 done Checking in quips.cgi; /cvsroot/mozilla/webtools/bugzilla/quips.cgi,v <-- quips.cgi new revision: 1.34; previous revision: 1.33 done Checking in relogin.cgi; /cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v <-- relogin.cgi new revision: 1.37; previous revision: 1.36 done Checking in report.cgi; /cvsroot/mozilla/webtools/bugzilla/report.cgi,v <-- report.cgi new revision: 1.39; previous revision: 1.38 done Checking in reports.cgi; /cvsroot/mozilla/webtools/bugzilla/reports.cgi,v <-- reports.cgi new revision: 1.84; previous revision: 1.83 done Checking in request.cgi; /cvsroot/mozilla/webtools/bugzilla/request.cgi,v <-- request.cgi new revision: 1.33; previous revision: 1.32 done Checking in sanitycheck.cgi; /cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v <-- sanitycheck.cgi new revision: 1.116; previous revision: 1.115 done Checking in show_activity.cgi; /cvsroot/mozilla/webtools/bugzilla/show_activity.cgi,v <-- show_activity.cgi new revision: 1.22; previous revision: 1.21 done Checking in show_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/show_bug.cgi,v <-- show_bug.cgi new revision: 1.44; previous revision: 1.43 done Checking in showdependencygraph.cgi; /cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v <-- showdependencygraph.cgi new revision: 1.50; previous revision: 1.49 done Checking in showdependencytree.cgi; /cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v <-- showdependencytree.cgi new revision: 1.45; previous revision: 1.44 done Checking in sidebar.cgi; /cvsroot/mozilla/webtools/bugzilla/sidebar.cgi,v <-- sidebar.cgi new revision: 1.18; previous revision: 1.17 done Checking in summarize_time.cgi; /cvsroot/mozilla/webtools/bugzilla/summarize_time.cgi,v <-- summarize_time.cgi new revision: 1.18; previous revision: 1.17 done Checking in testserver.pl; /cvsroot/mozilla/webtools/bugzilla/testserver.pl,v <-- testserver.pl new revision: 1.12; previous revision: 1.11 done Checking in token.cgi; /cvsroot/mozilla/webtools/bugzilla/token.cgi,v <-- token.cgi new revision: 1.43; previous revision: 1.42 done Checking in userprefs.cgi; /cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v <-- userprefs.cgi new revision: 1.99; previous revision: 1.98 done Checking in votes.cgi; /cvsroot/mozilla/webtools/bugzilla/votes.cgi,v <-- votes.cgi new revision: 1.40; previous revision: 1.39 done Checking in whine.pl; /cvsroot/mozilla/webtools/bugzilla/whine.pl,v <-- whine.pl new revision: 1.27; previous revision: 1.26 done Checking in whineatnews.pl; /cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v <-- whineatnews.pl new revision: 1.24; previous revision: 1.23 done Checking in Bugzilla/Attachment.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v <-- Attachment.pm new revision: 1.34; previous revision: 1.33 done Checking in Bugzilla/Config.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v <-- Config.pm new revision: 1.59; previous revision: 1.58 done Checking in Bugzilla/Token.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v <-- Token.pm new revision: 1.43; previous revision: 1.42 done Checking in contrib/BugzillaEmail.pm; /cvsroot/mozilla/webtools/bugzilla/contrib/BugzillaEmail.pm,v <-- BugzillaEmail.pm new revision: 1.6; previous revision: 1.5 done Checking in contrib/bug_email.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v <-- bug_email.pl new revision: 1.42; previous revision: 1.41 done Checking in contrib/bugzilla_email_append.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/bugzilla_email_append.pl,v <-- bugzilla_email_append.pl new revision: 1.12; previous revision: 1.11 done Checking in contrib/gnats2bz.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/gnats2bz.pl,v <-- gnats2bz.pl new revision: 1.7; previous revision: 1.6 done Checking in contrib/sendbugmail.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/sendbugmail.pl,v <-- sendbugmail.pl new revision: 1.5; previous revision: 1.4 done Checking in contrib/sendunsentbugmail.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/sendunsentbugmail.pl,v <-- sendunsentbugmail.pl new revision: 1.9; previous revision: 1.8 done Checking in contrib/syncLDAP.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/syncLDAP.pl,v <-- syncLDAP.pl new revision: 1.6; previous revision: 1.5 done Checking in t/004template.t; /cvsroot/mozilla/webtools/bugzilla/t/004template.t,v <-- 004template.t new revision: 1.38; previous revision: 1.37 done