Closed
Bug 282623
Opened 20 years ago
Closed 18 years ago
Remove globals.pl from checksetup
Categories
(Bugzilla :: Installation & Upgrading, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
checksetup no longer requires globals.pl, now that Crypt() has been moved into a
module.
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•19 years ago
|
Target Milestone: --- → Bugzilla 2.22
|
||
Comment 1•19 years ago
|
||
The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.
Target Milestone: Bugzilla 2.22 → Bugzilla 2.24
|
|
Assignee | |
Comment 2•18 years ago
|
||
Okay, here it is. I scanned the whole file to make sure that I didn't miss any imports. I also made a few tiny cosmetic changes while I was scanning the file.
Attachment #226299 -
Flags: review?(LpSolit)
|
|
||
Comment 3•18 years ago
|
||
Comment on attachment 226299 [details] [diff] [review]
v1
Please also remove or update the comment in the --DATA-- section starting with:
# The |require "globals.pl"| above ends up creating a template object with...
Else this looks good. And checksetup.pl doesn't crash with this patch applied. :) r=LpSolit
Attachment #226299 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
|
||
Updated•18 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl
new revision: 1.495; previous revision: 1.494
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•