Closed Bug 288954 Opened 20 years ago Closed 19 years ago

nsID claims it is frozen, but exports C++ symbols

Categories

(Core Graveyard :: Embedding: APIs, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta4

People

(Reporter: benjamin, Assigned: benjamin)

References

()

Details

(Whiteboard: has patch with approval, needs cvsmove)

Attachments

(2 files)

nsID claims it is frozen. This is certainly correct for the struct layout, but I'm not sure whether it means we nsID::Parse and nsID::ToString, which are dllexports. If we *did* freeze them, we need to expose them from xpcom.dll and not just xpcom_core.dll. In any case, I would like to make both of these frozen C exports NS_ParseID and NS_IDToString (and add inline wrappers for existing callers).
Marking blocking 1.8 at least until we the frozen-API issues are sorted out.
Flags: blocking-aviary1.1+
No, nsID::Parse and nsID::ToString are not frozen. The exports have mangled names, so they are not in any way ready to be frozen. I agree, that we should expose those APIs.
Status: NEW → ASSIGNED
Flags: blocking-aviary1.1+ → blocking1.8b4+
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta4
This simply moves the impl to the glue, instead of exposing it via a frozen export which I believe is unnecesary. This also needs cvsmoves which I will attach separately.
Attachment #190145 - Flags: review?(darin)
Comment on attachment 190145 [details] [diff] [review] Move nsID symbols to the glue, rev. 1 nice! r=darin
Attachment #190145 - Flags: review?(darin) → review+
Attached file Move nsID.h/cpp to xpcom/glue, rev. 1 (deleted) —
Attachment #190161 - Flags: review?(darin)
Attachment #190145 - Flags: approval1.8b4?
Attachment #190161 - Flags: review?(darin) → review+
Comment on attachment 190145 [details] [diff] [review] Move nsID symbols to the glue, rev. 1 a=shaver
Attachment #190145 - Flags: approval1.8b4? → approval1.8b4+
Justdave/shaver, can one of you do the cvsmoves?
Blocks: branching1.8
Status: ASSIGNED → NEW
Whiteboard: has patch with approval, needs cvsmove
Reassigning to Dave for cvsmoves, please assign back to me once those are complete.
Assignee: benjamin → justdave
cvsmove completed, give it about 5 min for cvs-mirror to pick it up, then please verify.
Assignee: justdave → benjamin
Fixed on trunk for 1.8b4. Thank you Dave.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: