Closed
Bug 289448
Opened 20 years ago
Closed 20 years ago
Remove locale repackaging step
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird1.1
People
(Reporter: benjamin, Assigned: benjamin)
References
()
Details
Attachments
(2 files)
(deleted),
patch
|
zbraniecki
:
review+
mscott
:
superreview+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Now that we have most of the #ifdefs in place, we can get rid of the
en-US-jar.mn repackaging phase, which will make the final bits of l10n build
automation much simpler.
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #180045 -
Flags: superreview?(mscott)
Attachment #180045 -
Flags: review?(gandalf)
Assignee | ||
Comment 2•20 years ago
|
||
BTW, this is tested with windows installer and zip builds.
Comment 3•20 years ago
|
||
Comment on attachment 180045 [details] [diff] [review]
Don't repackage mail locales, rev. 1
looks good
Attachment #180045 -
Flags: review?(gandalf) → review+
Comment 4•20 years ago
|
||
Comment on attachment 180045 [details] [diff] [review]
Don't repackage mail locales, rev. 1
I wasn't able to finish testing this. My static installer build is having
infinite loop problems updating .deps files again (completely unrelated).
So I won't be able to get to this until next Tuesday.
The code itself looks ok. If you are willing to be on the hook while I'm gone
for any regressions it may introduce then you can check it in. But I need you
to watch my incoming bug list so we can squash regressions and keep an eye on
the testing threads in the mozillazine forums since I won't be around to do so.
Or you can wait until Tuesday and I can do that stuff :)
Attachment #180045 -
Flags: superreview?(mscott) → superreview+
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 180045 [details] [diff] [review]
Don't repackage mail locales, rev. 1
As a packaging change, this is risky, but is needed for l10n work for both
tbird and ffox.
Attachment #180045 -
Flags: approval-aviary1.1a?
Comment 6•20 years ago
|
||
Comment on attachment 180045 [details] [diff] [review]
Don't repackage mail locales, rev. 1
a=asa
Attachment #180045 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Assignee | ||
Comment 7•20 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird1.1
Comment 8•20 years ago
|
||
The windows installer should delete en-US-mail.jar from the installation
directory since we no longer use it.
Attachment #181179 -
Flags: review?(benjamin)
Assignee | ||
Updated•20 years ago
|
Attachment #181179 -
Flags: review?(benjamin) → review+
Comment 9•20 years ago
|
||
the delete patch has been checked in.
You need to log in
before you can comment on or make changes to this bug.
Description
•