Closed
Bug 289461
Opened 20 years ago
Closed 20 years ago
Give make-jars.pl the ability to use the new chrome manifests
Categories
(Toolkit Graveyard :: Build Config, defect, P1)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
text/plain;charset=iso-8859-1
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
make-jars.pl needs the ability to make the new chrome manifests... I want this
for 1.1a, for l10n work Chase and I are doing... the netwerk changes are just a
small sample of what needs to happen.
Assignee | ||
Updated•20 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #179973 -
Flags: first-review?(chase)
Attachment #179973 -
Flags: approval1.8b2?
Updated•20 years ago
|
Attachment #179973 -
Flags: first-review?(chase) → first-review+
Comment 2•20 years ago
|
||
Comment on attachment 179973 [details] [diff] [review]
Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]
a=asa
Attachment #179973 -
Flags: approval1.8b2? → approval1.8b2+
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 179973 [details] [diff] [review]
Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]
I landed the make-jars.pl change without the jar.mn changes, because I'm
conflicting with myself in thunderbird. I will provide additional jar.mn
patches here, and wait for review in bug 289448.
Attachment #179973 -
Attachment description: Add chrome manifest support to make-jars.pl, rev. 1 → Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]
Assignee | ||
Comment 4•20 years ago
|
||
I backed this out because creature was orange, and it fixed the problem. I am
frankly mystified and a little worried, because this is a necessary patch to fix
bug 287262, and I could not reproduce any problems with a local seamonkey build.
Dbaron said that the tinderbox thought that some window was background-color:
transparent and that was causing interesting problems leading to stack overflow.
Can anybody reproduce that problem on a box other than creature?
Comment 5•20 years ago
|
||
This is a diff between dist directories on creature with 3.74 and 3.75 of
make-jars.pl. I unzipped all the jars, so there are no differences in the
contents of the jars (probably only timestamps, maybe compression). The
installed-chrome.txt diffs look like the problem.
Comment 6•20 years ago
|
||
Activestate perl doesn't seem to like the fancy file mode. Opening separately
for read and append seems to work.
Comment 7•20 years ago
|
||
But note that when you open for read, you can't fail if the open fails, because
the file may not be there yet.
Assignee | ||
Comment 8•20 years ago
|
||
Don't use +>>
Assignee | ||
Comment 9•20 years ago
|
||
With nits from Hixie, this works on AS perl.
Assignee | ||
Updated•20 years ago
|
Attachment #179973 -
Attachment is obsolete: true
Attachment #180790 -
Attachment is obsolete: true
Assignee | ||
Comment 10•20 years ago
|
||
The manifest bits of this are now checked-in also, marking FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•