Closed Bug 290678 Opened 20 years ago Closed 17 years ago

Port thunderbird's revised vcard attachment display to suite.

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 4 obsolete files)

In bug 242988, thunderbird revised the html it uses to display vcard attachments this took advantage of the css support, and seems to allow modifications via userContent.css, it also ended up with a nicer display. We should port this code and use it in the suite.
Assignee: bugzilla → mail
Keywords: helpwanted
QA Contact: addressbook
Blocks: TB2SM
This patch lets SeaMonkey use the same code as Thunderbird and removes the previous used code from mimevcrd.cpp I'll post a frontend patch later, have still some things to figure out for that.
Assignee: mail → aqualon
Status: NEW → ASSIGNED
Attachment #308639 - Flags: superreview?
Attachment #308639 - Flags: review?(neil)
Attachment #308639 - Flags: superreview? → superreview?(bienvenu)
Attached file Test mail with vcard (deleted) —
Attached patch Patch for classic theme (obsolete) (deleted) — Splinter Review
This patch ports the according css rules from Thunderbird for the classic theme. I changed the -moz-image-region to background-position, cause -moz-image-region doesn't work for background images. The other problem is, if the "new vcard" icon is enough for this patch or a explicit "add vcard" icon should be made by someone with more knowledge in icon design than myself. Modern has the same problem, that no really appropriate icon is available. But the patch is adequate for testing the changes in mimevcrd.cpp.
Oh, and for testing it, you have to enable View - Display Attachments Inline.
Comment on attachment 308746 [details] [diff] [review] Patch for classic theme >+ background-color: transparent; Transparent isn't a colour. >+ background-image: url("chrome://messenger/skin/addressbook/icons/addressbookicons.png"); This is fine for now. You could file a bug on whether it needs a new image. >+.moz-vcard-badge:hover { What about :active ? >+ background-position: -30px 89px; Why a mixture of +ve and -ve? >+.moz-vcard-badge:focus { >+ -moz-outline: none; >+} This is no good, the link needs to be visibly in the tab order.
Comment on attachment 308639 [details] [diff] [review] Use the same vcard code for SeaMonkey and Thunderbird I'd like to see the CSS checked in at the same time.
Attachment #308639 - Flags: review?(neil) → review+
Attached patch Patch for classic and modern (obsolete) (deleted) — Splinter Review
Updated patch for classic and modern theme. I'll file a separate bug for better icons (at least modern looks quite strange).
Attachment #308746 - Attachment is obsolete: true
Attachment #309826 - Flags: superreview?(neil)
Attachment #309826 - Flags: review?(neil)
Blocks: 423323
Attached patch Patch for classic and modern v2 (obsolete) (deleted) — Splinter Review
Now with the correct modern icon (not that it would look any better, but at least it's the vcard icon ;-))
Attachment #309826 - Attachment is obsolete: true
Attachment #309834 - Flags: superreview?(neil)
Attachment #309834 - Flags: review?(neil)
Attachment #309826 - Flags: superreview?(neil)
Attachment #309826 - Flags: review?(neil)
Comment on attachment 309834 [details] [diff] [review] Patch for classic and modern v2 Oh man, I was too blind to see the correct icons for that case. At least I have found the correct file for modern, the nice icon for classic is in a different file. So new (and hopefully reviewable) patch tomorrow.
Attachment #309834 - Attachment is obsolete: true
Attachment #309834 - Flags: superreview?(neil)
Attachment #309834 - Flags: review?(neil)
Attached patch Patch for classic and modern v3 (obsolete) (deleted) — Splinter Review
Now I believe the theme patch is fine enough to be reviewed (finally ;-)) I had to do some tricks to make modern look ok, cause the icon doesn't have a transparent background. For a screenshot of classic and modern see attachment 309920 [details].
Attachment #309922 - Flags: superreview?(neil)
Attachment #309922 - Flags: review?(neil)
Comment on attachment 309922 [details] [diff] [review] Patch for classic and modern v3 >+ background: url("chrome://communicator/skin/toolbar/prtb-bg-line.gif") repeat-x; This looks mostly nice, but I think we should either a) use the prtb-bg-noline.gif image, or b) use the line colour #8F9FB1 as the border and #D0D8DF as the background colour. >+ color: gray; Although we might then need a different colour here (or just leave it black). >+ -moz-outline: blue dotted 1px; Sorry, I didn't realise, but this needs to be 1px dotted -moz-use-text-color; to pick up the link/active colours from preferences (similarly for classic).
Comment on attachment 309922 [details] [diff] [review] Patch for classic and modern v3 OK, r+sr=me with the noline image in Modern and the tweaked outline styles in both themes.
Attachment #309922 - Flags: superreview?(neil)
Attachment #309922 - Flags: superreview+
Attachment #309922 - Flags: review?(neil)
Attachment #309922 - Flags: review+
Attached patch Patch for classic and modern v4 (deleted) — Splinter Review
Includes the changes from comment #12, taking over r/sr.
Attachment #309922 - Attachment is obsolete: true
Attachment #310204 - Flags: superreview+
Attachment #310204 - Flags: review+
Attachment #308639 - Flags: superreview?(bienvenu) → superreview+
Checking in mailnews/mime/cthandlers/vcard/mimevcrd.cpp; /cvsroot/mozilla/mailnews/mime/cthandlers/vcard/mimevcrd.cpp,v <-- mimevcrd.cpp new revision: 1.103; previous revision: 1.102 done Checking in suite/themes/modern/messenger/messageBody.css; /cvsroot/mozilla/suite/themes/modern/messenger/messageBody.css,v <-- messageB dy.css new revision: 1.16; previous revision: 1.15 done Checking in suite/themes/classic/messenger/messageBody.css; /cvsroot/mozilla/suite/themes/classic/messenger/messageBody.css,v <-- message ody.css new revision: 1.18; previous revision: 1.17 done All checked in.
Keywords: helpwanted
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
No longer blocks: TB2SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: