Closed Bug 291768 Opened 19 years ago Closed 19 years ago

Middle click on proxy icon in location bar should paste URL

Categories

(Firefox :: Address Bar, enhancement, P5)

enhancement

Tracking

()

VERIFIED FIXED
Firefox1.5

People

(Reporter: elmar.ludwig, Assigned: Gavin)

References

Details

Attachments

(1 file, 1 obsolete file)

Traditional behaviour on Unix is to allow pasting a URL into the content area
to load a URL from the current X11 selection. This feature tends to confuse
new users (see the heated discussion in  bug 96972 for example) and conflicts
with autoscroll (which is also activated by middle click in the content area).
Autoscroll has been disabled by default on Unix because of this (bug 216899).

In Mozilla there is another way to load a URL from the X11 selection: middle
click paste on the proxy icon in the location bar. This allows quick paste of
URLs without the need for middlemouse.contentLoadURL and thus can be used even
if autoscroll is enabled. I would like to see this in Firefox as well.

Relevant discussion:

bug 85677 - middle click in content behaviour
bug 111337 - corresponding bug for Mozilla
bug 216899 - ContentLoadURL vs autoscroll

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Assignee: bugs → gavin.sharp
OS: Linux → All
Priority: -- → P5
QA Contact: davidpjames → location.bar
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
Attached patch Patch (obsolete) (deleted) — Splinter Review
Port of the Seamonkey patch. Is this wanted? I could see a situation where
people accidentlally middle click the URL bar and wonder what happened.
Attachment #183694 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Whiteboard: [patch-r?]
Comment on attachment 183694 [details] [diff] [review]
Patch

if middlemouse.paste isn't enabled, middle click shouldn't paste....
Attachment #183694 - Flags: review?(mconnor) → review-
Attachment #183694 - Attachment is obsolete: true
Attached patch Patch v1.1 (deleted) — Splinter Review
updated patch, check for middlemouse.paste before pasting

I'm not quite sure if this test should be in middleMousePaste() or here.
Attachment #186948 - Flags: review?(mconnor)
Comment on attachment 186948 [details] [diff] [review]
Patch v1.1

sorry about the latency here, slipped off my radar, this also fixes bug 302660.
Attachment #186948 - Flags: review?(mconnor)
Attachment #186948 - Flags: review+
Attachment #186948 - Flags: approval1.8b4+
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.465; previous revision: 1.464
done
Checking in browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.266; previous revision: 1.265
done
Blocks: 302660
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?]
Status: RESOLVED → VERIFIED
Blocks: 414345
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: