Closed
Bug 29237
Opened 25 years ago
Closed 25 years ago
Need constistent model for padding on "Containers" an margins on "children" in dialogs
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
WORKSFORME
M18
People
(Reporter: cmanske, Assigned: german)
References
Details
It is impossible to contstruct a complex dialog and have widgets line up correctly or to have consistent inter-widget spacing without extra rules to compensate for default padding and margin values in global.css. Here the important margin and padding data: titledbuttons.push: margin: 0px 3px 2px 4px; html:input[typ=text]" margin: 0px 3px 2px 4px; radio and checkboxes buttons have margin: 3px 5px 3px 3px; margin: 3px 5px 4px 3px; html:select widget (list and combobox) margin 0px; html:label 0px; 0px; 4px; 0px; text 0px; Based on just this, the inconsistent left margins make it difficult to line up widgets in a mixed situation. The padding in "containers" greatly interact with above margins to affect placement of widget inside: - Dialog border still has the bug that forces us to use 0px - Tabpanel: padding: 5px; - HTML:Fieldset: margin: 5px; 5px; 6px; 6px; padding: 5px; - Titledbox (prefered replacement for fieldset) padding: 5px; 5px; 2px; 5px; margin: 2px; Note that many of these problems would be solved if we had a grid layout system that would remove the interaction between individual widget margins and their container's padding, except for the padding inside of each "cell" (a grid-box), allowing us to have minimal consistent padding in all containers, and minimal consistent margins on all internal or child widgets
Yes we need a grid box or 2-D box system. The margins that were attached to the widgets were from before we had a decent box system and were intended to let widgets poistions themselves in an aligned way without developers having to do anything. we should probably remove these hardcoded margins and replace them with a standardized system of hor and vert springs (spacers) using CSS classes that can be used until we have a spring/box grid. Some of this is related to the bug that does not allow us to have any padding on XUL window elements.
Status: NEW → ASSIGNED
Target Milestone: M15
Comment 2•25 years ago
|
||
This does not appear to be an M15 stability checkpoint blocker... so I'm moving this to M16 now.
Target Milestone: M15 → M16
Comment 3•25 years ago
|
||
QA Assigning non-confidential New/Assigned User Interface: Design Feedback bugs to Matthew Thomas (mpt@mailandnews.com). Matthew Thomas is now the QA owner for the User Interface: Design Feedback component. (Bugs that involve UI issues in the Netscape-branded Mozilla browser should continue be QA assigned to elig@netscape.com.)
QA Contact: elig → mpt
Comment 4•25 years ago
|
||
-> jrgm
Component: User Interface: Design Feedback → XP Toolkit/Widgets: XUL
QA Contact: mpt → jrgm
marking worksforme as 'Grid' is now available and should be used for dialog spacing. For examples look at recently redesigned dialogs like "Find"
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•