Closed
Bug 293173
Opened 20 years ago
Closed 19 years ago
Inconsistent handling of prescontext's link handler and container
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bryner)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
brendan
:
approval1.8b3+
|
Details | Diff | Splinter Review |
Before bfcache we have the invariant that the prescontext's link handler and
container are both the same -- the docshell. With bfcache, we null out the
link handler but not the container in cached presentations. We should sort our
exactly what these do and figure out whether we should be nulling both, neither,
or only one and why, then document it.
I also think we should just nuke both members and use the document's container,
but that may confuse printing....
Assignee | ||
Comment 1•19 years ago
|
||
Assignee: nobody → bryner
Status: NEW → ASSIGNED
Attachment #186773 -
Flags: superreview?(dbaron)
Attachment #186773 -
Flags: review?(dbaron)
Comment 2•19 years ago
|
||
Comment on attachment 186773 [details] [diff] [review]
null out the prescontext container
r+sr=dbaron, assuming it doesn't need to be re-set elsewhere :-)
Attachment #186773 -
Flags: superreview?(dbaron)
Attachment #186773 -
Flags: superreview+
Attachment #186773 -
Flags: review?(dbaron)
Attachment #186773 -
Flags: review+
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 186773 [details] [diff] [review]
null out the prescontext container
Requesting approval; only impacts fastback.
Attachment #186773 -
Flags: approval1.8b3?
Comment 4•19 years ago
|
||
Comment on attachment 186773 [details] [diff] [review]
null out the prescontext container
a=me for 1.8b3.
/be
Attachment #186773 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 5•19 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•19 years ago
|
||
I'd still like to see some documentation on what these members are and why just
nulling out both makes sense (in particular why no one ever assumes they're
non-null, which they generally are in normal browsing).
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•