Closed Bug 293173 Opened 20 years ago Closed 20 years ago

Inconsistent handling of prescontext's link handler and container

Categories

(Core :: DOM: Navigation, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bryner)

References

Details

Attachments

(1 file)

Before bfcache we have the invariant that the prescontext's link handler and container are both the same -- the docshell. With bfcache, we null out the link handler but not the container in cached presentations. We should sort our exactly what these do and figure out whether we should be nulling both, neither, or only one and why, then document it. I also think we should just nuke both members and use the document's container, but that may confuse printing....
Blocks: 292956
Assignee: nobody → bryner
Status: NEW → ASSIGNED
Attachment #186773 - Flags: superreview?(dbaron)
Attachment #186773 - Flags: review?(dbaron)
Comment on attachment 186773 [details] [diff] [review] null out the prescontext container r+sr=dbaron, assuming it doesn't need to be re-set elsewhere :-)
Attachment #186773 - Flags: superreview?(dbaron)
Attachment #186773 - Flags: superreview+
Attachment #186773 - Flags: review?(dbaron)
Attachment #186773 - Flags: review+
Comment on attachment 186773 [details] [diff] [review] null out the prescontext container Requesting approval; only impacts fastback.
Attachment #186773 - Flags: approval1.8b3?
Comment on attachment 186773 [details] [diff] [review] null out the prescontext container a=me for 1.8b3. /be
Attachment #186773 - Flags: approval1.8b3? → approval1.8b3+
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Blocks: 297488
I'd still like to see some documentation on what these members are and why just nulling out both makes sense (in particular why no one ever assumes they're non-null, which they generally are in normal browsing).
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: