Closed Bug 297488 Opened 20 years ago Closed 20 years ago

Irregular crashes when closing tab/windows or quiting Camino with bfcache enabled [@ nsChildView::GetParent() + 0x24]

Categories

(Camino Graveyard :: Page Layout, defect, P1)

PowerPC
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.9

People

(Reporter: torben, Assigned: bryner)

References

Details

(Keywords: crash)

Crash Data

Attachments

(3 files)

Camino 2005061108 (v0.9a) With bfcache enabled (browser.sessionhistory.max_viewers, 5) Camino will sometimes crash when I close a tab/window or quit Camino. No crash with bfcache turned off. Just before the crash Camino will hang for some seconds (with the nice spinning bathball).
Attached file Crash Log (deleted) —
Keywords: crash
Summary: Irregular crashes when closing tab/windows or quiting Camino with bfcache enabled (nsChildView::GetParent() + 0x24) → Irregular crashes when closing tab/windows or quiting Camino with bfcache enabled [@ nsChildView::GetParent() + 0x24]
Attached patch needs work (deleted) — Splinter Review
This seems to have been fixed with the checkin from bug 293173. However, I had just found another solution, attaching it here in case this problem should resurface.
Status: NEW → RESOLVED
Closed: 20 years ago
Depends on: 293173
Resolution: --- → FIXED
Attachment #187349 - Attachment description: patch that isn't need anymore → patch that isn't needed anymore
Looks like I spoke too soon, I just had a crash with the latest nightly (TB7122092Q), reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #187349 - Attachment description: patch that isn't needed anymore → patch under testing
Related to bug 227489, perhaps?
Comment on attachment 187349 [details] [diff] [review] needs work Camino just crashed with this patch, back to the drawing table :-( However, it seems like Camino now only crashes when closing windows or quiting, not when closing tabs.
Attachment #187349 - Attachment description: patch under testing → needs work
*** Bug 299872 has been marked as a duplicate of this bug. ***
Assignee: nobody → bryner
Status: REOPENED → NEW
(In reply to comment #5) > However, it seems like Camino now only crashes when closing windows or quiting, > not when closing tabs. > Is that bug 299872?
bryner was trying to look at this last night, but the talkback reports don't have stacks with them and he said he can't repro this himself. i wonder what's going on with the server.
Flags: blocking1.8b3?
Component: History: Session → Page Layout
Flags: blocking1.8b3?
Product: Core → Camino
Target Milestone: --- → Camino0.9
Version: Trunk → unspecified
Priority: -- → P1
(In reply to comment #9) > bryner was trying to look at this last night, but the talkback reports don't > have stacks with them and he said he can't repro this himself. i wonder what's > going on with the server. Some of my TB IDs (not related to this bug) are 7271777, 7042521, 6774484, 6791182, and 6796134; I'm sure when I searched for the older ones of them on talkback-public shortly after they were submitted they had useful stacks. Even the newest/most complete one in the list, 7271777, doesn't list functions and line numbers and that sort of thing. I don't see any recent bugs in Talkback Client or Talkback Server....
(In reply to comment #10) > I don't see any recent bugs in Talkback Client or Talkback Server.... Maybe it's this mis-named bug, bug 297719? Sorry for the off-topic noise.
K I just had this crash, and have seen it happen a couple of times last couple of weeks. I just submitted a talckback report TB7306347G and my crash log looks the same as the one alreaddy attached.
Attached patch patch (deleted) — Splinter Review
I was able to reproduce something like this just going back and forward through some pages on pcworld.com. It appears that what happens is the child widget outlives its parent, and has a dangling pointer. My suggestion is that we do what the carbon code does for this, and null out the parent pointer on all of the children when the parent goes away.
Attachment #188633 - Flags: superreview?(pinkerton)
Attachment #188633 - Flags: review?(joshmoz)
Comment on attachment 188633 [details] [diff] [review] patch applies, builds, runs, no more crashes, looks good
Attachment #188633 - Flags: review?(joshmoz) → review+
Comment on attachment 188633 [details] [diff] [review] patch looks good to me except for the tabs, can you clean those up before checking in? sr=pink. simon, you concur?
Attachment #188633 - Flags: superreview?(pinkerton) → superreview+
Yup, looks good (other than the tabs/spaces).
checked in
Status: NEW → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsChildView::GetParent() + 0x24]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: