Closed
Bug 29890
Opened 25 years ago
Closed 24 years ago
Munging .msf file names should result in unique names
Categories
(MailNews Core :: Backend, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M18
People
(Reporter: huang, Assigned: Bienvenu)
Details
(Keywords: platform-parity, Whiteboard: Fix in hand)
Used 03-01-08/09-M15 commercial builds:
This bug is related to bug#17681 & bug#20324.
Right now, we have \ " \\ [] : ; = , | < characters been munged and they all
been solved to replace these illegal characters with '_'
( > & / still having problem -- there was bug#29581 & bug#22474, may need to
open separate bug for tracking "/"...)
The problem here is:
If I have folders called "b\c" & "b<c", seamonkey will treat them all "b_c",
So if I am trying to copy the messages to folder "b\c", folder "b<c" will got
the same message as folder "b\c" since we do not have unique name for those
munged .msf files.
Comment 2•25 years ago
|
||
cc bienvenu and jefft. Can one of you take this?
Assignee | ||
Comment 3•25 years ago
|
||
I can take it, but I won't get to it until Monday since I'm on vacation thursday
and friday.
Assignee: phil → bienvenu
Reporter | ||
Comment 4•25 years ago
|
||
Problem not occurred on Linux, adding pp on the keywords
Will try on Mac later....
Keywords: pp
Reporter | ||
Comment 6•25 years ago
|
||
Problem not occurred on Mac by using 03-07-08-M15 commercial build.
So this is specific for WinNT problem.
Reporter | ||
Comment 7•25 years ago
|
||
May need to check on Win98, too.
Comment 9•25 years ago
|
||
If this is put off for too long, it could become a transition problem, with
additional code having to be written for users with folders and .msf files using
the old munging algorithm.
Comment 10•25 years ago
|
||
I've forwarded your comments, John, to selmer.
Comment 11•25 years ago
|
||
Hmm. This bug gives the appearance of being about multiple topics. One
possible topic is that some characters are still not being munged. However, we
have a couple other bugs for that. What I _think_ this bug is about is that we
don't force our munging to result in unique names. Is that what this bug is
actually about?
If it is, then I assume you're saying this will create a new migration problem
in the future?
Comment 12•25 years ago
|
||
Yes, this is about not forcing munging to result in unique names. That is
likely to cause a new migration problem in the future.
Comment 13•25 years ago
|
||
Changing summary to reflect what needs to be fixed.
I assume if we did something like use "_" as an escape character and then assign
each of the illegal characters a fixed code we could easily solve this problem.
As an example, ";" could be mapped to "_a_" and "[" to "_b_" and so on (choosing
mappings in some logical way if possible.) Perhaps the trailing "_" is not
necessary? You could also fold redundant escapes into a single escape so ";["
becomes "_ab_" using the above example mapping.
Is this proposal a correct solution? Is there a better one? I hope
implementing this solution would be almost trivial.
Summary: Copying messages problem for munge .msf files → Munging .msf file names should result in unique names
Comment 14•25 years ago
|
||
Either you need a trailing "_" for a "shift out" or you need an escape character
prefix for each fixed character. In either case, you need to escape the escape
character itself.
On NT you need to also escape "." and "~"
"." is a problem because trailing .'s are ignored. "a." and "a" are the same
file. You could get away with only escaping it if it is at the end of a file.
"~" is a problem because it is used in creating 8.3 aliases for long file names.
Comment 15•25 years ago
|
||
I would recommend an escape before each mapped character, with no trailing
escape. The server is more likely to encounter single problem characters than
runs of three or more adjacent problem characters.
Assignee | ||
Updated•24 years ago
|
Keywords: correctness
Assignee | ||
Updated•24 years ago
|
Whiteboard: Fix in hand
Assignee | ||
Comment 17•24 years ago
|
||
OK, fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 18•24 years ago
|
||
May I know this fix in Trunk, Branch or both builds?
Comment 19•24 years ago
|
||
Since this bug isn't marked nsbeta2, it means that it doesn't matter if the fix
is in branch nsbeta2 builds or not. Just verify on the trunk M18 builds.
Thanks Karen!
Reporter | ||
Comment 20•24 years ago
|
||
It seems that copying the messages to folder "c<d" - no problem and there is no
same message displaying in folder "c\d", but there is problem for copying
messages to "c\d" folder, for some reason, it just doesn't display the message
at all when I copying the messages to "c\d".....
I check that there are unique names for the .msf files for c<d (c_d.msf) & c\d
(c_d-1.msf), but I couldn't understand why the copied messages didn't display in
the c\d folder? Need more Investigation.....
Reporter | ||
Comment 21•23 years ago
|
||
This bug has been resolved a while ago.
Verified 01-02-09-trunk build, we do have unique name for those munged .msf
files. Verified when copying different messages to folder "c<d" & "c\d" are
displaying msgs differently. Marking as verified.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•