I am using 2005042806 (v0.8.4) When in an editing window (e.g. Yahoo mail or Apple's discussion formums and even this form right here!) SHIFT-PageUp & SHIFT-PageDown do not work. This is a very useful (and ancient) commonly supported Mac feature to quickly select large sections of text to CUT or COPY. SHIFT-Arrow keys work fine.

I'm guessing your using Camino Moving to correct component

You're right, but command + shift + arrows do work in the mean time. Confirming and targeting for 1.1 as it's not "important" since there is a workaround.

simon, is this just another case where the keybindings need to be included?

Probably, yes. platformHTMLBindings is the place.

This should be fairly simple. Uri, is this something you want to look at?

(In reply to comment #5) > This should be fairly simple. Uri, is this something you want to look at? > I'm not sure it's that simple - we currently don't have a concept of a "page" in the selection/caret code. So I don't think this is just a key binding issue. I'll try to look into it more closely at some point, but I don't expect to get to it any time soon, and in any event, probably not before I get to bug 103422, which is both easier to fix, and IMO more useful. If someone else wants to take this, I won't mind, of course.

(In reply to comment #6) > (In reply to comment #5) > > This should be fairly simple. Uri, is this something you want to look at? > > > > I'm not sure it's that simple - we currently don't have a concept of a "page" > in the selection/caret code. So I don't think this is just a key binding issue. I totally take that back. Sorry. The implementation is there (nsFrameSelection::CommonPageMove), but I never noticed it since there's currently no way to get to it on Mac. So I'll try to look at the binding issues sometime soon.

There are commands for these: http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsGlobalWindowCommands.cpp#100 They need wiring up via platformHTMLBindings.

It turns out this functionality already exists, in editor and textareas only, and is bound to option-shift-up/down. Also, it is known (in nsEditorCommands.cpp) as "cmd_selectPageUp/Down" (not cmd_selectPagePrevious/Next"). Questions: 1. Do we want this feature in the main browser window as well (meaning that we need to implement it to nsGlobalWindowCommands.cpp as well, I guess)? 2. Do we want to keep the existing keybindings in addition to shift-pageUp/Down, or just replace them? 3. Should we remove (currently unused) references to cmd_selectPagePrevious/Next, to avoid confusion with cmd_selectPageUp/Down? 4. What about other platforms?

This patch assumes that the answers to the above questions are: 1. No. 2. Don't keep, per bug 103422 comment #7. It also removes the incorrect un-shifted bindings of option-up/down. 3. No. 4. We don't care.

This code is in Core and will need SR as well. (That was to Ian, not Uri, since I'm sure Uri knows.) :)

Checked in: Checking in content/xbl/builtin/mac/platformHTMLBindings.xml; /cvsroot/mozilla/content/xbl/builtin/mac/platformHTMLBindings.xml,v <-- platformHTMLBindings.xml new revision: 1.19; previous revision: 1.18 done