Closed Bug 299737 Opened 19 years ago Closed 19 years ago

L10N installer displays entity names

Categories

(Toolkit Graveyard :: Build Config, defect, P1)

Product:
Toolkit Graveyard
Component:
Build Config
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta3

People

(Reporter: zbraniecki, Assigned: benjamin)

References

Details

(Keywords: qawanted, Whiteboard: [needed for l10n testing] has patch, has review (Chase))

Attachments

(1 file)

Make install.ini using the perl scripts in addition to preprocessing, rev. 1
(deleted), patch
chase
: first-review+
Details | Diff | Splinter Review 
All nightly l10n windows installer builds display entity names instead of values
like $ProductName$ etc.
Flags: blocking-aviary1.1?
Friggin yuck. Is this a problem with install.ini or config.ini ?
Flags: blocking-aviary1.1? → blocking1.8b4+
*** Bug 298671 has been marked as a duplicate of this bug. ***
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta3
We pass install.it first through the perl preprocessor and then through
makecfgini.pl to create the final install.ini. This matches the en-US build
process now.
Attachment #188535 - Flags: first-review?(chase)
Blocks: 300092
Whiteboard: has patch, needs review (Chase)
Whiteboard: has patch, needs review (Chase) → [needed for l10n testing] has patch, needs review (Chase)
Comment on attachment 188535 [details] [diff] [review]
Make install.ini using the perl scripts in addition to preprocessing, rev. 1

Hold to land until after 1.1alpha2/1.8b3.
Attachment #188535 - Flags: first-review?(chase) → first-review+
Whiteboard: [needed for l10n testing] has patch, needs review (Chase) → [needed for l10n testing] has patch, has review (Chase)
Fixed on trunk. Tomorrow's nightlies ought to work, please let me know if they
don't.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: qawanted
Resolution: --- → FIXED
Blocks: branching1.8
Blocks: 300861
Error is not fixed yet in some locales suck as ko, ja, zh-TW, cs.
The parsed codes of installer.inc are same compared with others.
No longer blocks: 300861
I still see this mistake with ru branch builds - $ProductName$ in Start menu and
on Desktop.
Also in registry - HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\$ProductName$
$UserAgentShort$
Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b4) Gecko/20050816
Firefox/1.0+ ID:2005081618

(In reply to comment #7)
> I still see this mistake with ru branch builds - $ProductName$ in Start menu and
> on Desktop.
> Also in registry - HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\$ProductName$
> $UserAgentShort$
> Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b4) Gecko/20050816
> Firefox/1.0+ ID:2005081618
> 
Oops, sorry. Looks like I posted in wrong bug.
Installer dialog is OK. But icons that created with Win32 installer have names
like $ProductName$ and $ProductName$ (Safe Mode)
I should create separate bug, I guess.
Attachment #188535 - Flags: approval1.8b5?
Attachment #188535 - Flags: approval1.8b5? → approval1.8b5+
Asa, this bug has been fixed on the 1.8 branch for a while now. Is there a
reason you set the approval?+ flags now?
Comment on attachment 188535 [details] [diff] [review]
Make install.ini using the perl scripts in addition to preprocessing, rev. 1

clearing the flag for an already fixed bug, this maay have shown up on one of
our broken search queries the other day.
Attachment #188535 - Flags: approval1.8b5+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: