Closed
Bug 299745
Opened 19 years ago
Closed 19 years ago
Updating Firefox window / progress bar doesn't maintain look of software update UI
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: beltzner, Assigned: beltzner)
References
()
Details
(Whiteboard: [1.8 Branch ETA 8/5])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8b4+
|
Details | Diff | Splinter Review |
After finding an update, downloading it and restarting the browser, a small "Applying Updates" window is presented. The title and lack of text linking it back to the "Software Updates" window makes it appear to be part of a seperate process. Asa's taken some screencaps to illustrate (see URL field) bsmedberg noted in #developers that changing the window's size might be very diificult: 12:21 < bsmedberg> Asa: it's coded as a native win32 app, the window decorations must be different, the XUL sizing depends on l10n while the updater window sizing does not Suggestions: - rename the window to "Software Update" - add a banner that says "Applying Updates" - keep existing text above progress meter
Updated•19 years ago
|
Assignee: nobody → darin
Comment 1•19 years ago
|
||
This has L10N implications so we need to get it for 1.8b4.
Flags: blocking1.8b4+
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.1
Comment 2•19 years ago
|
||
I'm not convinced that anything needs to change here. What is the usability problem exactly? The current dialog title says "Updating Firefox", and that seems pretty descriptive to me. Is it really a surprise to the user that a progress meter would appear after they tell Firefox to restart and apply updates now?
Comment 3•19 years ago
|
||
Adapting this UI is a very complicated process, and so making it mirror XUL UI which can change more frequently may not be the best idea. We have tried to make the text in this UI as simple and descriptive as possible. If you have improvements to the text (Deb?) they would be welcome, but I'm not sure what the value is in having Darin spend a lot of time redoing this dialog unless there's a pressing usability need. Is there one?
Assignee | ||
Comment 4•19 years ago
|
||
Certainly not an urgent usability need, no. However, I think that some changes to the text for friendliness and consistency could help: .-----------------------------------------------------. | Software Update | |-----------------------------------------------------| | Firefox is installing your updates ... | | | | [XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX ] | | | '-----------------------------------------------------'
Comment 5•19 years ago
|
||
Can you describe why that dialog is both friendlier and more consistent? I think it's important to stress to the user that they should not interrupt the process. Maybe that is getting too technical for most folks, but it seems critical since interrupting it would probably ruin their firefox install. I wouldn't want someone to naively restart their computer while we are applying an update for instance.
Comment 6•19 years ago
|
||
When a user starts up his browser, he sees a strange window pop up that doesn't look anything like the wizard he was using when he shut down. It doesn't have a firefox icon so in the taskbar it gets a generic windows application icon. It's scary and looks like it might be some other program, possibly some spyware or something.
Comment 7•19 years ago
|
||
> When a user starts up his browser, he sees a strange window pop up that
> doesn't look anything like the wizard he was using when he shut down. It
> doesn't have a firefox icon so in the taskbar it gets a generic windows
> application icon. It's scary and looks like it might be some other program,
> possibly some spyware or something.
OK, so you are talking about the case where the user did not press the "Restart
Firefox now and apply updates" button, right? You mean the case where they
pressed the "Later" button and then shutdown their browser, right?
Do you believe that using the Firefox icon would provide most of the benefit in
this situation? Do you believe that the text of the dialog "Updating Firefox"
is not clear?
Comment 8•19 years ago
|
||
I'm actually talking about either case. In both cases, I thikn it would be beneficial (though maybe not worth the time you have available considering more pressing bugs) to have something that felt like it was a part of the Firefox update process he started from the browser.
Comment 9•19 years ago
|
||
> I'm actually talking about either case. In both cases, I thikn it would be
> beneficial (though maybe not worth the time you have available considering more
> pressing bugs) to have something that felt like it was a part of the Firefox
> update process he started from the browser.
I can understand that goal. What about the questions I asked? Would inserting
the Firefox icon be sufficient to mostly achieve that goal? (I'm not sure how
to show the icon on Linux FWIW.)
Comment 10•19 years ago
|
||
Actually, Darin, I don't know. I believe the icon would make things better, for sure (even if it was windows only). On wording, I'm not sure what's best, and I understand the desire to tell people not to interrupt the install.
Assignee | ||
Comment 11•19 years ago
|
||
(In reply to comment #5) > I think it's important to stress to the user that they should not interrupt the > process. Maybe that is getting too technical for most folks, but it seems How would they interrupt the install? The window has no close button, meaning they'd have to manually kill the process, which is a pretty advanced thing to be doing. While I understand your desire, it seems to make the dialog a lot scarier than it has to be. What we should be conveying to the user is: 1. This is part of the software update process, and it's normal. 2. You're waiting to start firefox because there's some installation operations going on.
Comment 12•19 years ago
|
||
(In reply to comment #9) > (I'm not sure how > to show the icon on Linux FWIW.) http://developer.gnome.org/doc/API/2.0/gdk/gdk-Windows.html#gdk-window-set-icon-list ? (with http://developer.gnome.org/doc/API/2.0/gdk-pixbuf/gdk-pixbuf-file-loading.html#gdk-pixbuf-new-from-file)
Assignee | ||
Comment 13•19 years ago
|
||
(In reply to comment #5) > Can you describe why that dialog is both friendlier and more consistent? Oops, sorry Darin. Forgot to answer your original question. Using the window title of "Software Update" is what makes it more consistent, linking it back to the window title that is used elsewhere in the software update process. The text is friendlier in that it's offering an explanation of the delay rather than issuing a command to the user to not do something that I'd predict very few users would ever think of doing in the first place ("do not interrupt this process")
Comment 14•19 years ago
|
||
> How would they interrupt the install? See comment #5
Assignee | ||
Comment 15•19 years ago
|
||
I think that's a pretty edge situation, since someone will have had to either: 1) clicked "restart now" purposefully to apply updates, or 2) clicked on the firefox icon to launch the browser in order to get to the point where updates are being applied, both of which aren't actions which are likely to occur just before someone shuts down their computer. Is there any way that our thread can respond to shutdown requests by popping a dialog that warns users not to interrupt the process? I think that'd be the best way (ie: only tell them not to interrupt if they try to interrupt), but if it's impossible, then although edge, I think yeah, the concern has merit. Drat. :)
Comment 16•19 years ago
|
||
Yeah, it's an edge case to be sure. Maybe I worry too much about that case :-/
Updated•19 years ago
|
Whiteboard: [1.8 Branch ETA 8/5]
Updated•19 years ago
|
Blocks: branching1.8
Updated•19 years ago
|
No longer blocks: branching1.8
Updated•19 years ago
|
Assignee: darin → mconnor
Status: ASSIGNED → NEW
Comment 17•19 years ago
|
||
Attachment #192402 -
Flags: review?(mike)
Attachment #192402 -
Flags: approval1.8b4?
Comment 18•19 years ago
|
||
Comment on attachment 192402 [details] [diff] [review] beltzner's wording tweak Don't forget to update the text for Thunderbird as well.
Updated•19 years ago
|
Blocks: branching1.8
Comment 19•19 years ago
|
||
(In reply to comment #4) > Certainly not an urgent usability need, no. However, I think that some changes > to the text for friendliness and consistency could help: How about "Updating Firefox" across the board?
Comment 20•19 years ago
|
||
(In reply to comment #19) > (In reply to comment #4) > > Certainly not an urgent usability need, no. However, I think that some changes > > to the text for friendliness and consistency could help: > > > How about "Updating Firefox" across the board? ...and in the last one, have it say "Please wait while update process completes." This is actually a pretty simple wording change, but is good enough for the shorter term
Assignee | ||
Comment 21•19 years ago
|
||
Comment on attachment 192402 [details] [diff] [review] beltzner's wording tweak Posting an additional patch that changes the string for thunderbird as well (thanks, darin)
Attachment #192402 -
Flags: review?(mike) → review-
Assignee | ||
Comment 22•19 years ago
|
||
Attachment #192402 -
Attachment is obsolete: true
Attachment #192430 -
Flags: review?(mconnor)
Attachment #192430 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #192402 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #192430 -
Flags: review?(mconnor)
Attachment #192430 -
Flags: review+
Attachment #192430 -
Flags: approval1.8b4?
Attachment #192430 -
Flags: approval1.8b4+
Updated•19 years ago
|
Assignee: mconnor → mike
Comment 23•19 years ago
|
||
Marking this fixed, let's spin off discussion for the 2.0 work to a new bug.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•