Pavel Franc - Mozilla.cz Assignee
	Description • 19 years ago

This issue was reported in n.p.m.l10n. 

* mozilla/mail/locales/en-US/chrome/messenger/am-smime.dtd
 <!ENTITY managecerts.label      "Certificates">
 <!ENTITY managecerts.button     "View Certificates">
 <!ENTITY managecerts.accesskey  "V">

* mozilla/browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd
 <!ENTITY treecol.lastvisit.label        "Last Visited">
 <!ENTITY treecol.lastvisit.accesskey    "b">

	u60234
	Comment 2 • 19 years ago

I think those treecol.xxx.accesskey's are bogus anyway and they should probably
be removed. Accesskey for treecol is not supported, see bug 182414.

And if you open the column header menu by clicking on the icon, the items are
selected with the first letter in their name, regardless of assigned accesskey.

	Scott MacGregor
	Comment 3 • 19 years ago

Comment on attachment 190393 [details] [diff] [review]
use correct label/acceskey assignment

I don't understand the change here. It looks like you just renamed three
entities in am-smime.xul to new names with the same string value.

	Pavel Franc - Mozilla.cz Assignee
	Comment 4 • 19 years ago

> I don't understand the change here. It looks like you just renamed three
> entities in am-smime.xul to new names with the same string value. 

It is a common practice to use xxx.accesskey as an entity name for an entity
named xxx.label, and localization tools (mozilla translator, mo2po/po2mo ...)
use this to assigne the accesskey to the string and check the validity of such
accesskey.

Here we have the pair managecerts.button/managecerts.accesskey. Usually this is
no problem because the l10n utility consider it as two unrelated strings and it
is up to the localizer to pair them by hand. But here we have also the entity
managecerts.label, so the l10n utily consider it as a pair
managecerts.label/managecerts.accesskey and report an error everytime you use it.

	Scott MacGregor
	Comment 5 • 19 years ago

Comment on attachment 190393 [details] [diff] [review]
use correct label/acceskey assignment

ok, thank you for taking the time to explain why the names had to change.

	Chris Beard
	Comment 6 • 19 years ago

mscott, could you check this in?

thanks
cb

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 7 • 19 years ago

Comment on attachment 190393 [details] [diff] [review]
use correct label/acceskey assignment

>Index: browser/locales/en-US/chrome/browser/bookmarks/bookmarks.dtd

>-<!ENTITY treecol.lastvisit.accesskey    "b">
>+<!ENTITY treecol.lastvisit.accesskey    "v">

I was going to check this in, but noticed that "v" is already used as an
accesskey in that dialog. Since these keys don't really work, per comment 2,
I've left that part out.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 8 • 19 years ago

Checking in extensions/smime/content/am-smime.xul;
/cvsroot/mozilla/mail/extensions/smime/content/am-smime.xul,v  <--  am-smime.xul
new revision: 1.7; previous revision: 1.6
done
Checking in locales/en-US/chrome/messenger/am-smime.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-smime.dtd,v  <-- 
am-smime.dtd
new revision: 1.6; previous revision: 1.5
done