Closed
Bug 302039
Opened 20 years ago
Closed 19 years ago
Locked profile dialog needs a better message
Categories
(Toolkit :: Startup and Profile System, defect)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: mconnor, Assigned: benjamin)
References
Details
(Whiteboard: [affects l10n] has patch with review, needs approval)
Attachments
(1 file)
(deleted),
patch
|
beltzner
:
first-review+
mconnor
:
second-review+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Spun off from bug 286355 comment 15
We need a better message so that users can do something useful when their
profile is locked.
beltzner's suggestion:
Firefox is already running, but not responding. To open a new window, you
must first close all Firefox processes, or restart your system.
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #190414 -
Flags: second-review?(mconnor)
Attachment #190414 -
Flags: first-review?(mike)
Assignee | ||
Updated•20 years ago
|
Blocks: branching1.8
Flags: blocking1.8b4+
Whiteboard: [affects l10n] has patch needs review beltzner+mconnor
Reporter | ||
Updated•20 years ago
|
Attachment #190414 -
Flags: second-review?(mconnor) → second-review+
Updated•20 years ago
|
Attachment #190414 -
Flags: first-review?(mike) → first-review+
Assignee | ||
Updated•20 years ago
|
Attachment #190414 -
Flags: approval1.8b4?
Assignee | ||
Updated•20 years ago
|
Whiteboard: [affects l10n] has patch needs review beltzner+mconnor → [affects l10n] has patch needs with review
Assignee | ||
Updated•19 years ago
|
Whiteboard: [affects l10n] has patch needs with review → [affects l10n] has patch with review, needs approval
Updated•19 years ago
|
Attachment #190414 -
Flags: approval1.8b4?
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 190414 [details] [diff] [review]
Separate the unlocker and no-unlocker case for better verbiage, rev. 1
asa, did you mean to clear my approval request?
Attachment #190414 -
Flags: approval1.8b4?
Comment 3•19 years ago
|
||
Comment on attachment 190414 [details] [diff] [review]
Separate the unlocker and no-unlocker case for better verbiage, rev. 1
no, I meant to plus it. sorry 'bout that.
Attachment #190414 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 4•19 years ago
|
||
Fixed on trunk for 1.8b4
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
Comment 5•19 years ago
|
||
Shouldn't those |static const PRUnichar|s be null-terminated?
Comment 6•19 years ago
|
||
Now I don't see any message when I have trunk nightly A running and try to run
trunk nightly B. Trunk nightly B bounces in the dock once and nothing else
happens. In nightlies from a few days ago (before this change), I'd get the "is
already running, but is not responding" message. Was that an intentional change?
Assignee | ||
Comment 7•19 years ago
|
||
Yes! they should have been null-terminated, and I actually did that in a
different tree when testing and forgot to do it in my checkin tree. That error
would cause no dialog to appear.
Comment 8•19 years ago
|
||
While you're adding null terminators, how about wrapping long lines in
nsAppRunner.cpp at 80 chars?
Comment 9•19 years ago
|
||
The bustage fix worked. I now see the (new) message after following the steps
in comment 6.
Component: XRE Startup → Startup and Profile System
QA Contact: nobody → startup
You need to log in
before you can comment on or make changes to this bug.
Description
•