Closed Bug 30595 Opened 25 years ago Closed 24 years ago

"Blue" skin: grippy looks like a vertical scrollbar

Categories

(SeaMonkey :: Themes, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: jruderman, Assigned: jag+mozbugs)

References

Details

(Whiteboard: nsbeta3-)

Attachments

(4 files)

The thing used to resize the sidebar (the "grippy") looks like a scrollbar. I've
tried several times to scroll in the sidebar using the grippy.
->jrgm for xptoolkit stuff.
QA Contact: sairuh → jrgm
This is really a UI design issue, no? That grippy can take whatever style is 
requested.
Assignee: evaughan → shuang
Component: Progress Window → User Interface: Design Feedback
QA Contact: jrgm → elig
 Assign it to german for later polish. 
Assignee: shuang → german
We found in usability studies, that once folks closed the sidebar, they had a
hard time finding the control to re-open it. Here's a proposal for a more
visible showing of state, adding arrows to indicate where the splitter will go
once the grippy is pressed.
Here's the XUL that would replace the current splitters section in global.css:
/******* Splitters *******/

splitter {
   min-width: 6px;
   min-height: 6px;
   padding: 0px;
}

splitter[state="dragging"]
{
   background-color: gray;
}

[align="vertical"]>splitter {
	/* a vertical splitter */
    cursor: n-resize;
}

[align="horizontal"]>splitter {
	/* a horizontal splitter */
    cursor: w-resize;
}

grippy{
	margin: 0px;
	border: 1px solid transparent;
	cursor: pointer;
	background-repeat: no-repeat;
	background-position: 50% 50%;
	background-color: #6699CC;
}

grippy:hover{
	border: 1px solid #003366;
	background-color: #6699CC;

}

grippy:active{
	border: 1px solid #003366;
	background-color: #6699CC;
}

[align="vertical"]>splitter grippy {
	/* a horizontal splitter */
	min-width: 65px;
	min-height: 8px;
	max-height: 8px;
}

[align="horizontal"]>splitter grippy {
	/* a horizontal splitter */
	min-width: 8px;
	max-width: 8px;
	min-height: 65px;
}

[align="horizontal"]>splitter[collapse="before"] grippy {
	/* a horizontal splitter collapsing to left, open*/
	background-image: url("chrome://global/skin/grippy-horizontal-before.gif");
}

[align="horizontal"]>splitter[collapse="before"][state="collapsed"] grippy {
	/* a horizontal splitter collapsing to left, closed*/
	background-image: url("chrome://global/skin/grippy-horizontal-after.gif");
}

[align="horizontal"]>splitter[collapse="after"] grippy {
	/* a horizontal splitter collapsing to right, open*/
	background-image: url("chrome://global/skin/grippy-horizontal-after.gif");
}

[align="horizontal"]>splitter[collapse="after"][state="collapsed"] grippy {
	/* a horizontal splitter collapsing to right, closed*/
	background-image: url("chrome://global/skin/grippy-horizontal-before.gif");
}

[align="vertical"]>splitter[collapse="before"] grippy {
	/* a vertical splitter collapsing to top, open*/
	background-image: url("chrome://global/skin/grippy-vertical-before.gif");
}

[align="vertical"]>splitter[collapse="before"][state="collapsed"] grippy {
	/* a vertical splitter collapsing to top, closed*/
	background-image: url("chrome://global/skin/grippy-vertical-after.gif");
}

[align="vertical"]>splitter[collapse="after"] grippy {
	/* a vertical splitter collapsing to bottom, open*/
	background-image: url("chrome://global/skin/grippy-vertical-after.gif");
}

[align="vertical"]>splitter[collapse="after"][state="collapsed"] grippy {
	/* a vertical splitter collapsing to bottom, closed*/
	background-image: url("chrome://global/skin/grippy-vertical-before.gif");
}
/**
 * gray horizontal splitter for pane views
 */
splitter.gray-horizontal-splitter {
	background-color: #CCCCCC;
}

splitter.gray-horizontal-splitter #begincap {
	min-width: 8px;
	max-width: 8px;
	background-image: url("chrome://global/skin/gray-bottomleft.gif");
	background-repeat: no-repeat;
	background-position: 0% 100%;
}

splitter.gray-horizontal-splitter #endcap {
	min-width: 8px;
	max-width: 8px;
}

I will add the images in a zip file shortly as well as a screenhot.

Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached image screenshot of result: more visible grippy (deleted) β€”
re-assigning to Ben for review, possibly check-in if OK.
Assignee: german → ben
Status: ASSIGNED → NEW
Target Milestone: M15
Blocks: 28883
sorry for cluttering up that bug with the patched css for global.css. I meant to
do an attachment.

I found one minor glitch with what I posted before, and have now attached
patched version of both global.css and sidebarOverlay.css that should properly.
Ben, Slamm can you pls take a look? Thanks.

I have tested this on the 2000030708 Win32 build, and it looks good (and much 
better than the previous grippy). It behaves as expected - now if only the 
actual opening and closing worked as well...
not a priority, pushing out as far as possible.
Status: NEW → ASSIGNED
Target Milestone: M15 → M20
QA Assigning non-confidential New/Assigned User Interface: Design Feedback bugs 
to Matthew Thomas (mpt@mailandnews.com).

Matthew Thomas is now the QA owner for the User Interface: Design Feedback 
component. (Bugs that involve UI issues in the Netscape-branded Mozilla browser 
should continue be QA assigned to elig@netscape.com.)
QA Contact: elig → mpt
Keywords: patch
I'll take this one. I have new images to add. I am cleaning up other sidebar 
styles too.
Assignee: ben → slamm
Status: ASSIGNED → NEW
I checked in a fix. The list-style-image for the grippy seems to be broken, so I
used background-image for now.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Ben's new sidebar look does not have an image on the grippy.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
You broke it. You fix it.
Assignee: slamm → ben
Status: REOPENED → NEW
Keywords: patchregression
Component: User Interface: Design Feedback → Sidebar
adding nsbeta2. Need to fix this broken UI.
Keywords: nsbeta2
Putting on [nsbeta2-] radar.  
Whiteboard: [nsbeta2-]
*** Bug 44748 has been marked as a duplicate of this bug. ***
important piece of polish

nsbeta3
Keywords: nsbeta3
nav traige team:
[NEED INFO] is this fixed?  If so, please close the bug.  (If we run into new 
usability issues, we will open a new bug, but lets close this baby.)
Assignee: ben → german
Whiteboard: [nsbeta2-] → [nsbeta2-][NEED INFO]
This was fixed but one of Ben's checkins overrod the proper images. we have the 
updated images, so we should update the grippy to show the arrow heads rather 
than the 4-point ploygon it using now.  Will mark nsbeta3 and this will be fixed 
with the revamp of the modern skin. adding [modern skin] to summary.
Status: NEW → ASSIGNED
Keywords: nsbeta2, regression
Summary: Grippy looks like a vertical scrollbar → Grippy looks like a vertical scrollbar [modern skin]
Whiteboard: [nsbeta2-][NEED INFO] → [fix on hand]
--> Themes
Component: Sidebar → Themes
Keywords: newmod
OS: Windows 98 → All
QA Contact: mpt → pmac
Hardware: PC → All
Summary: Grippy looks like a vertical scrollbar [modern skin] → [Modern] Grippy looks like a vertical scrollbar
Whiteboard: [fix on hand]
Marking nsbeta3- while assigned to german.  Should be reconsidered when assinged 
to an engineer.
Whiteboard: nsbeta3-
German, is this fixed (appears to be with new sidebar graphics)?
This bug is actually about the "blue" skin, not the new "modern" skin.  It just 
didn't get updated after the name switch.
Keywords: newmod
Summary: [Modern] Grippy looks like a vertical scrollbar → "Blue" skin: grippy looks like a vertical scrollbar
The blue skin is not actively maintained by Netscape anymore. If somebody wants
to take this bug and run with go for it. Temp. assigning to Ben since I think he
knows somebody on Mozilla who volunteered to keep blue up-to-date.
Assignee: german → ben
Status: ASSIGNED → NEW
sending to jag, as he has foolishly expressed interest in the Blue skin... ;) 
Assignee: ben → disttsc
Target Milestone: M20 → Future
Blue is dead (see bug 72717)
Marking wontfix
Status: NEW → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → WONTFIX
I'm sure Netscape wouldn't really  mind if someone wanted to keep Blue alive. 
It is checked into an open source project, after all.  Besides, jag owns the
bug, and can do whatever he wants with it.
I say ditch blue, unless someone else wants to try and revive it.

However, I would like to see a light-weight skin replace blue. Any takers?
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: