Closed
Bug 307807
Opened 19 years ago
Closed 13 years ago
Remove unused functions in <nsMsgI18N.*>
Categories
(MailNews Core :: Internationalization, defect)
MailNews Core
Internationalization
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: vhaarr+bmo, Assigned: sgautherie)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Bug 193439 removed the only consumers of nsMsgI18NGetAcceptLanguage.
Patch coming (although I have no idea what to do about
<http://lxr.mozilla.org/mozilla/source/mailnews/base/util/win32.order#247>).
|
Reporter | |
Comment 1•19 years ago
|
||
|
|
Reporter | |
Comment 2•19 years ago
|
||
Comment on attachment 195493 [details] [diff] [review]
version 0.1
[Superseded by patches Bv1 and Cv1]
Since I'm not even sure smontagu is around anymore (?), I'm reassigning review
request to bienvenu.
Attachment #195493 -
Flags: review?(smontagu) → review?(bienvenu)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 195493 [details] [diff] [review]
version 0.1
[Superseded by patches Bv1 and Cv1]
does this need to be removed from win32order.h? Is that file auto-generated? It
seems to be in cvs.
Attachment #195493 -
Flags: superreview?(mscott)
Attachment #195493 -
Flags: review?(bienvenu)
Attachment #195493 -
Flags: review+
|
||
Updated•19 years ago
|
Attachment #195493 -
Flags: superreview?(mscott) → superreview+
|
|
Reporter | |
Comment 4•19 years ago
|
||
Comment on attachment 195493 [details] [diff] [review]
version 0.1
[Superseded by patches Bv1 and Cv1]
bienvenu: Can I trouble you for a checkin?
|
|
Reporter | |
Comment 5•19 years ago
|
||
bienvenu: Can I trouble you for a checkin of attachment 195493 [details] [diff] [review]?
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
|
Assignee | |
Updated•16 years ago
|
Assignee: vhaarr+bmo → sgautherie.bz
Status: ASSIGNED → NEW
Depends on: 52352
Flags: in-testsuite-
QA Contact: mailnews.i18n
Summary: nsMsgI18NGetAcceptLanguage is unused and can be removed. → Remove unused functions in <nsMsgI18N.*>
Target Milestone: --- → mozilla1.9.1a2
|
|
Assignee | |
Comment 6•16 years ago
|
||
Comment on attachment 195493 [details] [diff] [review]
version 0.1
[Superseded by patches Bv1 and Cv1]
So sad when reviewed patches never land :-(
This is now included in bug 52352 patch Bv2 :->
Attachment #195493 -
Attachment description: version 0.1 → version 0.1
[See bug 52352]
Attachment #195493 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080819081634 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)
Per bug 52352 comment 32:
{{
David Bienvenu 2008-08-18 12:14:54 PDT
check if there are any other methods in nsMsgI18n.h that aren't used
}}
Attachment #334427 -
Flags: superreview?(bienvenu)
Attachment #334427 -
Flags: review?(bienvenu)
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → ASSIGNED
|
|
||
Updated•16 years ago
|
Attachment #334427 -
Flags: superreview?(bienvenu)
Attachment #334427 -
Flags: superreview+
Attachment #334427 -
Flags: review?(bienvenu)
Attachment #334427 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•16 years ago
|
Attachment #334427 -
Attachment description: (Bv1) 2 other function removal → (Bv1) 2 other function removal
[Checkin: Comment 8]
|
|
Assignee | |
Comment 9•16 years ago
|
||
Accidentally included a part of bug 52352 patch Bv2 in patch Bv1 here :-(
Luckily, the previous checkin did not brake anything (the way it was) :->
Keeping
{{
bienvenu: review+
bienvenu: superreview+
}}
from both previous patches.
All in all, this ends where it started ;-)
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: Cv1]
|
||
Comment 10•16 years ago
|
||
Checked in, changeset id: 155:9c7836eceb77
Keywords: checkin-needed
Whiteboard: [c-n: Cv1]
|
|
Assignee | |
Updated•16 years ago
|
Attachment #334731 -
Attachment description: (Cv1) |nsMsgI18NGetAcceptLanguage()| (headers) removal → (Cv1) |nsMsgI18NGetAcceptLanguage()| (headers) removal
[Checkin: Comment 10]
|
|
Assignee | |
Updated•16 years ago
|
Attachment #195493 -
Attachment description: version 0.1
[See bug 52352] → version 0.1
[See Bv1 and Cv1]
|
||
Comment 11•13 years ago
|
||
Should this stay open? Both patches checked in.
|
||
Comment 12•13 years ago
|
||
Serge ?
|
|
Assignee | |
Comment 13•13 years ago
|
||
It looks like this is waiting for bug 52352 (ftb).
|
|
Assignee | |
Updated•13 years ago
|
Attachment #195493 -
Attachment description: version 0.1
[See Bv1 and Cv1] → version 0.1
[Superseded by patches Bv1 and Cv1]
|
|
Assignee | |
Comment 14•13 years ago
|
||
(In reply to Vidar Haarr (not reading bugmail) from comment #0)
> I have no idea what to do about
> <http://lxr.mozilla.org/mozilla/source/mailnews/base/util/win32.order#247>).
http://mxr.mozilla.org/mozilla1.8/source/mailnews/base/util/win32.order
Removed by bug 335180.
(In reply to David :Bienvenu from comment #3)
> does this need to be removed from win32order.h? Is that file auto-generated?
> It seems to be in cvs.
You were referring to the same file, weren't you?
You need to log in
before you can comment on or make changes to this bug.
Description
•