Closed
Bug 335180
Opened 19 years ago
Closed 19 years ago
Remove win32.order, mozilla-bin.order, --enable-reorder, and associated code
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I want to remove the order stuff in the tree. Reasons:
- The GCC --enable-reorder option is not useful:
- It only affects the suite binary (i.e. at best, useful for a static seamonkey build)
- mozilla-bin.order uses GCC 2.x name mangling
- win32.order files are only used if the environment variable MOZ_COVERAGE is set.
This is not the case on either the Firefox release tinderbox (http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1145826600.1074.gz&fulltext=1) nor the SeaMonkey one (http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1145823060.12133.gz&fulltext=1)
So clearly nothing uses them, and these files haven't been updated in ages (but should have been, as the functions are changing all the time)
This code was added in bug 65845.
If you can see a reason why this shouldn't be done, please say so :-)
Assignee | ||
Comment 1•19 years ago
|
||
in the interest of a shorter patch, I abbreviated the deletes here
Other than *.order, this deletes:
- config/trace.cpp
- config/*.inc (seems to have been used by the nmake build system only)
- config/mklinkscript.pl
Comment 2•19 years ago
|
||
It seems to me like it might be worth it to resurrect the reorder option instead of killing it outright, no?
We can resurrect these from CVS if/when someone decides to set us up for this bomb again, I think. I prefer removing clutter (#if 0, unbuilt files, etc.) in the presence of even the minimal version management tools that CVS provides. :)
Updated•19 years ago
|
Attachment #219548 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 4•19 years ago
|
||
fixed on trunk, except for js/src/win32.order - I have no permission to check into spidermonkey.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 5•18 years ago
|
||
I actually didn't yet understand, what this should be good for at all.
Having reducing complexity in mind, I think its an good idea to remove it.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•