Closed Bug 309052 Opened 19 years ago Closed 18 years ago

remove broken Help button from CRL manager in Firefox

Categories

(Core :: Security: PSM, defect, P2)

Product:
Core
Component:
Security: PSM
Version:
1.8 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: p.franc, Assigned: steffen.wilberg)

References

Details

(Keywords: fixed1.8.1, useless-UI, Whiteboard: [kerh-coz])

Attachments

(1 file, 1 obsolete file)

patch with ifdef MOZ_SUITE instead
(deleted), patch
steffen.wilberg
: review+
KaiE
: superreview+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review
CRL manager (crlManager.xul) dialog has a Help button that opens empty help viewer window. The help button pointer is validation-crl-manage which is not defined in Firefox help documentation.
I think this is a known dupe, we got most of these but missed one.
That's bug 289555. *** This bug has been marked as a duplicate of 289555 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch patch (obsolete) (deleted) — — Splinter Review
Assignee: nobody → steffen.wilberg
Status: REOPENED → ASSIGNED
Attachment #198234 - Flags: review?(mconnor)
Component: Help Documentation → Security: PSM
Flags: review?(mconnor)
Product: Firefox → Core
Summary: CRL manager Help is not working → remove broken Help button from CRL manager in Firefox
Target Milestone: --- → mozilla1.8beta5
Version: 1.5 Branch → 1.8 Branch
Attachment #198234 - Flags: review?(mconnor)
Flags: blocking1.8rc1?
not a blocker but feel free to nominate a fully reviewed and verified on the trunk patch and we'll consider it for inclusion in the release.
Flags: blocking1.8rc1? → blocking1.8rc1-
Keywords: useless-UI
Flags: blocking1.8.1?
Flags: blocking1.8.1?
Flags: blocking1.8.1?
Whiteboard: [kerh-coz]
Priority: -- → P2
Target Milestone: mozilla1.8beta5 → mozilla1.9alpha
Comment on attachment 198234 [details] [diff] [review] patch please get review from kengert@redhat.com as well
Attachment #198234 - Flags: review?(mconnor) → review+
Comment on attachment 198234 [details] [diff] [review] patch >Index: mozilla/security/manager/pki/resources/content/crlManager.xul >- <spacer flex="2" /> >+#ifndef MOZ_XUL_APP >+ <spacer flex="2"/> > <button dlgtype="help"/> >+#endif Maybe we should use #ifdef MOZ_SUITE now that Seamonkey wants to become a MOZ_XUL_APP. But http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/Makefile.in#47 uses ifdef MOZ_XUL_APP as well.
Attachment #198234 - Flags: superreview?(kengert)
Everything meaning "suite only" should be set as "#ifdef MOZ_SUITE" - if it isn't, it's a bug. "#ifdef MOZ_XUL_APP" means "only for new-toolkit-based apps"
Ok, so this adds a Help button #ifdef MOZ_SUITE.
Attachment #198234 - Attachment is obsolete: true
Attachment #223979 - Flags: superreview?(kengert)
Attachment #223979 - Flags: review+
Attachment #198234 - Flags: superreview?(kengert)
Target Milestone: mozilla1.9alpha → mozilla1.8.1beta1
Attachment #223979 - Flags: superreview?(kengert) → superreview+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 18 years ago
Resolution: --- → FIXED
Attachment #223979 - Flags: approval-branch-1.8.1?(mconnor)
Flags: blocking1.8.1?
*** Bug 291432 has been marked as a duplicate of this bug. ***
Attachment #223979 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Checked in branch.
Keywords: fixed1.8.1
*** Bug 318932 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: