Currently the help viewer and help content are in the same chrome package. This is a bad toolkit dependency and needs to be fixed for 1.8 XULRunner. In addition, we are going to require localizers to localize the help system as well, so the localized help files need to live in browser/locales with everything else, and be shipped in en-US.jar.

Ohoho, a few weeks ago you were so against this move before 1.5... Should I prepare patch for this? :)

If we're doing this, shoudn't we just pack the help viewer into toolkit.jar?

Yes, that is exactly what I plan to do.

Comment on attachment 180053 [details] cvsmove help content for l10n sr=chase Is the app already sufficiently removed from the layout of code in CVS that moving these files around doesn't require any other changes to point to the new location?

It does require additional patch. I asked bsmedberg if I should write it, or he'll do this.

I'm making the patch, will be up shortly.

I am going to need to patch some of these copied files after they have been moved. Can we do the cvs copies now, so that I can prepare that patch?

During this process, I discovered that PSM is displaying help buttons that don't do anything functional. Discussion with mconnor decides that these buttons ought to be hidden since we don't actually have documentation behind them. Requesting second-review from brendan since I don't know who else to ask, is PSM still majorly unowned?

Kaie, are you still around? Can you review this?

(In reply to comment #9) > During this process, I discovered that PSM is displaying help buttons that > don't do anything functional. Discussion with mconnor decides that these > buttons ought to be hidden since we don't actually have documentation behind > them. On a related note, Thunderbird did this some time ago via a toolkit hack -- see bug 256915 and attachment 165624 [details] [diff] [review]. There are still other places where help buttons are used in Thunderbird that aren't in PSM, tho, so the ifdef still "has" to stay.

Bob Relyea may be willing to help -- IIRC he recently posted a big patch for PSM for smart-card support. /be

So I have 2 comments about the PSM patch... 1) I don't have any problems with commenting out the non-functioning help buttons in PSM until we can get content to turn them on.... however.... 2) It appears that the patch is actually commenting out much of the *WORKING* PSM UI (maybe I'm misunderstanding how xul works, but it appears that the this patch actually comments out the Cert Manager, for instance). That I would definately not support (especially since I've been adding patches to fix minor bugs in the UI). soo.. r+ on the idea, but r- on the patch unless someone can explain to me how the various dialogs still work with their xul packages commented out (or that the '*' in the jar.nm doesn't comment out the xul content, only linking help to that content. bob

Heehee! The * in the jar.mn is not a comment marker, it means that the XUL files will be run through the XUL preprocessor. So you needn't worry, the only UI I removed was the nonfunctional help buttons.

Comment on attachment 180483 [details] [diff] [review] Conditionally remove help buttons from PSM, rev. 1 comment 14 is sufficient explanation;). r+

The first file was malformed due to a regex error on my part, now fixed.

Comment on attachment 180702 [details] cvsmove help content for l10n, rev. 1.1 Move completed.

This patch unfortunately contains bits and pieces of bug 289461 and bug 287262, but it works and is ready for review.

Comment on attachment 180730 [details] [diff] [review] Make help content an integral part of the build process, rev. 1 sweet :)

Comment on attachment 180730 [details] [diff] [review] Make help content an integral part of the build process, rev. 1 >Index: browser/locales/en-US/chrome/help/firebirdhelp.rdf > nc:emptysearchtext="[No matching items found.]" >- nc:emptysearchlink="chrome://help/locale/welcome.xhtml#search_tips"/> >+ nc:emptysearchlink="chrome://browser/locales/help/welcome.xhtml#search_tips"/> > </rdf:li> welcome.xhtml is in toolkit, so this path is wrong. That was the only thing I noticed in five minutes of looking, and it's easily fixable before checkin.

Comment on attachment 180483 [details] [diff] [review] Conditionally remove help buttons from PSM, rev. 1 a=asa

Comment on attachment 180730 [details] [diff] [review] Make help content an integral part of the build process, rev. 1 a=asa

Checked in.

This bug caused Bug 291006.

I had forgotten to check in attachment 180483 [details] [diff] [review]; this is now fixed also.

Options->Security->Revocation Lists still has a Help button. And pressing that opens two empty Help windows... This change doesn't seem to work: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=crlManager.xul&branch=&root=/cvsroot&subdir=mozilla/security/manager/pki/resources/content&command=DIFF_FRAMESET&rev1=1.19&rev2=1.20

*** Bug 309052 has been marked as a duplicate of this bug. ***

(In reply to bug 309052 comment #0) > CRL manager (crlManager.xul) dialog has a Help button that opens empty help > viewer window. The help button pointer is validation-crl-manage which is not > defined in Firefox help documentation. The second patch in this bug missed that. Reopening.

Please file a new bug for remaining issues.