Closed
Bug 310843
Opened 19 years ago
Closed 19 years ago
EM requires the use of integer data for em:type
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This may be as trivial as the incorrect em:type being written to the extensions
datasource and I don't know what the worst case is... what ever the case the
current docs for everything except multiple item packages do not state that
em:type must be integer data. One example is language packs (see the patch in
bug 307225) - in this case they will have the em:type for an extension when the
following function is used.
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#634
Assignee | ||
Comment 1•19 years ago
|
||
We are going to need this for bug 285848.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #210646 -
Flags: review?(benjamin)
Updated•19 years ago
|
Attachment #210646 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•19 years ago
|
||
Fixed on trunk
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in
new revision: 1.170; previous revision: 1.169
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 3•19 years ago
|
||
>what ever the case the current docs for everything except multiple item packages
>do not state that em:type must be integer data.
No they do.
http://developer.mozilla.org/en/docs/install.rdf#type
Assignee | ||
Comment 4•19 years ago
|
||
(In reply to comment #3)
> >what ever the case the current docs for everything except multiple item packages
> >do not state that em:type must be integer data.
> No they do.
> http://developer.mozilla.org/en/docs/install.rdf#type
hmmm... the example on the link you provided is <em:type>2</em:type> which is not integer data so at least it doesn't state by example that it must be integer type data which would be along the lines of <em:type NC:parseType="Integer">4</em:type>
Comment 5•19 years ago
|
||
I'm sorry I referred to the description: "An integer value representing ..."
Assignee | ||
Updated•19 years ago
|
Attachment #210646 -
Attachment description: patch → patch (needs patch in Bug 326274 for MOZILLA_1_8_BRANCH)
Assignee | ||
Comment 6•19 years ago
|
||
Verbal a+ from bsmedberg... checked in on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•