Closed
Bug 326274
Opened 19 years ago
Closed 19 years ago
<em:type>2</em:type> In install.rdf Breaks reinstallation
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrtech, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060207 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060207 Firefox/1.6a1
Found the issue and going to file a bug against patch #310843
I have locally removed the "<em:type>2</em:type>" from my install.rdf file, which while not required I did have and that has solved my issue. I think I tested using <em:type NC:parseType="Integer">2</em:type> but since it's not required for extensions/theme as mentioned here: http://developer.mozilla.org/en/docs/install.rdf#type I figured it was safe to remove.
Reproducible: Always
Steps to Reproduce:
- create new profile,
- Run Firefox/1.6a1 - Build ID: 2006020705 trunk build
- Install my local install extension the 4.0 release or dev version or any extension with <em:type>2</em:type> in install.rdf
http://www.mrtech.com/extensions/local_install_dev.xpi
http://releases.mozilla.org/pub/mozilla.org/extensions/mr_tech_local_install/mr_tech_local_install-4.0-fx+mz+nv+tb.xpi
- Restart fx
- Install extension again, bam issue.
Actual Results:
Error msg as well as the following in JS Console:
safeInstallOperation: failed to clean up item location after its contents were properly backed up. Failed to clean up: D:\Documents and Settings\mreyes4\Application Data\Mozilla\Firefox\Profiles\77qtbczy.Default User\extensions\{9669CC8F-B388-42FE-86F4-CB5E7F5A8BDC} ... rolling back file moves and aborting installation.
----------
Error: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]
Source file: file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
Line: 498
Expected Results:
Just install/upgrade
Regression from https://bugzilla.mozilla.org/show_bug.cgi?id=310843 ?
removing <em:type>2</em:type> install.rdf restores install/upgrade functionality.
Updated•19 years ago
|
Assignee | ||
Comment 1•19 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #211088 -
Flags: review?(mconnor)
Updated•19 years ago
|
Attachment #211088 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 2•19 years ago
|
||
Fixed on trunk
Assignee | ||
Comment 3•19 years ago
|
||
Mel, I tested this pretty thoroughly but I would appreciate it if you would also. Thanks.
confirmed fixed with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060208 Firefox/1.6a1 - Build ID: 2006020809
thanks
I still have to remove <em:type>8<em:type> for locale extension to load in xulrunner from trunk (1.9a1).
Assignee | ||
Comment 6•19 years ago
|
||
(In reply to comment #5)
> I still have to remove <em:type>8<em:type> for locale extension to load in
> xulrunner from trunk (1.9a1).
That is a bug caused by the patch from bug 286034 and when the patch from bug 310843 landed to fix another bug from bug 286034 it exposed this bug. I plan on fixing the locale issue in bug 285848.
Assignee | ||
Comment 7•19 years ago
|
||
I created bug 327650 for the locale issue just to keep track of it and I am still planning on fixing it in bug 285848.
Assignee | ||
Comment 8•19 years ago
|
||
checked in on MOZILLA_1_8_BRANCH - verbal a+ from bsmedberg
Keywords: fixed1.8.1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•