unwrap_full_update.sh has indigestion with file paths with spaces in them (Mac OS X files). In unwrap_full_update.sh's case, you get (with some logging added): decompressing Firefox.app/Contents/MacOS/plugins/Default mv: cannot stat `Firefox.app/Contents/MacOS/plugins/Default': No such file or di rectory bzip2: Can't open input file Firefox.app/Contents/MacOS/plugins/Default.bz2: No such file or directory. decompressing Plugin.plugin/Contents/Resources/Default mv: cannot stat `Plugin.plugin/Contents/Resources/Default': No such file or dire ctory bzip2: Can't open input file Plugin.plugin/Contents/Resources/Default.bz2: No su ch file or directory. decompressing Plugin.rsrc mv: cannot stat `Plugin.rsrc': No such file or directory bzip2: Can't open input file Plugin.rsrc.bz2: No such file or directory. (the full path is actually: "Firefox.app/Contents/MacOS/plugins/Default Plugin.plugin/Contents/Resources/Default")

Fixed by unwrap_full_update.pl Checkin details: revision 1.1 date: 2006/02/13 20:44:38; author: benjamin%smedbergs.us; state: Exp; From bug 326465 - make unwrap_full_update space-aware (rewrite in perl for ease of coding and maintenance) Perhaps CVS removal of unwrap_full_update.sh would be a good idea ? Or some documentation in the shell script indicating limitations at least.

As per comment 1, it looks like this bug is fixed. Please reopen if this is not the case.

I don't see any checkins (CVS trunk or m-c) that indicate unwrap_full_update.sh has been fixed or removed. And in fact we are using it for our partial generation in nightlies builds, and are saved by plugins/Default Plugins getting deprecated. Really we should switch to unwrap_full_update.pl and remove the shell script. Got time for that coop ?

(In reply to comment #3) > Got time for that coop ? Yeah, I'll try to get to it later in the week.

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] Just ask for approval for all the branches on this patch.

Comment on attachment 473582 [details] [diff] [review] Use perl script to unwrap mars for nightlies http://hg.mozilla.org/build/buildbotcustom/rev/a70b38b40088

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] This is a pure script removal, is NPOTB, and I can kill my own builds immediately after landing to prevent tying up machines.

"approval2.0+" granted in email. > On 9/22/10 7:18 PM, Mike Beltzner wrote: >> Fine with me. >> >> John O'Duinn <joduinn@mozilla.com> wrote: >> hi; >> This is NPOTB - can we land this, or do we need approval? >>

The portion of this bug that required a reconfig already landed. Removing needs-reconfig+ -- coop, I'll leave it to you to land the remaining patch in mozilla-*

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] Missed the 1.9.2.11/1.9.1.14 releases

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] Try to get on the next release train now that I'm back from vacation.

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] Approved for 1.9.2.12 and 1.9.1.15, a=dveditz for release-drivers Landing sooner than later in the release would be appreciated.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7aeadba259be http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5bb0828aefe6 NPOTB, so triggered builds were canceled immediately.

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] Removing approval request. This is NPOTB.

Comment on attachment 473585 [details] [diff] [review] Remove the unwrap shell script [mozilla-central] http://hg.mozilla.org/mozilla-central/rev/e68b8f1399bd

This removal broke the SeaMonkey nightly tinderboxen: bash -c /builds/slave/comm-central-trunk-linux64-nightly/build/mozilla/tools/update-packaging/unwrap_full_update.sh ../dist/update/seamonkey-2.1b2pre.en-US.linux-x86_64.complete.mar What should this command be replaced with? The perl version of that script?

Oh nevermind, guess we just need to apply that patch to our config.

Comment on attachment 473582 [details] [diff] [review] Use perl script to unwrap mars for nightlies http://hg.mozilla.org/build/buildbotcustom/rev/70e4b33de199