Closed Bug 329306 Opened 19 years ago Closed 19 years ago

Make font scaling work

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: pavlov, Assigned: pavlov)

References

Details

Attachments

(1 file)

font scaling busted when we went to using HFONTs.
Attached patch fix/cleanup (deleted) — Splinter Review
Have each font keep around a CTM and check the Y scale against the current CTM. if they're different we need to blow away the existing HFONT and recreate it at the proper size. fallback fonts are always looked up every time, so it'll be created with the previous font's CTM which will be correct since we already tried that font. I also made some gfxMatrix changes so that we return const&s to avoid pointless copies. I verified the sites using the apis to ensure they copied if they really needed to otherwise they just used the reference.
Assignee: nobody → pavlov
Status: NEW → ASSIGNED
Attachment #213965 - Flags: review?(vladimir)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Backed out to try to fix 329315 (I've got the patch saved locally for re-applying if it didn't cause 329315).. but I'm about to fall asleep and gaius is being slow, so will check tomorrow morning.
the backout fixed bug 329315
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
not sure why this broke anything. should be good once 329259 lands
Depends on: 329259
relanded
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: