Closed Bug 331031 Opened 19 years ago Closed 3 years ago

use system smooth scrolling pref

Categories

(Core :: Widget: Cocoa, enhancement)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jacob, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Patch v2
(deleted), patch
asaf
: review-
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/417.9 (KHTML, like Gecko) Safari/417.9.2 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.2) Gecko/20060319 Firefox/1.5.0.2 In OS X 10.4 (likely earlier), there is a "Use Smooth Scrolling" in System Preferences -> Appearance. Firefox should probably use this instead of its "Use smooth scrolling" option. The following can get this pref from the command line in 10.4: $ defaults read .GlobalPreferences AppleScrollAnimationEnabled 1 Reproducible: Always
Related bug in Seamonkey : bug 236417.
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 362377 has been marked as a duplicate of this bug. ***
Attached patch Proposed fix (obsolete) (deleted) — — Splinter Review
Here's a fix that makes the view code respect the system setting. It also removes the UI for the pref. Roc, are you the right man for the review? I can have someone else look at the UI change if you want.
Attachment #247120 - Flags: review?(roc)
I'd prefer you to add this through nsILookAndFeel.
Attached patch Go through lookAndFeel instead (obsolete) (deleted) — — Splinter Review
Something like this?
Attachment #247270 - Flags: superreview?(roc)
Attachment #247120 - Attachment is obsolete: true
Attachment #247120 - Flags: review?(roc)
Attachment #247270 - Flags: superreview?(roc) → superreview+
Comment on attachment 247270 [details] [diff] [review] Go through lookAndFeel instead actually, one thing... you should make ShouldSmoothScroll be pure virtual in nsILookAndFeel, and add the default implementation of it to nsXPLookAndFeel.
Attachment #247270 - Flags: superreview+
Blocks: 362706
Assignee: nobody → hwaara
Attached patch Patch v2 (deleted) — — Splinter Review
Ok, this implements the ShouldSmootScroll() method in nsXPLookAndFeel as suggested in the last comment. Mano, please see the browser/ change.
Attachment #247270 - Attachment is obsolete: true
Attachment #247480 - Flags: superreview?(roc)
Attachment #247480 - Flags: review?(mano)
One more thing. Can you update NS_ILOOKANDFEEL_IID to a new IID? Thanks.
Comment on attachment 247480 [details] [diff] [review] Patch v2 This abuses nsILookAndFeel IMO. We should rather handle this the way other system-based prefs are handled, i.e. rely on the system preference only if it is not overridden. In other words, you should use the GetMetric system, see bug 187508 for example.
Attachment #247480 - Flags: review?(mano) → review-
(In reply to comment #9) > (From update of attachment 247480 [details] [diff] [review] [edit]) > This abuses nsILookAndFeel IMO. We should rather handle this the way other > system-based prefs are handled, i.e. rely on the system preference only if it > is not overridden. In other words, you should use the GetMetric system, see bug > 187508 for example. Abuses how? I don't see why this matters. We just need to return the boolean in one way or another, and I did it on Roc's suggestion. Mac overrides with the system pref, other platforms that don't have a native pref for this continue like before, which is the change this bug suggests.
You should be able to override the system pref from about:config by adding the pref manually, see how GetMetric works.
Component: Shell Integration → Widget: Cocoa
Product: Firefox → Core
Hardware: PowerPC → All
Version: unspecified → Trunk
This should not negatively affect Bug 964097 (though that's unlikely). Bug 640663 is about a somehow related OS X scrolling issue.
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=964097, https://bugzilla.mozilla.org/show_bug.cgi?id=640663

I can't find that preference under its old location or name. I suggest closing this bug if that preference has been removed.

Since smooth scrolling can be a migraine trigger, Firefox should retain some way to disable smooth scrolling regardless of whether the system has this preference.

The bug assignee didn't login in Bugzilla in the last 7 months.
:spohl, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: hwaara → nobody
Flags: needinfo?(spohl.mozilla.bugs)

Agree with comment 13. The system pref appears to have been removed from System Preferences > Appearance.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(spohl.mozilla.bugs)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: